Skip to content

refactor: Remove unused defines in qt/bitcoinunits.h #17869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2020
Merged

refactor: Remove unused defines in qt/bitcoinunits.h #17869

merged 1 commit into from
Jan 5, 2020
+0 −19

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Jan 4, 2020

In bitcoinunits.h some #defines introduced in #4167 are unused now.

@maflcko maflcko changed the title refactor: Remove unused defines in bitcoinunits.h refactor: Remove unused defines in qt/bitcoinunits.h Jan 4, 2020
@maflcko maflcko added the GUI label Jan 4, 2020
@laanwj
Copy link
Member

laanwj commented Jan 4, 2020

I looked at the history of src/qt/bitcoinunits.h and cannot find when this became unused. Do you know what changed?

@hebasto
Copy link
Member Author

hebasto commented Jan 4, 2020

I looked at the history of src/qt/bitcoinunits.h and cannot find when this became unused. Do you know what changed?

These #defines were never used.
It seems they all are the remnants from the initial version of #4167, I don't know for sure though.

@cvengler
Copy link
Contributor

cvengler commented Jan 4, 2020

Just grepped all removed defines.

ACK 7754d7a

@promag
Copy link
Contributor

promag commented Jan 4, 2020

ACK 7754d7a.

fanquake
fanquake approved these changes Jan 5, 2020
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7754d7a

These were all introduced in 7007402. FIGURE_SP_CP was the only one ever used, but it's use was removed in the following commit 2e4fee2.

THIN_SP_CP is defined as REAL_THIN_SP_CP

bitcoin/src/qt/bitcoinunits.h

Line 40 in 593f5e2

#define THIN_SP_CP REAL_THIN_SP_CP

fanquake added a commit that referenced this pull request Jan 5, 2020
@fanquake
Merge #17869: refactor: Remove unused defines in qt/bitcoinunits.h
da279fe 
7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov)

Pull request description:

  In `bitcoinunits.h` some `#define`s introduced in #4167 are unused now.

ACKs for top commit:
  emilengler:
    ACK 7754d7a
  fanquake:
    ACK 7754d7a
  promag:
    ACK 7754d7a.

Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
@fanquake fanquake merged commit 7754d7a into bitcoin:master Jan 5, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 5, 2020
@fanquake
Merge bitcoin#17869: refactor: Remove unused defines in qt/bitcoinuni…
641989f 
…ts.h

7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov)

Pull request description:

  In `bitcoinunits.h` some `#define`s introduced in bitcoin#4167 are unused now.

ACKs for top commit:
  emilengler:
    ACK 7754d7a
  fanquake:
    ACK 7754d7a
  promag:
    ACK 7754d7a.

Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
@hebasto hebasto deleted the 20200104-refactor-bitcoinunits branch January 5, 2020 07:24
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Apr 6, 2020
@MarkLTZ
Follow Bitcoin PRs:
8436547 
- gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged bitcoin#18160
- gui: Drop PeerTableModel dependency to ClientModel bitcoin#18060
- gui: Break trivial circular dependencies bitcoin#18036
- gui: Improve "Hide" button tool-tip message bitcoin#17360
- gui: Shortcut to close ModalOverlay bitcoin#17998
- gui: Remove warning "unused variable 'wallet_model'" bitcoin#17939
- refactor: Use PACKAGE_NAME in GUI modal overlay and bitcoin-wallet bitcoin#17923
- gui: remove OpenSSL PRNG seeding (Windows, Qt only) bitcoin#17151
- refactor: Remove unused defines in qt/bitcoinunits.h bitcoin#17869
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Sep 28, 2020
@hebasto @PiRK
refactor: Remove unused defines in bitcoinunits.h
523cfa0 
Summary:
This code was added in [[bitcoin/bitcoin@7007402 | 7007402]] and unused in the very next commit [[bitcoin/bitcoin@2e4fee2 | 2e4fee2]]

Backport of Core [[bitcoin/bitcoin#17869 | PR17869]]

Test Plan:

```
for IDENTIFIER in REAL_THIN_SP_HTML HAIR_SP_CP HAIR_SP_UTF8 HAIR_SP_HTML SIXPEREM_SP_CP SIXPEREM_SP_UTF8 SIXPEREM_SP_HTML FIGURE_SP_CP FIGURE_SP_UTF8 FIGURE_SP_HTML;
do
     grep -r $IDENTIFIER src/;
done
```

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7577
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
@fanquake
Merge bitcoin#17869: refactor: Remove unused defines in qt/bitcoinuni…
ea2d426 
…ts.h

7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov)

Pull request description:

  In `bitcoinunits.h` some `#define`s introduced in bitcoin#4167 are unused now.

ACKs for top commit:
  emilengler:
    ACK 7754d7a
  fanquake:
    ACK 7754d7a
  promag:
    ACK 7754d7a.

Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17869: refactor: Remove unused defines in qt/bitcoinuni…
13afe1d 
…ts.h

7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov)

Pull request description:

  In `bitcoinunits.h` some `#define`s introduced in dashpay#4167 are unused now.

ACKs for top commit:
  emilengler:
    ACK 7754d7a
  fanquake:
    ACK 7754d7a
  promag:
    ACK 7754d7a.

Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17869: refactor: Remove unused defines in qt/bitcoinuni…
710f886 
…ts.h

7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov)

Pull request description:

  In `bitcoinunits.h` some `#define`s introduced in dashpay#4167 are unused now.

ACKs for top commit:
  emilengler:
    ACK 7754d7a
  fanquake:
    ACK 7754d7a
  promag:
    ACK 7754d7a.

Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17869: refactor: Remove unused defines in qt/bitcoinuni…
a88d4c8 
…ts.h

7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov)

Pull request description:

  In `bitcoinunits.h` some `#define`s introduced in dashpay#4167 are unused now.

ACKs for top commit:
  emilengler:
    ACK 7754d7a
  fanquake:
    ACK 7754d7a
  promag:
    ACK 7754d7a.

Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17869: refactor: Remove unused defines in qt/bitcoinuni…
7121f0f 
…ts.h

7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov)

Pull request description:

  In `bitcoinunits.h` some `#define`s introduced in dashpay#4167 are unused now.

ACKs for top commit:
  emilengler:
    ACK 7754d7a
  fanquake:
    ACK 7754d7a
  promag:
    ACK 7754d7a.

Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17869: refactor: Remove unused defines in qt/bitcoinuni…
9a4f0fe 
…ts.h

7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov)

Pull request description:

  In `bitcoinunits.h` some `#define`s introduced in dashpay#4167 are unused now.

ACKs for top commit:
  emilengler:
    ACK 7754d7a
  fanquake:
    ACK 7754d7a
  promag:
    ACK 7754d7a.

Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 14, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17869: refactor: Remove unused defines in qt/bitcoinuni…
0ae0be7 
…ts.h

7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov)

Pull request description:

  In `bitcoinunits.h` some `#define`s introduced in dashpay#4167 are unused now.

ACKs for top commit:
  emilengler:
    ACK 7754d7a
  fanquake:
    ACK 7754d7a
  promag:
    ACK 7754d7a.

Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 14, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17869: refactor: Remove unused defines in qt/bitcoinuni…
bd334da 
…ts.h

7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov)

Pull request description:

  In `bitcoinunits.h` some `#define`s introduced in dashpay#4167 are unused now.

ACKs for top commit:
  emilengler:
    ACK 7754d7a
  fanquake:
    ACK 7754d7a
  promag:
    ACK 7754d7a.

Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 15, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#17869: refactor: Remove unused defines in qt/bitcoinuni…
bad56d0 
…ts.h

7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov)

Pull request description:

  In `bitcoinunits.h` some `#define`s introduced in dashpay#4167 are unused now.

ACKs for top commit:
  emilengler:
    ACK 7754d7a
  fanquake:
    ACK 7754d7a
  promag:
    ACK 7754d7a.

Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanquake fanquake fanquake approved these changes

Assignees
No one assigned
Labels
GUI Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hebasto @laanwj @cvengler @promag @fanquake @maflcko