doc: Added running functional tests in valgrind #17833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MAC build having (unrelated) issue: |
Thanks. yeah, i'm trying to figure out what's going on |
jonatack
reviewed
Dec 31, 2019
| @@ -250,6 +250,7 @@ $ valgrind --suppressions=contrib/valgrind.supp src/test/test_bitcoin | |||
| $ valgrind --suppressions=contrib/valgrind.supp --leak-check=full \ | |||
| --show-leak-kinds=all src/test/test_bitcoin --log_level=test_suite | |||
| $ valgrind -v --leak-check=full src/bitcoind -printtoconsole | |||
| $ ./test/functional/test_runner.py --valgrind | |||
There was a problem hiding this comment.
Thoughts:
- This should wait for tests: Add "make check-valgrind" to run the unit tests under Valgrind #17639
- This is example is visible when running
.test/functional/test_runner.py --help, which is not the case for the existing examples - There should be a dedicated valgrind doc to link to here, and/or sections in test/README.md and test/functional/README.md about running with valgrind
- In general, this section could use more documentation, updating, or a link to more details
- This example requires valgrind 3.14 or later, which is not the case for the existing examples, and that should be documented
|
@instagibbs python2 is not supported, have you tried with python3? |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 11, 2020
155a11f doc: Added running functional tests in valgrind (Elichai Turkel) Pull request description: Technically the notes only show an "example" of how to run valgrind with the suppression file, but now that bitcoin#17633 is merged then maybe this can encourage more people to run also the functional tests in valgrind Top commit has no ACKs. Tree-SHA512: b8417249b720d0ed5e10b732648f2e07e8889bfc7aa7e94192d1c049b4b7837971678d30c535f273c227848f1290cf11e14369fd6c1924b734f2e47e2af41401
|
Hi @MarcoFalke, I just had the same problem as @instagibbs and I'm also on OSX. You are right in that running |
|
This should never happen when |
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
155a11f doc: Added running functional tests in valgrind (Elichai Turkel) Pull request description: Technically the notes only show an "example" of how to run valgrind with the suppression file, but now that bitcoin#17633 is merged then maybe this can encourage more people to run also the functional tests in valgrind Top commit has no ACKs. Tree-SHA512: b8417249b720d0ed5e10b732648f2e07e8889bfc7aa7e94192d1c049b4b7837971678d30c535f273c227848f1290cf11e14369fd6c1924b734f2e47e2af41401
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically the notes only show an "example" of how to run valgrind with the suppression file,
but now that #17633 is merged then maybe this can encourage more people to run also the functional tests in valgrind