ci: Add CentOS 7 build #17635

hebasto · 2019-11-29T21:39:26Z

Arguably, CentOS is the most conservative distro of all the popular ones. Thus, it could be a good way to check the Bitcoin Core compatibility with aged dependencies.

Currently, CentOS 7 has:

Berkeley DB == 4.8.30
Boost == 1.53.0
GCC == 4.8.5
libevent == 2.0.21 < minimum required 2.0.22, but tests passed
MiniUPnPc == 2.0
Python == 3.6.8
qrencode == 3.4.1
Qt == 5.9.7
ZeroMQ == 4.1.4

~~Please note that this PR is based on the bugfix #17634.~~

Also trusty build has been removed for the following reasons:

Criteria to drop Trusty Travis #17628 (comment):

Maybe it'd make sense to replace Ubuntu Trusty with Centos 7 as the "check ancient backward compatibililty" Travis run. It's supported until 2024, apparently.

ci: Add CentOS 7 build #17635 (comment):

Our travis is currently running at its limit and this doesn't seem like it is adding a lot new coverage compared to the other builds.

Close #17628

hebasto · 2019-11-29T21:41:10Z

@laanwj's #17628 (comment):

Maybe it'd make sense to replace Ubuntu Trusty with Centos 7 as the "check ancient backward compatibililty" Travis run. It's supported until 2024, apparently.

DrahtBot · 2019-11-30T00:08:15Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#17490 (ci: Add valgrind run by MarcoFalke)
#12134 (Build previous releases and run functional tests by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

practicalswift · 2019-11-30T06:54:50Z

Concept ACK: diversity in testing is good

paymog

I'm new to the bitcoin codebase but this generally LGTM.

src/qt/recentrequeststablemodel.cpp

src/qt/peertablemodel.cpp

fanquake · 2019-12-02T02:41:58Z

Concept ACK

hebasto · 2019-12-02T16:37:24Z

Rebased after #17634 has been merged.

.travis.yml

laanwj · 2019-12-03T09:28:08Z

I think you should do a depends build here.

While the binary (and the tests) must run on CentOS 7 (this was a constraint on the libc version in #17538), it doesn't need to build with the ancient library versions provided there: CentOS 7 does not put a restriction on our minimum dependency versions.

laanwj · 2019-12-03T09:33:59Z

This also implicitly restricts the minimum supported g++ version to 4.8.5, complicating #16684 in the future. But I think we can worry about that then (maybe there's a way to install a newer compiler, no need to hold this up now).

hebasto · 2019-12-03T12:44:18Z

I think you should do a depends build here.

I have encountered a libevent build error on Travis (the local build is ok). Going to debug...

maflcko · 2019-12-03T14:06:46Z

But then, what is the point of using CentOs 7 to get all the old packages (of boost, etc) when a depends build is done anyway?

laanwj · 2019-12-03T14:16:41Z

I don't know. Some of the package versions make sense, for Qt even recent (5.9.7 is from last year), but In the case of libevent the version is absurdly old.

maflcko · 2019-12-03T14:20:01Z

We mostly had issues with compiling against older versions of boost (and qt). If the trusty run is eventually removed, we should have something else to run against an old version of boost.

laanwj · 2019-12-03T14:25:08Z

yes, the boost version is OK; and I don't think we can do a depends build without boost at this point

aj on IRC commented something about "software collections", could this be used to install a newer version of libevent only?

hebasto · 2019-12-03T14:32:11Z

aj on IRC commented something about "software collections", could this be used to install a newer version of libevent only?

https://www.softwarecollections.org/en/scls/?search=libevent

... nothing.

maflcko · 2019-12-03T14:54:24Z

ACK d88782e

maflcko · 2019-12-03T15:07:25Z

A nice follow up (either a new commit or pr) would be to adjust the readme and the list of packages to only the needed ones: boost-thread boost-test boost-filesystem boost-chrono instead of the entirety of boost.

hebasto · 2019-12-03T15:15:50Z

A nice follow up (either a new commit or pr) would be to adjust the readme and the list of packages to only the needed ones: boost-thread boost-test boost-filesystem boost-chrono instead of the entirety of boost.

CentOS / Fedora has only one boost-devel package.
There is no boost-{thread|test|filesystem|chrono}-devel packages, unfortunately.

promag · 2019-12-06T07:58:12Z

ACK d88782e.

.travis.yml

ci/test/00_setup_env_native_centos.sh

Co-authored-by: Emil Engler <me@emilengler.com>

maflcko · 2019-12-07T04:32:06Z

ACK 711e044 🚠

Show signature and timestamp

Signature:

Timestamp of file with hash 6113c2488002e62c4f29f31002293d1c4fcd8b73206b423cb8ff1244d50cc142 -

711e044 ci: Remove trusty build (Hennadii Stepanov) 7f3ae22 ci: Add CentOS 7 build (Hennadii Stepanov) Pull request description: Arguably, CentOS is the most conservative distro of all the popular ones. Thus, it could be a good way to check the Bitcoin Core compatibility with aged dependencies. Currently, CentOS 7 has: - Berkeley DB == 4.8.30 - Boost == 1.53.0 - GCC == 4.8.5 - libevent == 2.0.21 < minimum required [2.0.22](https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md), but tests passed - MiniUPnPc == 2.0 - Python == 3.6.8 - qrencode == 3.4.1 - Qt == 5.9.7 - ZeroMQ == 4.1.4 ~Please note that this PR is based on the bugfix #17634.~ Also trusty build has been removed for the following reasons: - #17628 (comment): > Maybe it'd make sense to replace Ubuntu Trusty with Centos 7 as the "check ancient backward compatibililty" Travis run. It's supported until 2024, apparently. - #17635 (comment): > Our travis is currently running at its limit and this doesn't seem like it is adding a lot new coverage compared to the other builds. Close #17628 ACKs for top commit: MarcoFalke: ACK 711e044 🚠 Tree-SHA512: 614ec8394943f482a5867067f7119bffd052924a51e32ffda9a08e10c392c4a955a3539e2f8907cb65bfd9347dadf0ba62f6d1530bbc49927c347360a5a7f73c

711e044 ci: Remove trusty build (Hennadii Stepanov) 7f3ae22 ci: Add CentOS 7 build (Hennadii Stepanov) Pull request description: Arguably, CentOS is the most conservative distro of all the popular ones. Thus, it could be a good way to check the Bitcoin Core compatibility with aged dependencies. Currently, CentOS 7 has: - Berkeley DB == 4.8.30 - Boost == 1.53.0 - GCC == 4.8.5 - libevent == 2.0.21 < minimum required [2.0.22](https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md), but tests passed - MiniUPnPc == 2.0 - Python == 3.6.8 - qrencode == 3.4.1 - Qt == 5.9.7 - ZeroMQ == 4.1.4 ~Please note that this PR is based on the bugfix bitcoin#17634.~ Also trusty build has been removed for the following reasons: - bitcoin#17628 (comment): > Maybe it'd make sense to replace Ubuntu Trusty with Centos 7 as the "check ancient backward compatibililty" Travis run. It's supported until 2024, apparently. - bitcoin#17635 (comment): > Our travis is currently running at its limit and this doesn't seem like it is adding a lot new coverage compared to the other builds. Close bitcoin#17628 ACKs for top commit: MarcoFalke: ACK 711e044 🚠 Tree-SHA512: 614ec8394943f482a5867067f7119bffd052924a51e32ffda9a08e10c392c4a955a3539e2f8907cb65bfd9347dadf0ba62f6d1530bbc49927c347360a5a7f73c

elichai · 2019-12-08T12:42:50Z

ACK After merge. I actually think this can help us more confidently bump the C++ version in the future (probably will require bumping to CentOS 8)

711e044 ci: Remove trusty build (Hennadii Stepanov) 7f3ae22 ci: Add CentOS 7 build (Hennadii Stepanov) Pull request description: Arguably, CentOS is the most conservative distro of all the popular ones. Thus, it could be a good way to check the Bitcoin Core compatibility with aged dependencies. Currently, CentOS 7 has: - Berkeley DB == 4.8.30 - Boost == 1.53.0 - GCC == 4.8.5 - libevent == 2.0.21 < minimum required [2.0.22](https://github.com/bitcoin/bitcoin/blob/master/doc/dependencies.md), but tests passed - MiniUPnPc == 2.0 - Python == 3.6.8 - qrencode == 3.4.1 - Qt == 5.9.7 - ZeroMQ == 4.1.4 ~Please note that this PR is based on the bugfix bitcoin#17634.~ Also trusty build has been removed for the following reasons: - bitcoin#17628 (comment): > Maybe it'd make sense to replace Ubuntu Trusty with Centos 7 as the "check ancient backward compatibililty" Travis run. It's supported until 2024, apparently. - bitcoin#17635 (comment): > Our travis is currently running at its limit and this doesn't seem like it is adding a lot new coverage compared to the other builds. Close bitcoin#17628 ACKs for top commit: MarcoFalke: ACK 711e044 🚠 Tree-SHA512: 614ec8394943f482a5867067f7119bffd052924a51e32ffda9a08e10c392c4a955a3539e2f8907cb65bfd9347dadf0ba62f6d1530bbc49927c347360a5a7f73c

DrahtBot added Build system GUI Tests Validation labels Nov 29, 2019

fanquake removed Build system GUI Validation labels Nov 30, 2019

paymog reviewed Nov 30, 2019

View reviewed changes

src/qt/recentrequeststablemodel.cpp Outdated Show resolved Hide resolved

src/qt/peertablemodel.cpp Outdated Show resolved Hide resolved

hebasto force-pushed the 20191129-travis-centos-build branch from 986aee8 to 8f62ec6 Compare December 2, 2019 16:36

hebasto mentioned this pull request Dec 2, 2019

Minimum required libevent version #17652

Closed

maflcko approved these changes Dec 3, 2019

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

hebasto force-pushed the 20191129-travis-centos-build branch from 8f62ec6 to d88782e Compare December 3, 2019 05:45

maflcko reviewed Dec 6, 2019

View reviewed changes

.travis.yml Show resolved Hide resolved

maflcko reviewed Dec 6, 2019

View reviewed changes

ci/test/00_setup_env_native_centos.sh Show resolved Hide resolved

maflcko changed the title ~~build: Add Travis CentOS 7 build~~ ci: Add CentOS 7 build Dec 6, 2019

hebasto and others added 2 commits December 6, 2019 21:44

ci: Add CentOS 7 build

7f3ae22

ci: Remove trusty build

711e044

Co-authored-by: Emil Engler <me@emilengler.com>

hebasto force-pushed the 20191129-travis-centos-build branch from d88782e to 711e044 Compare December 6, 2019 19:56

maflcko merged commit 711e044 into bitcoin:master Dec 7, 2019

hebasto mentioned this pull request Dec 7, 2019

build: Discrepancy in Trusty Travis build #17656

Closed

hebasto deleted the 20191129-travis-centos-build branch December 7, 2019 09:21

MarkLTZ mentioned this pull request Apr 4, 2020

Bitcoin PR tracking litecoinz-core/litecoinz#14

Closed

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

ci: Add CentOS 7 build #17635

ci: Add CentOS 7 build #17635

Uh oh!

Conversation

hebasto commented Nov 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Nov 29, 2019

Uh oh!

DrahtBot commented Nov 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

practicalswift commented Nov 30, 2019

Uh oh!

paymog left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fanquake commented Dec 2, 2019

Uh oh!

hebasto commented Dec 2, 2019

Uh oh!

Uh oh!

laanwj commented Dec 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Dec 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Dec 3, 2019

Uh oh!

maflcko commented Dec 3, 2019

Uh oh!

laanwj commented Dec 3, 2019

Uh oh!

maflcko commented Dec 3, 2019

Uh oh!

laanwj commented Dec 3, 2019

Uh oh!

hebasto commented Dec 3, 2019

Uh oh!

maflcko commented Dec 3, 2019

Uh oh!

maflcko commented Dec 3, 2019

Uh oh!

hebasto commented Dec 3, 2019

Uh oh!

promag commented Dec 6, 2019

Uh oh!

Uh oh!

Uh oh!

maflcko commented Dec 7, 2019

Uh oh!

elichai commented Dec 8, 2019

Uh oh!

Uh oh!

hebasto commented Nov 29, 2019 •

edited

Loading

DrahtBot commented Nov 30, 2019 •

edited

Loading

laanwj commented Dec 3, 2019 •

edited

Loading

laanwj commented Dec 3, 2019 •

edited

Loading