ci: Run functional tests on s390x #17599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requested by @sipa here #17591 (comment) |
maflcko
commented
Nov 25, 2019
faa8854 to
fa94fc1
Compare
|
Also fixed a bug in the functional tests See https://docs.python.org/3/library/struct.html#byte-order-size-and-alignment |
|
Concept ACK Very happy to see this added! And very satisfying to see that this caught a bug directly :) |
|
Concept ACK |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
ACK if it doesn't make Travis much slower, a bit slower may be worth it to have a full big-endian CI run. |
|
For some reason this is one of the fastest machines on travis. Installing all packages only took 49 seconds (instead of minutes) and a build from scratch + unit tests + functional tests ran in 15 minutes. I'd argue that we should switch all native builds to run on that architecture instead of amd64. |
|
@MarcoFalke So apparently I did all that too today lol. (was just about to open a PR when sipa told me you already did) |
|
@elichai Sweet. Looks like you fixed a bug in our depends qt build. So a fresh PR might be the best. |
maflcko
pushed a commit
that referenced
this pull request
Dec 3, 2019
fabd710 ci: Print free disk space (MarcoFalke) fad9fdb test: Properly deserialize integers in little-endian (MarcoFalke) fa94fc1 ci: Run functional tests on s390x (MarcoFalke) Pull request description: Top commit has no ACKs. Tree-SHA512: 98ba77eb56f283131fdaeb393fda86cc308f1bf9781e1e0e5736b8d616528dc8ff2e494d55ba107c138083025c66a59e382fcfa9962d4349a5fd6cbbc52484c3
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 3, 2019
fabd710 ci: Print free disk space (MarcoFalke) fad9fdb test: Properly deserialize integers in little-endian (MarcoFalke) fa94fc1 ci: Run functional tests on s390x (MarcoFalke) Pull request description: Top commit has no ACKs. Tree-SHA512: 98ba77eb56f283131fdaeb393fda86cc308f1bf9781e1e0e5736b8d616528dc8ff2e494d55ba107c138083025c66a59e382fcfa9962d4349a5fd6cbbc52484c3
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Dec 17, 2019
e190000 ci-s390x: Add qemu and depends support in the ci script (Elichai Turkel) Pull request description: Related: bitcoin#17599 This adds qemu support just like we have in arm and compile the depends. other than that I also fixed some missing includes to make the depends compile. ACKs for top commit: MarcoFalke: ACK e190000 (first commit only, didn't look at second commit) Tree-SHA512: 2b8a39772b86408569f52cdc33832dbce7e5e9cdd710524295f3d259628cdfc017e740f6f94941307d7f8e413236814a95ba851153c617eb5fb75b4bd9a7e52f
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 17, 2019
e190000 ci-s390x: Add qemu and depends support in the ci script (Elichai Turkel) Pull request description: Related: bitcoin#17599 This adds qemu support just like we have in arm and compile the depends. other than that I also fixed some missing includes to make the depends compile. ACKs for top commit: MarcoFalke: ACK e190000 (first commit only, didn't look at second commit) Tree-SHA512: 2b8a39772b86408569f52cdc33832dbce7e5e9cdd710524295f3d259628cdfc017e740f6f94941307d7f8e413236814a95ba851153c617eb5fb75b4bd9a7e52f
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 5, 2020
Summary: This fixes a bug in a functional test. The bug was detected after Core started running CI tests for a big endian platform (see [[https://github.com/bitcoin/bitcoin/pull/17591/files | PR17591]] and [[bitcoin/bitcoin#17599 | PR17599]]). This is a partial backport of Core [[bitcoin/bitcoin#17599 | PR17599]] bitcoin/bitcoin@fad9fdb Test Plan: `ninja && test/functional/test_runner.py interface_rest` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8283
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
fabd710 ci: Print free disk space (MarcoFalke) fad9fdb test: Properly deserialize integers in little-endian (MarcoFalke) fa94fc1 ci: Run functional tests on s390x (MarcoFalke) Pull request description: Top commit has no ACKs. Tree-SHA512: 98ba77eb56f283131fdaeb393fda86cc308f1bf9781e1e0e5736b8d616528dc8ff2e494d55ba107c138083025c66a59e382fcfa9962d4349a5fd6cbbc52484c3
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
e190000 ci-s390x: Add qemu and depends support in the ci script (Elichai Turkel) Pull request description: Related: bitcoin#17599 This adds qemu support just like we have in arm and compile the depends. other than that I also fixed some missing includes to make the depends compile. ACKs for top commit: MarcoFalke: ACK e190000 (first commit only, didn't look at second commit) Tree-SHA512: 2b8a39772b86408569f52cdc33832dbce7e5e9cdd710524295f3d259628cdfc017e740f6f94941307d7f8e413236814a95ba851153c617eb5fb75b4bd9a7e52f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.