Skip to content

Conversation

fanquake
Copy link
Member

Extracted from #16392 as this doesn't need to wait for the other build changes.

Reasoning:

  • 10.10 has been unsupported since July 2017 (~3 years at v0.20.0 release)
  • 10.11 has been unsupported since July 2018 (~2 years at v0.20.0 release)
  • macOS users are consistent at upgrading to new releases.
  • Qt 5.12 LTS only supports macOS > 10.12. As long as we're supporting macOS < 10.12 we would not be able to bump Qt in depends to 5.12 for the v0.20.0 release.

Once we drop support for 10.12 and start using the 10.15 SDK there are some other follow ups:

There was also some related discussion in the #bitcoin-builds channel yesterday arvo.

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 21, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #17558 (build: organize tests by goal by RandyMcMillan)
  • #17099 (depends: Eliminate hard dependency on Ubuntu-ABI specific clang by dongcarl)
  • #16392 (build: macOS toolchain update by fanquake)
  • #12557 ([WIP] 64 bit iOS device support by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot
Copy link
Contributor

Gitian builds

File commit ae69436
(master)
commit 0378a9d
(master and this pull)
bitcoin-0.19.99-osx-unsigned.dmg a7077050e4e2bed9... 7dfca23b6cd1426b...
bitcoin-0.19.99-osx64.tar.gz b8bddf81623819d9... 24fe8f3d6df1d254...
bitcoin-0.19.99-win64-debug.zip 222ac303e7213421... a2361870d818adaf...
bitcoin-0.19.99-win64-setup-unsigned.exe f924c6a25deb4fe0... 4f8aa9d39708ca88...
bitcoin-0.19.99-win64.zip bc4bd2e95d543f51... 621d8c992e81991e...
bitcoin-0.19.99.tar.gz 758ae50b9c3a4da5... 88dd5b04c3a05b62...
bitcoin-core-osx-0.20-res.yml 111f0057f97ae6d1... a83a53609bd8423c...
bitcoin-core-win-0.20-res.yml dcf3b20a7eed8d5a... 075c2a1cc31e28a1...
linux-build.log 6cf45344f07c50f6... 5f1607ce41b0b8ae...
osx-build.log 34aae11122a92ea9... d9e3ec24998793ce...
win-build.log 129e7447b12a2ac4... ba706f5142ef5355...
bitcoin-core-osx-0.20-res.yml.diff 7c96d905cbbfe621...
bitcoin-core-win-0.20-res.yml.diff dadf77bd87ce5ca0...
linux-build.log.diff 80b1343d123a64ab...
osx-build.log.diff 084846f457a20d54...
win-build.log.diff 02649eebf38a0375...

@laanwj
Copy link
Member

laanwj commented Nov 22, 2019

ACK 7d7bf2f

@dongcarl
Copy link
Contributor

dongcarl commented Nov 22, 2019

So this bumps the supported OSX version, but doesn't bump the SDK? (At least not a major version of the SDK?)

Edit: What I'm trying to ask is, could we have bumped the supported OSX version without bumping the SDK?

@fanquake
Copy link
Member Author

could we have bumped the supported OSX version without bumping the SDK

That's what this PR is doing. This increases our minimum supported macOS version from 10.10 to 10.12. Nothing SDK related is changing, the change to start using the 10.14 SDK over the 10.11 SDK is still in #16392.

@dongcarl
Copy link
Contributor

dongcarl commented Nov 22, 2019

post-IRC-grilling-ACK 7d7bf2f

See http://gnusha.org/bitcoin-builds/2019-11-22.log

fanquake added a commit that referenced this pull request Nov 22, 2019
7d7bf2f build: set minimum supported macOS to 10.12 (fanquake)

Pull request description:

  Extracted from #16392 as this doesn't need to wait for the other build changes.

  Reasoning:
  * `10.10` has been unsupported since July 2017 (~3 years at `v0.20.0` release)
  * `10.11` has been unsupported since July 2018  (~2 years at `v0.20.0` release)
  * macOS users are consistent at upgrading to new releases.
  * Qt 5.12 LTS only supports [macOS > 10.12](https://doc-snapshots.qt.io/qt5-5.12/supported-platforms.html). As long as we're supporting macOS < 10.12 we would not be able to bump Qt in depends to 5.12 for the `v0.20.0` release.

  Once we drop support for 10.12 and start using the 10.15 SDK there are some other follow ups:
  * Enabling support for [`thread_local`](https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L901).
  * Removing some of the macOS notification code
  * Removing macOS [startup item code](https://github.com/bitcoin/bitcoin/blob/master/src/qt/guiutil.cpp#L695).

  There was also some related discussion in the `#bitcoin-builds` channel yesterday arvo.

ACKs for top commit:
  laanwj:
    ACK 7d7bf2f
  dongcarl:
    post-IRC-grilling-ACK 7d7bf2f

Tree-SHA512: 30b0ed75e3b4df2d3f94db2091b7982c1ea7be8fb3a2732d8efd1a53ef1e492d7265a47e90c38e92f66e638d10e9400a6ecb56e5093688bb26d1621645b453e8
@fanquake fanquake merged commit 7d7bf2f into bitcoin:master Nov 22, 2019
@fanquake fanquake deleted the macOS_10_12_minimum branch November 22, 2019 20:37
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 22, 2019
7d7bf2f build: set minimum supported macOS to 10.12 (fanquake)

Pull request description:

  Extracted from bitcoin#16392 as this doesn't need to wait for the other build changes.

  Reasoning:
  * `10.10` has been unsupported since July 2017 (~3 years at `v0.20.0` release)
  * `10.11` has been unsupported since July 2018  (~2 years at `v0.20.0` release)
  * macOS users are consistent at upgrading to new releases.
  * Qt 5.12 LTS only supports [macOS > 10.12](https://doc-snapshots.qt.io/qt5-5.12/supported-platforms.html). As long as we're supporting macOS < 10.12 we would not be able to bump Qt in depends to 5.12 for the `v0.20.0` release.

  Once we drop support for 10.12 and start using the 10.15 SDK there are some other follow ups:
  * Enabling support for [`thread_local`](https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L901).
  * Removing some of the macOS notification code
  * Removing macOS [startup item code](https://github.com/bitcoin/bitcoin/blob/master/src/qt/guiutil.cpp#L695).

  There was also some related discussion in the `#bitcoin-builds` channel yesterday arvo.

ACKs for top commit:
  laanwj:
    ACK 7d7bf2f
  dongcarl:
    post-IRC-grilling-ACK 7d7bf2f

Tree-SHA512: 30b0ed75e3b4df2d3f94db2091b7982c1ea7be8fb3a2732d8efd1a53ef1e492d7265a47e90c38e92f66e638d10e9400a6ecb56e5093688bb26d1621645b453e8
@DrahtBot
Copy link
Contributor

Gitian builds

File commit 03f6f40
(master)
commit a871199
(master and this pull)
bitcoin-0.19.99-osx-unsigned.dmg 0c1faf592001a4bc... 14c86c654773a234...
bitcoin-0.19.99-osx64.tar.gz 1802721036ef4368... 17e3fc51fd131721...
bitcoin-0.19.99-win64-debug.zip 849a34a9b645e1c8... 5b164d8c0d1a7bf7...
bitcoin-0.19.99-win64-setup-unsigned.exe 0d302fe511dbe175... f77c950fb0ca7b6c...
bitcoin-0.19.99-win64.zip a406548e44896849... d93d7ce13f02835c...
bitcoin-0.19.99.tar.gz 569f33ef5ea223d2... 5a653c86a4de54d8...
bitcoin-core-osx-0.20-res.yml 585f6e1c23d5bc1a... b6d79cf77133f80e...
bitcoin-core-win-0.20-res.yml 04e71aa86e9740e6... 388e6b762624d79f...
linux-build.log 33e4113947a45350... 25f1a916e4a97572...
osx-build.log 62d5264be52cd130... 51d6e22f9f321bf6...
win-build.log 901967e161ef3d60... 565c4236d457b63c...
bitcoin-core-osx-0.20-res.yml.diff 351556ba8317d4e4...
bitcoin-core-win-0.20-res.yml.diff 3debf004ba9a5b47...
linux-build.log.diff ad657631442dad74...
osx-build.log.diff 2ea06ae8d37f68a3...
win-build.log.diff de8a2c5f9169ac4e...

fanquake added a commit to fanquake/bitcoin that referenced this pull request Nov 22, 2019
The macOS startup item code was disabled for builds targeting macOS >
10.11 in bitcoin#15208. Now that we require macOS 10.12 as a minimum, bitcoin#17550,
we can remove the startup item code entirely, as the API we were using
was removed in macOS 10.12.
fanquake added a commit that referenced this pull request Nov 26, 2019
27d82b6 gui: remove macOS start on login code (fanquake)

Pull request description:

  The macOS startup item code was disabled for builds targeting macOS >
  `10.11` in #15208. Now that we require macOS `10.12` as a minimum (#17550),
  we can remove the startup item code entirely. The API we were using, `LSSharedFileListItemCopyResolvedURL`, `LSSharedFileListCopySnapshot` etc,
  was removed in macOS `10.12` SDK.

ACKs for top commit:
  jonasschnelli:
    utACK 27d82b6
  jonasschnelli:
    Tested ACK 27d82b6 - successfully compiled on 10.15.1

Tree-SHA512: 7420757b91c7820e6a63280887155394547134a9cebcf3721af0284da23292627f94cd431241e033075b3fd86d79ace3ebf1b25d17763acbf71e07a742395409
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 27, 2019
27d82b6 gui: remove macOS start on login code (fanquake)

Pull request description:

  The macOS startup item code was disabled for builds targeting macOS >
  `10.11` in bitcoin#15208. Now that we require macOS `10.12` as a minimum (bitcoin#17550),
  we can remove the startup item code entirely. The API we were using, `LSSharedFileListItemCopyResolvedURL`, `LSSharedFileListCopySnapshot` etc,
  was removed in macOS `10.12` SDK.

ACKs for top commit:
  jonasschnelli:
    utACK 27d82b6
  jonasschnelli:
    Tested ACK 27d82b6 - successfully compiled on 10.15.1

Tree-SHA512: 7420757b91c7820e6a63280887155394547134a9cebcf3721af0284da23292627f94cd431241e033075b3fd86d79ace3ebf1b25d17763acbf71e07a742395409
laanwj added a commit that referenced this pull request Mar 17, 2020
f9f210d doc: fix GetTimeMicros() comment in random.cpp (fanquake)
a889711 rand: remove getentropy() fallback for macOS < 10.12 (fanquake)

Pull request description:

  We [no longer support macOS < 10.12](#17550) (our binaries will not run), so remove the fallback for when `getentropy()` wasn't available. From the manpage:

  ```bash
  HISTORY
       The getentropy() function appeared in OSX 10.12
  ```

  Note that compiling on macOS you'll see a new unused function warning:
  ```bash
  random.cpp:256:13: warning: unused function 'GetDevURandom' [-Wunused-function]
  static void GetDevURandom(unsigned char *ent32)
              ^
  1 warning generated.
  ```

  This will likely be addressed as part of #17563.

ACKs for top commit:
  vasild:
    ACK f9f210d (code review, not tested)
  elichai:
    utACK f9f210d
  practicalswift:
    ACK f9f210d -- patch looks correct
  laanwj:
    ACK f9f210d
  hebasto:
    ACK f9f210d, tested on macOS 10.13.6: compiled

Tree-SHA512: 6bd2a721f23605a8bca0b7b51f42d628ebf92a18e74eb43194331ba745ee449223aff84119892781c40b188c70b75417447f4e390e3d9ac549292de2b1e8b308
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 18, 2020
… 10.12

f9f210d doc: fix GetTimeMicros() comment in random.cpp (fanquake)
a889711 rand: remove getentropy() fallback for macOS < 10.12 (fanquake)

Pull request description:

  We [no longer support macOS < 10.12](bitcoin#17550) (our binaries will not run), so remove the fallback for when `getentropy()` wasn't available. From the manpage:

  ```bash
  HISTORY
       The getentropy() function appeared in OSX 10.12
  ```

  Note that compiling on macOS you'll see a new unused function warning:
  ```bash
  random.cpp:256:13: warning: unused function 'GetDevURandom' [-Wunused-function]
  static void GetDevURandom(unsigned char *ent32)
              ^
  1 warning generated.
  ```

  This will likely be addressed as part of bitcoin#17563.

ACKs for top commit:
  vasild:
    ACK f9f210d (code review, not tested)
  elichai:
    utACK f9f210d
  practicalswift:
    ACK f9f210d -- patch looks correct
  laanwj:
    ACK f9f210d
  hebasto:
    ACK f9f210d, tested on macOS 10.13.6: compiled

Tree-SHA512: 6bd2a721f23605a8bca0b7b51f42d628ebf92a18e74eb43194331ba745ee449223aff84119892781c40b188c70b75417447f4e390e3d9ac549292de2b1e8b308
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Mar 20, 2020
Summary:
```
Reasoning:

    10.10 has been unsupported since July 2017 (~3 years at v0.20.0
release)
    10.11 has been unsupported since July 2018 (~2 years at v0.20.0
release)
    macOS users are consistent at upgrading to new releases.
    Qt 5.12 LTS only supports macOS > 10.12. As long as we're supporting
macOS < 10.12 we would not be able to bump Qt in depends to 5.12 for the
v0.20.0 release.
```

Backport of core [[bitcoin/bitcoin#17550 | PR17550]].

Test Plan:
Run the OSX Gitian build.
Run the binary on 10.12 and 10.15.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5514
deadalnix pushed a commit to Bitcoin-ABC/secp256k1 that referenced this pull request Mar 21, 2020
Summary:
```
Reasoning:

    10.10 has been unsupported since July 2017 (~3 years at v0.20.0
release)
    10.11 has been unsupported since July 2018 (~2 years at v0.20.0
release)
    macOS users are consistent at upgrading to new releases.
    Qt 5.12 LTS only supports macOS > 10.12. As long as we're supporting
macOS < 10.12 we would not be able to bump Qt in depends to 5.12 for the
v0.20.0 release.
```

Backport of core [[bitcoin/bitcoin#17550 | PR17550]].

Test Plan:
Run the OSX Gitian build.
Run the binary on 10.12 and 10.15.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5514
HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Apr 17, 2020
The macOS startup item code was disabled for builds targeting macOS >
10.11 in bitcoin#15208. Now that we require macOS 10.12 as a minimum, bitcoin#17550,
we can remove the startup item code entirely, as the API we were using
was removed in macOS 10.12.
ftrader pushed a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this pull request May 19, 2020
Summary:
```
Reasoning:

    10.10 has been unsupported since July 2017 (~3 years at v0.20.0
release)
    10.11 has been unsupported since July 2018 (~2 years at v0.20.0
release)
    macOS users are consistent at upgrading to new releases.
    Qt 5.12 LTS only supports macOS > 10.12. As long as we're supporting
macOS < 10.12 we would not be able to bump Qt in depends to 5.12 for the
v0.20.0 release.
```

Backport of core [[bitcoin/bitcoin#17550 | PR17550]].
Includes fix D5530 (368a0fa) by Fabien.

Test Plan:
Run the OSX Gitian build.
Run the binary on 10.12 and 10.15.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5514
zkbot added a commit to zcash/zcash that referenced this pull request Jul 30, 2020
Modernise macOS cross-compilation toolchain

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#13617
  - Excluding the QT GUI changes.
- bitcoin/bitcoin#17550
- bitcoin/bitcoin#16392
  - Excluding the QT GUI changes.
- bitcoin/bitcoin#18589
- bitcoin/bitcoin#19240
- bitcoin/bitcoin#19407
- bitcoin/bitcoin#17919
  - Only the ancillary changes, not the `FORCE_USE_SYSTEM_CLANG` change.
- bitcoin/bitcoin#19530

After these changes, macOS versions earlier than 10.12 are no longer supported.

To cross-compile for macOS:
- Follow the instructions in `contrib/macdeploy/README.md` to generate
  `Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers.tar.gz`
  (requires an Apple Developer Account)
- Extract it into `depends/SDKs` (creating that folder first if it does not exist)
- `HOST=x86_64-apple-darwin16 ./zcutil/build.sh`
zkbot added a commit to zcash/zcash that referenced this pull request Aug 7, 2020
Modernise macOS cross-compilation toolchain

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#13617
  - Excluding the QT GUI changes.
- bitcoin/bitcoin#17550
- bitcoin/bitcoin#16392
  - Excluding the QT GUI changes.
- bitcoin/bitcoin#18589
- bitcoin/bitcoin#19240
- bitcoin/bitcoin#19407
- bitcoin/bitcoin#17919
  - Only the ancillary changes, not the `FORCE_USE_SYSTEM_CLANG` change.
- bitcoin/bitcoin#19530

After these changes, macOS versions earlier than 10.12 are no longer supported.

To cross-compile for macOS:
- Follow the instructions in `contrib/macdeploy/README.md` to generate
  `Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers.tar.gz`
  (requires an Apple Developer Account)
- Extract it into `depends/SDKs` (creating that folder first if it does not exist)
- `HOST=x86_64-apple-darwin16 ./zcutil/build.sh`
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
7d7bf2f build: set minimum supported macOS to 10.12 (fanquake)

Pull request description:

  Extracted from bitcoin#16392 as this doesn't need to wait for the other build changes.

  Reasoning:
  * `10.10` has been unsupported since July 2017 (~3 years at `v0.20.0` release)
  * `10.11` has been unsupported since July 2018  (~2 years at `v0.20.0` release)
  * macOS users are consistent at upgrading to new releases.
  * Qt 5.12 LTS only supports [macOS > 10.12](https://doc-snapshots.qt.io/qt5-5.12/supported-platforms.html). As long as we're supporting macOS < 10.12 we would not be able to bump Qt in depends to 5.12 for the `v0.20.0` release.

  Once we drop support for 10.12 and start using the 10.15 SDK there are some other follow ups:
  * Enabling support for [`thread_local`](https://github.com/bitcoin/bitcoin/blob/master/configure.ac#L901).
  * Removing some of the macOS notification code
  * Removing macOS [startup item code](https://github.com/bitcoin/bitcoin/blob/master/src/qt/guiutil.cpp#L695).

  There was also some related discussion in the `#bitcoin-builds` channel yesterday arvo.

ACKs for top commit:
  laanwj:
    ACK 7d7bf2f
  dongcarl:
    post-IRC-grilling-ACK 7d7bf2f

Tree-SHA512: 30b0ed75e3b4df2d3f94db2091b7982c1ea7be8fb3a2732d8efd1a53ef1e492d7265a47e90c38e92f66e638d10e9400a6ecb56e5093688bb26d1621645b453e8
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
27d82b6 gui: remove macOS start on login code (fanquake)

Pull request description:

  The macOS startup item code was disabled for builds targeting macOS >
  `10.11` in bitcoin#15208. Now that we require macOS `10.12` as a minimum (bitcoin#17550),
  we can remove the startup item code entirely. The API we were using, `LSSharedFileListItemCopyResolvedURL`, `LSSharedFileListCopySnapshot` etc,
  was removed in macOS `10.12` SDK.

ACKs for top commit:
  jonasschnelli:
    utACK 27d82b6
  jonasschnelli:
    Tested ACK 27d82b6 - successfully compiled on 10.15.1

Tree-SHA512: 7420757b91c7820e6a63280887155394547134a9cebcf3721af0284da23292627f94cd431241e033075b3fd86d79ace3ebf1b25d17763acbf71e07a742395409
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
… 10.12

f9f210d doc: fix GetTimeMicros() comment in random.cpp (fanquake)
a889711 rand: remove getentropy() fallback for macOS < 10.12 (fanquake)

Pull request description:

  We [no longer support macOS < 10.12](bitcoin#17550) (our binaries will not run), so remove the fallback for when `getentropy()` wasn't available. From the manpage:

  ```bash
  HISTORY
       The getentropy() function appeared in OSX 10.12
  ```

  Note that compiling on macOS you'll see a new unused function warning:
  ```bash
  random.cpp:256:13: warning: unused function 'GetDevURandom' [-Wunused-function]
  static void GetDevURandom(unsigned char *ent32)
              ^
  1 warning generated.
  ```

  This will likely be addressed as part of bitcoin#17563.

ACKs for top commit:
  vasild:
    ACK f9f210d (code review, not tested)
  elichai:
    utACK f9f210d
  practicalswift:
    ACK f9f210d -- patch looks correct
  laanwj:
    ACK f9f210d
  hebasto:
    ACK f9f210d, tested on macOS 10.13.6: compiled

Tree-SHA512: 6bd2a721f23605a8bca0b7b51f42d628ebf92a18e74eb43194331ba745ee449223aff84119892781c40b188c70b75417447f4e390e3d9ac549292de2b1e8b308
backpacker69 referenced this pull request in peercoin/peercoin Mar 28, 2021
The macOS startup item code was disabled for builds targeting macOS >
10.11 in #15208. Now that we require macOS 10.12 as a minimum, #17550,
we can remove the startup item code entirely, as the API we were using
was removed in macOS 10.12.
furszy added a commit to PIVX-Project/PIVX that referenced this pull request May 25, 2021
e1b89ac Fix QPainter non-determinism on macOS (Andrew Chow)
831c317 macOS deploy: use the new plistlib API (Jonas Schnelli)
5857aaf doc: Document ALLOW_HOST_PACKAGES dependency option (skmcontrib)
2329e08 build: Fix behavior when ALLOW_HOST_PACKAGES unset (Hennadii Stepanov)
1768870 depends: native_ds_store 1.3.0 (fanquake)
3f9f3e5 depends: pull upstream libdmg-hfsplus changes (fanquake)
f7606dc depends: latest config.guess & config.sub (fanquake)
cc3ae74 depends: bump native_cctools for fixed lto with external clang (Cory Fields)
b26c648 depends: enable lto support for Apple's ld64 (Cory Fields)
50933d7 depends: Add documentation for FORCE_USE_SYSTEM_CLANG make flag (Carl Dong)
ba3ddf2 depends: Reformat make options as definition list (Carl Dong)
3b855a7 depends: Add justifications for macOS clang flags (Carl Dong)
4104de0 depends: specify libc++ header location for darwin (Cory Fields)
cd4335f depends: force a new host id string if FORCE_USE_SYSTEM_CLANG is in use (Cory Fields)
d30e1af depends: Allow building with system clang (Carl Dong)
234828b depends: Decouple toolchain + binutils (Carl Dong)
1dd3a5a doc: explain why passing -mlinker-version is required (fanquake)
5cc0d0f darwin: pass mlinker-version so that clang enables new features (Cory Fields)
813a552 macos: Bump to xcode 11.3.1 and 10.15 SDK (Cory Fields)
ee7085f depends: bump MacOS toolchain (Cory Fields)
e5b092b contrib: macdeploy: Remove historical extraction notes (Carl Dong)
5893caf contrib: macdeploy: Use apple-sdk-tools instead of xar+pbzx (Carl Dong)
9f2d4ba native_cctools: Don't use libc++ from pinned clang (Carl Dong)
0c8d217 Adapt rest of tooling to new SDK naming scheme (Carl Dong)
bdacfa8 contrib: macdeploy: Correctly generate macOS SDK (Carl Dong)
f7eee2c Fix naming of macOS SDK and clarify version (Andrew Chow)
62f9e23 build: use macOS 10.14 SDK (fanquake)
bc2e1af depends: native_cctools 921, ld64 409.12, libtapi 1000.10.8 (fanquake)
a296d87 depends: clang 6.0.1 (fanquake)
8f6c475 build: Set minimum supported macOS to 10.12 (Fuzzbawls)

Pull request description:

  This backports the following upstream PRs to update the macOS cross-compiling tools:

  bitcoin#17550
  bitcoin#16392
  bitcoin#18589
  bitcoin#19240
  bitcoin#19407
  bitcoin#17919
  bitcoin#19530
  bitcoin#17057
  bitcoin#20333
  bitcoin#18051
  bitcoin#19124
  bitcoin#20298
  bitcoin#20447

  The tools being updated are

  ### Clang
  Upgraded from `3.7.1` to `8.0.0`

  ### cctools

  * cctools `877.8` -> `949.0.1`
  * LD64 `253.9` -> `530`
  * TAPI `1000.10.8`

  ### DSStore
  Upgraded from `1.1.2` to `1.3.0` (this removes the biplist dependency)

  This also effectively bumps our minimum supported macOS version to 10.12 (Sierra).

ACKs for top commit:
  furszy:
    tested ACK e1b89ac
  random-zebra:
    utACK e1b89ac

Tree-SHA512: f5cec8db57e07d8855070646b9e1400d48aac1d01e3c2c3b3e134665c6372d6535f3328888bb9a75087f7b3d5231ecb4b509723bfa51bd40770ffe2810c67f65
kwvg added a commit to kwvg/dash that referenced this pull request Jul 15, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Jul 20, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Jul 20, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Jul 20, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Aug 1, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Aug 24, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Aug 25, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Aug 26, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Aug 27, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Aug 30, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Aug 31, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants