Skip to content

Conversation

jonatack
Copy link
Member

@jonatack jonatack commented Nov 12, 2019

The fuzzing gitignores haven't been updated since a4153e2 in 2016 that added an initial simple fuzzing framework.

This commit:

  • removes src/test/test_bitcoin_fuzzy which is no longer used in favor of src/test/fuzz
  • ignores the src/test/fuzz directory, then un-ignores files in it with an extension, to de-clutter the git status from all the generated binary files.

Co-authored-by: Karl-Johan Alm karljohan-alm@garage.co.jp

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 12, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #16834 (Fetch Headers over DNS by TheBlueMatt)
  • #16762 (Rust-based Backup over-REST block downloader by TheBlueMatt)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@kallewoof
Copy link
Contributor

Concept ACK. The git status clutter is annoying.

@maflcko maflcko changed the title lib: update fuzz directory in .gitignore test: update fuzz directory in .gitignore Jan 3, 2020
The fuzzing gitignores haven't been updated since a4153e2
in 2016 that added an initial simple fuzzing framework.

This commit:

- removes `src/test/test_bitcoin_fuzzy` which is no longer
  used in favor of `src/test/fuzz`

- ignores the src/test/fuzz directory, then un-ignores any
  files in it with an extension

Co-authored-by: Karl-Johan Alm <karljohan-alm@garage.co.jp>
@jonatack jonatack force-pushed the update-fuzz-gitignore branch from ba76e3c to 77ef48d Compare January 3, 2020 13:29
@jonatack
Copy link
Member Author

jonatack commented Jan 3, 2020

@kallewoof LMK if the GitHub email isn't your current one in order to be credited properly; I found it in the git history.

@kallewoof
Copy link
Contributor

@kallewoof LMK if the GitHub email isn't your current one in order to be credited properly; I found it in the git history.

Looks good :)

@fanquake
Copy link
Member

fanquake commented Jan 4, 2020

@MarcoFalke or @practicalswift can either of you comment/ACK in regards to fuzzing ignoring completeness.

@maflcko
Copy link
Member

maflcko commented Jan 7, 2020

ACK 77ef48d

@practicalswift
Copy link
Contributor

ACK 77ef48d

@fanquake Sorry for replying late :)

fanquake added a commit that referenced this pull request Jan 7, 2020
77ef48d gitignore: ignore fuzz binaries, remove test_bitcoin_fuzzy (Jon Atack)

Pull request description:

  The fuzzing gitignores haven't been updated since a4153e2 in 2016 that added an initial simple fuzzing framework.

  This commit:
  - removes `src/test/test_bitcoin_fuzzy` which is no longer used in favor of `src/test/fuzz`
  - ignores the `src/test/fuzz` directory, then un-ignores files in it with an extension, to de-clutter the git status from all the generated binary files.

  Co-authored-by: Karl-Johan Alm <karljohan-alm@garage.co.jp>

ACKs for top commit:
  practicalswift:
    ACK 77ef48d
  MarcoFalke:
    ACK 77ef48d

Tree-SHA512: 1fef4fbe88ded1ecf039205ace0da2abbaabcaae6ac6674eb29f84ae2f2fc560c1341e75e664cc2e243aca5767253756dba73b90ef32c7dd07c7c638abe6daf0
@fanquake fanquake merged commit 77ef48d into bitcoin:master Jan 7, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 8, 2020
77ef48d gitignore: ignore fuzz binaries, remove test_bitcoin_fuzzy (Jon Atack)

Pull request description:

  The fuzzing gitignores haven't been updated since a4153e2 in 2016 that added an initial simple fuzzing framework.

  This commit:
  - removes `src/test/test_bitcoin_fuzzy` which is no longer used in favor of `src/test/fuzz`
  - ignores the `src/test/fuzz` directory, then un-ignores files in it with an extension, to de-clutter the git status from all the generated binary files.

  Co-authored-by: Karl-Johan Alm <karljohan-alm@garage.co.jp>

ACKs for top commit:
  practicalswift:
    ACK 77ef48d
  MarcoFalke:
    ACK 77ef48d

Tree-SHA512: 1fef4fbe88ded1ecf039205ace0da2abbaabcaae6ac6674eb29f84ae2f2fc560c1341e75e664cc2e243aca5767253756dba73b90ef32c7dd07c7c638abe6daf0
@jonatack jonatack deleted the update-fuzz-gitignore branch July 27, 2020 09:44
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
77ef48d gitignore: ignore fuzz binaries, remove test_bitcoin_fuzzy (Jon Atack)

Pull request description:

  The fuzzing gitignores haven't been updated since a4153e2 in 2016 that added an initial simple fuzzing framework.

  This commit:
  - removes `src/test/test_bitcoin_fuzzy` which is no longer used in favor of `src/test/fuzz`
  - ignores the `src/test/fuzz` directory, then un-ignores files in it with an extension, to de-clutter the git status from all the generated binary files.

  Co-authored-by: Karl-Johan Alm <karljohan-alm@garage.co.jp>

ACKs for top commit:
  practicalswift:
    ACK 77ef48d
  MarcoFalke:
    ACK 77ef48d

Tree-SHA512: 1fef4fbe88ded1ecf039205ace0da2abbaabcaae6ac6674eb29f84ae2f2fc560c1341e75e664cc2e243aca5767253756dba73b90ef32c7dd07c7c638abe6daf0
kwvg added a commit to kwvg/dash that referenced this pull request Aug 2, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Aug 5, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Aug 5, 2021
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Aug 6, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Aug 8, 2021
kwvg added a commit to kwvg/dash that referenced this pull request Aug 11, 2021
5tefan pushed a commit to 5tefan/dash that referenced this pull request Aug 12, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants