Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Nov 8, 2019

Backports #17368 to the 0.19 branch.

@maflcko
Copy link
Member

maflcko commented Nov 8, 2019

I wouldn't mind putting this in 0.19.1. It is not really a bug, only the output is confusing to read.

@fanquake fanquake modified the milestones: 0.19.0, 0.19.1 Nov 8, 2019
@laanwj
Copy link
Member

laanwj commented Nov 8, 2019

I don't think this is risky, or impactful, enough to hold up -final at this stage, I also don't think we should merge anything into 0,19.0 without a new RC. I'd rather keep it for 0.19.1.

@laanwj
Copy link
Member

laanwj commented Nov 10, 2019

ACK 2d0b3c0, this is a clean backport of #17368 / 3d05d33 and contains the necessary metadata. Merging for 0.19.1.

laanwj added a commit that referenced this pull request Nov 10, 2019
…allet

2d0b3c0 cli: fix -getinfo output when compiled with no wallet (fanquake)

Pull request description:

  Backports #17368 to the 0.19 branch.

ACKs for top commit:
  laanwj:
    ACK 2d0b3c0, this is a clean backport of #17368 / 3d05d33 and contains the necessary metadata.

Tree-SHA512: 7773a1038df385ca3114454800142fb3c44b06894175641e596a17214f8e83b326ea049d8908d6ff7c6e56b07e671216196d2bb964401a6b5e0ec1e632fc8b89
@laanwj laanwj merged commit 2d0b3c0 into bitcoin:0.19 Nov 10, 2019
@fanquake fanquake deleted the backport_17368_019 branch November 10, 2019 14:58
MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Nov 19, 2019
@fanquake fanquake removed this from the 0.19.1 milestone Nov 19, 2019
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants