Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Nov 4, 2019

Follow-up to #17165

@fanquake fanquake added the Docs label Nov 4, 2019
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK with a couple nits below.

@cvengler
Copy link
Contributor

cvengler commented Nov 5, 2019

ACK

@jonatack
Copy link
Member

jonatack commented Nov 5, 2019

ACK fa7f5a4. Verified markdown view at https://github.com/MarcoFalke/bitcoin-core/blob/1911-docBips/doc/bips.md and the urls in the links. Some of the PRs are indicated with # and some without, but this is the case over the whole document.

@laanwj
Copy link
Member

laanwj commented Nov 5, 2019

ACK fa7f5a4

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa7f5a4

fanquake added a commit that referenced this pull request Nov 6, 2019
fa7f5a4 doc: Update doc/bips.md with recent changes in master (MarcoFalke)

Pull request description:

  Follow-up to #17165

ACKs for top commit:
  jonatack:
    ACK fa7f5a4. Verified markdown view at https://github.com/MarcoFalke/bitcoin-core/blob/1911-docBips/doc/bips.md and the urls in the links. Some of the PRs are indicated with # and some without, but this is the case over the whole document.
  laanwj:
    ACK fa7f5a4
  fanquake:
    ACK fa7f5a4

Tree-SHA512: 31782b5f1f2f10b1189f05f010f908c183dbe723477ca1c46ad1d3bee5ea483335847008a7fe48d72373ccd39b84e0b950d0d1b23e457cb70f34210c5f2dc6aa
@fanquake fanquake merged commit fa7f5a4 into bitcoin:master Nov 6, 2019
@maflcko maflcko deleted the 1911-docBips branch November 6, 2019 12:21
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 7, 2019
…aster

fa7f5a4 doc: Update doc/bips.md with recent changes in master (MarcoFalke)

Pull request description:

  Follow-up to bitcoin#17165

ACKs for top commit:
  jonatack:
    ACK fa7f5a4. Verified markdown view at https://github.com/MarcoFalke/bitcoin-core/blob/1911-docBips/doc/bips.md and the urls in the links. Some of the PRs are indicated with # and some without, but this is the case over the whole document.
  laanwj:
    ACK fa7f5a4
  fanquake:
    ACK fa7f5a4

Tree-SHA512: 31782b5f1f2f10b1189f05f010f908c183dbe723477ca1c46ad1d3bee5ea483335847008a7fe48d72373ccd39b84e0b950d0d1b23e457cb70f34210c5f2dc6aa
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
…aster

fa7f5a4 doc: Update doc/bips.md with recent changes in master (MarcoFalke)

Pull request description:

  Follow-up to bitcoin#17165

ACKs for top commit:
  jonatack:
    ACK fa7f5a4. Verified markdown view at https://github.com/MarcoFalke/bitcoin-core/blob/1911-docBips/doc/bips.md and the urls in the links. Some of the PRs are indicated with # and some without, but this is the case over the whole document.
  laanwj:
    ACK fa7f5a4
  fanquake:
    ACK fa7f5a4

Tree-SHA512: 31782b5f1f2f10b1189f05f010f908c183dbe723477ca1c46ad1d3bee5ea483335847008a7fe48d72373ccd39b84e0b950d0d1b23e457cb70f34210c5f2dc6aa
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants