script: Lint Gitian descriptors with ShellCheck #17361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
reviewed
Nov 3, 2019
test/lint/print-gitian-script.py
Outdated
| @@ -0,0 +1,22 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Is this really necessary? Couldn't use some YAML processor like yq?
There was a problem hiding this comment.
Couldn't use some YAML processor like
yq?
Done.
TIL, thank you ;)
d82b77a to
7e8b40e
Compare
|
Concept ACK: good idea! Could perhaps check for |
7e8b40e to
93faddf
Compare
Done. Thank you. |
dongcarl
suggested changes
Nov 4, 2019
93faddf to
a953da7
Compare
|
@dongcarl |
dongcarl
suggested changes
Nov 4, 2019
| do | ||
| echo | ||
| echo "$descriptor" | ||
| SCRIPT=$'#!/bin/bash\n'$(yq -r .script "$descriptor") |
There was a problem hiding this comment.
Suggested change
| SCRIPT=$'#!/bin/bash\n'$(yq -r .script "$descriptor") | |
| SCRIPT=$'#!/usr/bin/env bash\n'$(yq -r .script "$descriptor") |
There was a problem hiding this comment.
It just mimics the way gitian-builder/bin/gbuild makes shell script:
File.open("var/build-script", "w") do |script|
script.puts "#!/bin/bash"
There was a problem hiding this comment.
Ah! Makes sense to do it this way, could you add a comment?
a953da7 to
53ff028
Compare
Done. |
Gitian builds
|
Gitian builds
|
|
Concept ACK |
It already lacks |
|
@hebasto let's see if that one is merged first so you can update the doc here. |
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 10, 2020
gitian: fixed SC2001 regex bitcoin#17680
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
17f81e9 script: Enable SC2001 rule for Gitian scripts (Hennadii Stepanov) 61bb21b script: Enable SC2155 rule for Gitian scripts (Hennadii Stepanov) 577682d script: Enable SC2006 rule for Gitian scripts (Hennadii Stepanov) 14aded4 script: Lint Gitian descriptors with ShellCheck (Hennadii Stepanov) Pull request description: This PR extracts shell scripts from Gitian descriptors (`contrib/gitian-descriptors/`) and checks for ShellCheck warnings as any other one. Some non-controversial warnings are fixed. ACKs for top commit: practicalswift: ACK 17f81e9 -- diff looks correct Tree-SHA512: bdfa3d35bbb65ff634c90835d75c3df63e958b558599771d21366724f5cf64da83a68957d926e926a99c3704b9529e96a17697dc8d9ff3adf7154d9cb1999a8d
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 15, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 15, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 20, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 20, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 20, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 20, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 1, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 24, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 24, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 25, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 25, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 26, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 26, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 26, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 27, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 30, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Sep 1, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Sep 1, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Sep 1, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Sep 1, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Sep 2, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Sep 3, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Sep 3, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Sep 3, 2021
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 17, 2021
c966ff1 gitian: fixed SC2001 regex (willyk) Pull request description: Currently the gitian-win-signer.yml produces OUTFILE names without `-unsigned` stripped out This is due to regex having an`%` in front of it ``` $ INFILE="bitcoin-0.19.0-win64-setup-unsigned.exe" $ echo "${INFILE/%-unsigned}" bitcoin-0.19.0-win64-setup-unsigned.exe $ echo "${INFILE/-unsigned}" bitcoin-0.19.0-win64-setup.exe ``` Fixes bitcoin#17361 ACKs for top commit: laanwj: ACK c966ff1 hebasto: ACK c966ff1 Tree-SHA512: 954547f9dfa4cab4def5f284d4837c21f0e6fed7454a04e83e6b1b7d3fd3f9661ea657047f0d8162f6591909d32ef2f72e801b2f3a44cbb1131ac344cb913a69
thelazier
pushed a commit
to thelazier/dash
that referenced
this pull request
Sep 25, 2021
c966ff1 gitian: fixed SC2001 regex (willyk) Pull request description: Currently the gitian-win-signer.yml produces OUTFILE names without `-unsigned` stripped out This is due to regex having an`%` in front of it ``` $ INFILE="bitcoin-0.19.0-win64-setup-unsigned.exe" $ echo "${INFILE/%-unsigned}" bitcoin-0.19.0-win64-setup-unsigned.exe $ echo "${INFILE/-unsigned}" bitcoin-0.19.0-win64-setup.exe ``` Fixes bitcoin#17361 ACKs for top commit: laanwj: ACK c966ff1 hebasto: ACK c966ff1 Tree-SHA512: 954547f9dfa4cab4def5f284d4837c21f0e6fed7454a04e83e6b1b7d3fd3f9661ea657047f0d8162f6591909d32ef2f72e801b2f3a44cbb1131ac344cb913a69
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts shell scripts from Gitian descriptors (
contrib/gitian-descriptors/) and checks for ShellCheck warnings as any other one.Some non-controversial warnings are fixed.