Skip to content

depends: update README.md with working Android targets and API levels #17365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2019
Merged

depends: update README.md with working Android targets and API levels #17365

merged 2 commits into from
Nov 5, 2019

Conversation

icota
Copy link
Contributor

@icota icota commented Nov 4, 2019

Per @Sjors comments in #16110 (review)

@fanquake fanquake added the Docs label Nov 4, 2019
laanwj
laanwj reviewed Nov 4, 2019
View reviewed changes
@cvengler
Copy link
Contributor

cvengler commented Nov 5, 2019

Wouldn't it be better to create a file for this in the doc folder and link to it in the README?

@icota
Copy link
Contributor Author

icota commented Nov 5, 2019

I don't think so. This is specific to depends and other platform cross-compilation instructions are in the same file.

@Sjors
Copy link
Member

Sjors commented Nov 5, 2019

It's fine. It's not that long yet, and if you search the repo for Android you'll find it :-)

ACK 3fe1aba

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Nov 5, 2019
Merge bitcoin#17365: depends: update README.md with working Android t…
e204dc1 
…argets and API levels

3fe1aba depends: move README.md Android instructions to a separate section (Igor Cota)
aa9b84a depends: update README.md with working Android targets and API levels (Igor Cota)

Pull request description:

  Per @Sjors comments in bitcoin#16110 (review)

ACKs for top commit:
  Sjors:
    ACK 3fe1aba

Tree-SHA512: 7a2e676070d51c7a4291b0d4b638f52321c08cc6ebe2bd2c02ba62f6cc3dd8a73227df4693c6ce9201863eb0bf26e0133805347b9016cb0f9a389a49cc9492aa
@maflcko maflcko merged commit 3fe1aba into bitcoin:master Nov 5, 2019
@cryptozeny
Copy link

thanks alot!

@icota icota deleted the update-android-depends-doc branch November 5, 2019 14:54
@Sjors
Copy link
Member

Sjors commented Nov 5, 2019

Future note: please don't tag Github usernames in commit messages; it results in spam when altcoins backport it. My own fault for missing that :-)

@icota
Copy link
Contributor Author

icota commented Nov 6, 2019

You didn't miss anything. 😄

I read CONTRIBUTING like a good boy so I didn't include it in any commit messages. Merge commit picked it up from the first comment though. Should we avoid that?

@Sjors
Copy link
Member

Sjors commented Nov 6, 2019

No, I think the merge script should take care of that. I thought it stripped the @. @MarcoFalke?

@laanwj
Copy link
Member

laanwj commented Nov 6, 2019 •
edited
Loading

No, it doesn't strip them—as this might corrupt, say, mail addresses, github's parsing is pretty ambigious and heuristic-based and replicating this is non-trivial!
it warns when there are any before merging, though

@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laanwj laanwj laanwj left review comments

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@icota @cvengler @Sjors @cryptozeny @laanwj @fanquake @maflcko