Skip to content

cli: Add "headers" and "verificationprogress" to -getinfo #17302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2019
Merged

cli: Add "headers" and "verificationprogress" to -getinfo #17302

merged 1 commit into from
Oct 30, 2019

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Oct 29, 2019

These values are useful to know the current progress of initial sync, or of catching up, which is arguably the use of a quick -getinfo command.

hebasto
hebasto reviewed Oct 29, 2019
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK.
There is a typo in commit message in "verifcationprogress".

@laanwj laanwj changed the title cli: Add "headers" and "verifcationprogress" to -getinfo cli: Add "headers" and "verificationprogress" to -getinfo Oct 29, 2019
@laanwj
cli: Add "headers" and "verificationprogress" to -getinfo
3187934 
These value are useful to know the current progress of
initial sync, or of catching up.
@laanwj
Copy link
Member Author

laanwj commented Oct 29, 2019

Thanks, fixed

@maflcko
Copy link
Member

maflcko commented Oct 30, 2019

unsigned ACK 3187934

@jonasschnelli
Copy link
Contributor

utACK 3187934

@laanwj laanwj mentioned this pull request Oct 30, 2019
Closed
jonatack
jonatack reviewed Oct 30, 2019
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 3187934 on Debian 4.19.37-5+deb10u2 (2019-08-08) x86_64 GNU/Linux

$ src/bitcoin-cli -getinfo
{
  "version": 199900,
  "protocolversion": 70015,
  "blocks": 601626,
  "headers": 601626,
  "verificationprogress": 0.9999914194982424,
  "timeoffset": -1,
  "connections": 10,
  "proxy": "",
  "difficulty": 13691480038694.45,
  "chain": "main",
  "walletversion": 169900,
  "balance": 0.00649423,
  "keypoololdest": 1551909091,
  "keypoolsize": 1000,
  "paytxfee": 0.00000000,
  "relayfee": 0.00001000,
  "warnings": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"
}

@hebasto
Copy link
Member

hebasto commented Oct 30, 2019

Tested 3187934 on Linux Mint 19.2:

$ src/bitcoin-cli -getinfo
{
  "version": 199900,
  "protocolversion": 70015,
  "blocks": 0,
  "headers": 404000,
  "verificationprogress": 2.127373228171698e-09,
  "timeoffset": 0,
  "connections": 1,
  "proxy": "",
  "difficulty": 1,
  "chain": "main",
  "walletversion": 169900,
  "balance": 0.00000000,
  "keypoololdest": 1572432296,
  "keypoolsize": 1000,
  "paytxfee": 0.00000000,
  "relayfee": 0.00001000,
  "warnings": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"
}

$ src/bitcoin-cli -getinfo
{
  "version": 199900,
  "protocolversion": 70015,
  "blocks": 497,
  "headers": 601628,
  "verificationprogress": 1.076450663093587e-06,
  "timeoffset": 0,
  "connections": 4,
  "proxy": "",
  "difficulty": 1,
  "chain": "main",
  "walletversion": 169900,
  "balance": 0.00000000,
  "keypoololdest": 1572432296,
  "keypoolsize": 1000,
  "paytxfee": 0.00000000,
  "relayfee": 0.00001000,
  "warnings": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"
}

Exponential formatting of "verificationprogress" seems a bit awkward.

@laanwj
Copy link
Member Author

laanwj commented Oct 30, 2019

Exponential formatting of "verificationprogress" seems a bit awkward.

Yes. But out of scope of this issue as I have no control over formatting as long as we're using JSON here. A progress bar would be nicer I guess. See also #17314.

laanwj added a commit that referenced this pull request Oct 30, 2019
@laanwj
Merge #17302: cli: Add "headers" and "verificationprogress" to -getinfo
edd9d07 
3187934 cli: Add "headers" and "verificationprogress" to -getinfo (Wladimir J. van der Laan)

Pull request description:

  These values are useful to know the current progress of initial sync, or of catching up, which is arguably the use of a quick `-getinfo` command.

ACKs for top commit:
  MarcoFalke:
    unsigned ACK 3187934
  jonasschnelli:
    utACK 3187934
  jonatack:
    Tested ACK 3187934 on Debian 4.19.37-5+deb10u2 (2019-08-08) x86_64 GNU/Linux

Tree-SHA512: 185180ab426b4db5d99eb208ee88d1606f585361875ba3a92b6c28a74fe181d72ed710c8859b969ba49b1ca7d2385695932b79ff621c7a2a7cedd0df717a99ed
@laanwj laanwj merged commit 3187934 into bitcoin:master Oct 30, 2019
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
alejagapatrick
alejagapatrick reviewed Apr 9, 2020
View reviewed changes
Copy link

@alejagapatrick alejagapatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/bitcoin-cli.cpp

@bitcoin bitcoin locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto left review comments

+2 more reviewers

@jonatack jonatack jonatack left review comments

@alejagapatrick alejagapatrick alejagapatrick left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Utils/log/libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@laanwj @maflcko @jonasschnelli @hebasto @jonatack @alejagapatrick