Skip to content

Conversation

adamjonas
Copy link
Member

Resurrecting #14125 with updates based on comments of closed PR

@fanquake fanquake added the Tests label Oct 21, 2019
@laanwj
Copy link
Member

laanwj commented Oct 23, 2019

ACK 4896bac

@dongcarl
Copy link
Contributor

ACK 4896bac
Skimmed code, ran tests.

maflcko pushed a commit that referenced this pull request Oct 23, 2019
4896bac Add testcase to simulate bitcoin schema in leveldb (MapleLaker)

Pull request description:

  Resurrecting #14125 with updates based on comments of closed PR

ACKs for top commit:
  laanwj:
    ACK 4896bac
  dongcarl:
    ACK 4896bac

Tree-SHA512: 3290ea7e1e998901d5ee8921d1d76cec399cae30ac1911a45b86826afed47cee1acf92bd6438f1fa11ed785a3b17abdcb1c169bc0419945eda9fe4c089d0b6eb
@maflcko maflcko merged commit 4896bac into bitcoin:master Oct 23, 2019
@adamjonas adamjonas deleted the dbwrapper_basic_data branch October 25, 2019 16:03
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 30, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#17206 | PR17206]]

Test Plan: `ninja && ninja check`

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8190
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request Apr 23, 2021
bc3d3fa Add testcase to simulate bitcoin schema in leveldb (MapleLaker)
4f15155 Verify DBWrapper iterators are taking snapshots (Matt Corallo)
36b407e test: Replace remaining sprintf with snprintf (Wladimir J. van der Laan)
e8cb38a Add test for dbwrapper iterators with same-prefix keys. (Matt Corallo)
4a4ddb8 test: Add more thorough test for dbwrapper iterators I made a silly mistake in a database wrapper where keys were sorted by char instead of uint8_t. As x86 char is signed the sorting for the block index database was messed up, resulting in a segfault due to missing records. (Wladimir J. van der Laan)
109446f chain: Add assertion in case of missing records in index db (Wladimir J. van der Laan)

Pull request description:

  Back ported the following PRs from upstream (adaptations were needed because we aren't obfuscating the db):

  * bitcoin#7992.
  * bitcoin#9867.
  * bitcoin#11422.
  * bitcoin#17206

ACKs for top commit:
  random-zebra:
    Nice! ACK bc3d3fa

Tree-SHA512: ebd811d7ee0d970247ceec2624e524df7611274f36ef7c0252712ebf247828ee091dcc6872585271fac3d7846127a997a856d7cd72eb20425e06213207ff1c7a
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
… leveldb

4896bac Add testcase to simulate bitcoin schema in leveldb (MapleLaker)

Pull request description:

  Resurrecting bitcoin#14125 with updates based on comments of closed PR

ACKs for top commit:
  laanwj:
    ACK 4896bac
  dongcarl:
    ACK 4896bac

Tree-SHA512: 3290ea7e1e998901d5ee8921d1d76cec399cae30ac1911a45b86826afed47cee1acf92bd6438f1fa11ed785a3b17abdcb1c169bc0419945eda9fe4c089d0b6eb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
… leveldb

4896bac Add testcase to simulate bitcoin schema in leveldb (MapleLaker)

Pull request description:

  Resurrecting bitcoin#14125 with updates based on comments of closed PR

ACKs for top commit:
  laanwj:
    ACK 4896bac
  dongcarl:
    ACK 4896bac

Tree-SHA512: 3290ea7e1e998901d5ee8921d1d76cec399cae30ac1911a45b86826afed47cee1acf92bd6438f1fa11ed785a3b17abdcb1c169bc0419945eda9fe4c089d0b6eb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
… leveldb

4896bac Add testcase to simulate bitcoin schema in leveldb (MapleLaker)

Pull request description:

  Resurrecting bitcoin#14125 with updates based on comments of closed PR

ACKs for top commit:
  laanwj:
    ACK 4896bac
  dongcarl:
    ACK 4896bac

Tree-SHA512: 3290ea7e1e998901d5ee8921d1d76cec399cae30ac1911a45b86826afed47cee1acf92bd6438f1fa11ed785a3b17abdcb1c169bc0419945eda9fe4c089d0b6eb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
… leveldb

4896bac Add testcase to simulate bitcoin schema in leveldb (MapleLaker)

Pull request description:

  Resurrecting bitcoin#14125 with updates based on comments of closed PR

ACKs for top commit:
  laanwj:
    ACK 4896bac
  dongcarl:
    ACK 4896bac

Tree-SHA512: 3290ea7e1e998901d5ee8921d1d76cec399cae30ac1911a45b86826afed47cee1acf92bd6438f1fa11ed785a3b17abdcb1c169bc0419945eda9fe4c089d0b6eb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
… leveldb

4896bac Add testcase to simulate bitcoin schema in leveldb (MapleLaker)

Pull request description:

  Resurrecting bitcoin#14125 with updates based on comments of closed PR

ACKs for top commit:
  laanwj:
    ACK 4896bac
  dongcarl:
    ACK 4896bac

Tree-SHA512: 3290ea7e1e998901d5ee8921d1d76cec399cae30ac1911a45b86826afed47cee1acf92bd6438f1fa11ed785a3b17abdcb1c169bc0419945eda9fe4c089d0b6eb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 12, 2021
… leveldb

4896bac Add testcase to simulate bitcoin schema in leveldb (MapleLaker)

Pull request description:

  Resurrecting bitcoin#14125 with updates based on comments of closed PR

ACKs for top commit:
  laanwj:
    ACK 4896bac
  dongcarl:
    ACK 4896bac

Tree-SHA512: 3290ea7e1e998901d5ee8921d1d76cec399cae30ac1911a45b86826afed47cee1acf92bd6438f1fa11ed785a3b17abdcb1c169bc0419945eda9fe4c089d0b6eb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 13, 2021
… leveldb

4896bac Add testcase to simulate bitcoin schema in leveldb (MapleLaker)

Pull request description:

  Resurrecting bitcoin#14125 with updates based on comments of closed PR

ACKs for top commit:
  laanwj:
    ACK 4896bac
  dongcarl:
    ACK 4896bac

Tree-SHA512: 3290ea7e1e998901d5ee8921d1d76cec399cae30ac1911a45b86826afed47cee1acf92bd6438f1fa11ed785a3b17abdcb1c169bc0419945eda9fe4c089d0b6eb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 13, 2021
… leveldb

4896bac Add testcase to simulate bitcoin schema in leveldb (MapleLaker)

Pull request description:

  Resurrecting bitcoin#14125 with updates based on comments of closed PR

ACKs for top commit:
  laanwj:
    ACK 4896bac
  dongcarl:
    ACK 4896bac

Tree-SHA512: 3290ea7e1e998901d5ee8921d1d76cec399cae30ac1911a45b86826afed47cee1acf92bd6438f1fa11ed785a3b17abdcb1c169bc0419945eda9fe4c089d0b6eb
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants