util: Filter out macOS process serial number #17184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fanquake Could "Needs gitian build" label be assigned to this PR? |
|
Concept ACK. |
|
Concept ACK, code LGTM. |
All the links to the macOS docs I found are dead, unfortunately (( |
|
ACK b5f0be3 I agree it's a hack, but it's also harmless, and apparently the same Qt used to do, when we still passed the command line arguments to it. |
|
@jonasschnelli the Qt filtering was happening here. #ifdef Q_OS_MAC
} else if (strncmp(arg, "-psn_", 5) == 0) {
// eat "-psn_xxxx" on Mac, which is passed when starting an app from Finder.Documentation on the |
|
unsigned ACK b5f0be3 |
|
ACK b5f0be3. |
fanquake
added a commit
that referenced
this pull request
Oct 18, 2019
b5f0be3 util: Filter out macOS process serial number (Hennadii Stepanov) Pull request description: Fix #17179 ACKs for top commit: laanwj: ACK b5f0be3 MarcoFalke: unsigned ACK b5f0be3 promag: ACK b5f0be3. fanquake: ACK b5f0be3 - Tested that this fixes #17179. Tree-SHA512: 84ce859e53ebc7ad2d0a45e954243ef6efee640f1e0212322f68a317e4361a216ecb4b5a3a410ab31613adc285c8d3840fbf41fa9da9019be3d734db6b9427cd
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Oct 19, 2019
Github-Pull: bitcoin#17184 Rebased-From: b5f0be3
Merged
laanwj
added a commit
that referenced
this pull request
Oct 21, 2019
334e27e util: Filter out macOS process serial number (Hennadii Stepanov) e1bacb5 rpc: fix -rpcclienttimeout 0 option (Fabian Jahr) 6a45766 doc: update bips.md with buried BIP9 deployments (MarcoFalke) dc0fe7a util: Filter control characters out of log messages (Wladimir J. van der Laan) ba46f39 init: Change fallback locale to C.UTF-8 (Wladimir J. van der Laan) Pull request description: Backports the following PRs to the `0.19.0` [branch](https://github.com/bitcoin/bitcoin/tree/0.19): * #17184 - util: Filter out macOS process serial number * #17131 - rpc: fix -rpcclienttimeout 0 option * #17111 - doc: update bips.md with buried BIP9 deployments * #17095 - util: Filter control characters out of log messages * #17085 - init: Change fallback locale to C.UTF-8 ACKs for top commit: laanwj: ACK 334e27e Tree-SHA512: 436064c00f98bae8475d0e46ab104df6fc9bdae4927dcdd5cffa4242704256c749352e9cabb23cf806911b1c303ddcb0208a42d540412e98da2513176e5e1023
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Nov 17, 2019
Github-Pull: bitcoin#17184 Rebased-From: b5f0be3
fxtc
pushed a commit
to fxtc/fxtc
that referenced
this pull request
Nov 25, 2019
Github-Pull: bitcoin#17184 Rebased-From: b5f0be3
fxtc
pushed a commit
to fxtc/fxtc
that referenced
this pull request
Nov 25, 2019
Github-Pull: bitcoin#17184 Rebased-From: b5f0be3
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 15, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 15, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 20, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 20, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 20, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 20, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 1, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Aug 24, 2021
Summary: This is a backport of [[bitcoin/bitcoin#17184 | core#17184]] Test Plan: I don't have a MacOS to test this. This should be trivial enough a change to simply check that it doesn't break regular CI builds and a standard local build. `ninja all check-all` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9901
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 24, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 24, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 25, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 26, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 26, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 27, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 30, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 31, 2021
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Dec 9, 2021
334e27e util: Filter out macOS process serial number (Hennadii Stepanov) e1bacb5 rpc: fix -rpcclienttimeout 0 option (Fabian Jahr) 6a45766 doc: update bips.md with buried BIP9 deployments (MarcoFalke) dc0fe7a util: Filter control characters out of log messages (Wladimir J. van der Laan) ba46f39 init: Change fallback locale to C.UTF-8 (Wladimir J. van der Laan) Pull request description: Backports the following PRs to the `0.19.0` [branch](https://github.com/bitcoin/bitcoin/tree/0.19): * bitcoin#17184 - util: Filter out macOS process serial number * bitcoin#17131 - rpc: fix -rpcclienttimeout 0 option * bitcoin#17111 - doc: update bips.md with buried BIP9 deployments * bitcoin#17095 - util: Filter control characters out of log messages * bitcoin#17085 - init: Change fallback locale to C.UTF-8 ACKs for top commit: laanwj: ACK 334e27e Tree-SHA512: 436064c00f98bae8475d0e46ab104df6fc9bdae4927dcdd5cffa4242704256c749352e9cabb23cf806911b1c303ddcb0208a42d540412e98da2513176e5e1023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17179