Skip to content

build: Add variable printing target to Makefiles #17087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2019
Merged

build: Add variable printing target to Makefiles #17087

merged 1 commit into from
Oct 9, 2019

Conversation

dongcarl
Copy link
Contributor

@dongcarl dongcarl commented Oct 9, 2019 

I kept finding myself needing these to debug our build system, since
they are innocuous and are very helpful they probably belong in the
codebase.

Source: John Graham-Cumming
https://www.cmcrossroads.com/article/printing-value-makefile-variable

@dongcarl
build: Add variable printing target to Makefiles
181989f 
I kept finding myself needing these to debug our build system, since
they are innocuous and are very helpful they probably belong in the
codebase.

Source: John Graham-Cumming
https://www.cmcrossroads.com/article/printing-value-makefile-variable
@hebasto
Copy link
Member

hebasto commented Oct 9, 2019

The whole OP seems like a block of code ;)

@dongcarl
Copy link
Contributor Author

dongcarl commented Oct 9, 2019

The whole OP seems like a block of code ;)

How else would I get people to recognize that I follow line length limits in my commit messages! 😁

@maflcko
Copy link
Member

maflcko commented Oct 9, 2019

I read those as a quote and it takes me a minute to figure out who is meant with I

@maflcko
Copy link
Member

maflcko commented Oct 9, 2019

ACK 181989f

$ git checkout 181989f6c9427fc266dbdcc84cb60ac03e67cdb2~1 && make print-top_srcdir
HEAD is now at 1c11e53bb6 Merge #17041: ci: Run tests on arm
make: *** No rule to make target 'print-top_srcdir'.  Stop.

$ git checkout 181989f6c9427fc266dbdcc84cb60ac03e67cdb2~0 && make print-top_srcdir
Previous HEAD position was 1c11e53bb6 Merge #17041: ci: Run tests on arm
HEAD is now at 181989f6c9 build: Add variable printing target to Makefiles
 cd . && /bin/sh /home/marco/workspace/btc_bitcoin_core/build-aux/missing automake-1.16 --foreign Makefile
 cd . && /bin/sh ./config.status Makefile 
config.status: creating Makefile
top_srcdir = .
Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK 181989f6c9427fc266dbdcc84cb60ac03e67cdb2

$ git checkout 181989f~1 && make print-top_srcdir
HEAD is now at 1c11e53 Merge #17041: ci: Run tests on arm
make: *** No rule to make target 'print-top_srcdir'. Stop.

$ git checkout 181989f~0 && make print-top_srcdir
Previous HEAD position was 1c11e53 Merge #17041: ci: Run tests on arm
HEAD is now at 181989f build: Add variable printing target to Makefiles
cd . && /bin/sh /home/marco/workspace/btc_bitcoin_core/build-aux/missing automake-1.16 --foreign Makefile
cd . && /bin/sh ./config.status Makefile
config.status: creating Makefile
top_srcdir = .

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUjbZAv9GLi1F7QT0omMC06pb7F8RfmSuEWrQVpv3wGTJe4HrxDQlI+chsVSLLWO
kBGDWRD9VywD+7b4R6SCHT/MgJMsWZlI66X0aTa2G4Wjf003jND4yJlQ+x2CVHCW
jRf05y5h+v272JZKvNu50kBSwMaBjqkkvswCn/Wc7RX1iIkqdXsy13Zx/0VITlPM
Eb+XbxHX/y5Aq0fDMWdwEfpqypRIe6N07PtOHxBqomC1LQaMLwCSzW43aahtxKwu
4kTOz3C4iG2a1zi21YCSQpqcO/BVjlkjg1koZIvP2JAeFktH4bWhWo5PWmXGks5q
Fghsnpl0emptAqKsdDVEonHXqkeRHL4Dxv02IEfT7a5aTa3ojaQfRliMOrf2Ezhc
4WPI8gqLY7R5vA+EGUsnTH2qEB83YiKt0j8515vgVpcWYTa1X/sOMSD2hZjFhFqb
Eldvoe4c9SY8jviGh5//RagOjZzqME2VQZzphJ2lF0sswV0R8CUXX6o3FUcCK33n
izMlpSrD
=U+Sb
-----END PGP SIGNATURE-----

Timestamp of file with hash ceb9bcc607d08509cccb7193e0e0e4f3df49f218ec4d143d4f5fd1bc4b08f8a1 -

@promag
Copy link
Contributor

promag commented Oct 9, 2019

ACK, nice one!

fanquake
fanquake approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 181989f - concise amount of useful code. Tested on macOS. Did not visit the link.

$ make print-BITCOIND_BIN
BITCOIND_BIN = ./src/bitcoind
$ make -C depends/ print-SOURCES_PATH
SOURCES_PATH = /Users/michael/github/bitcoin/depends/sources

fanquake added a commit that referenced this pull request Oct 9, 2019
@fanquake
Merge #17087: build: Add variable printing target to Makefiles
bc7e721 
181989f build: Add variable printing target to Makefiles (Carl Dong)

Pull request description:

  ```
  I kept finding myself needing these to debug our build system, since
  they are innocuous and are very helpful they probably belong in the
  codebase.

  Source: John Graham-Cumming
  https://www.cmcrossroads.com/article/printing-value-makefile-variable
  ```

ACKs for top commit:
  MarcoFalke:
    ACK 181989f
  fanquake:
    ACK 181989f - concise amount of useful code. Tested on macOS. Did not visit the link.

Tree-SHA512: 2139621e68a499c7347663ca9dc04e166ea6280e05986c27858df0156016ef2f9461262464d70c601419384f43a4ae3bcc67dfc0a05dbeef64f08386ab429cd8
@fanquake fanquake merged commit 181989f into bitcoin:master Oct 9, 2019
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Apr 3, 2020
@dongcarl @Fabcien
build: Add variable printing target to Makefiles
03a481b 
Summary:
```
I kept finding myself needing these to debug our build system, since
they are innocuous and are very helpful they probably belong in the
codebase.
```

Backport of core [[bitcoin/bitcoin#17087 | PR17087]].

Can be useful for the depends system.

Test Plan:
  cd depends
  make print-build_arch

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5652
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Apr 6, 2020
@MarkLTZ
Follow Bitcoin PRs:
3b69b90 
- Fix gcc 9 warnings bitcoin#16995
- guix: Remove now-unnecessary gcc make flag bitcoin#18320
- build: Remove workaround for ancient libtool bitcoin#17066
- build: Add variable printing target to Makefiles bitcoin#17087
- Disable _FORTIFY_SOURCE when enable-debug bitcoin#17033
ftrader pushed a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this pull request Aug 17, 2020
@dongcarl @ftrader
build: Add variable printing target to Makefiles
feabdec 
Summary:
```
I kept finding myself needing these to debug our build system, since
they are innocuous and are very helpful they probably belong in the
codebase.
```

Backport of core [[bitcoin/bitcoin#17087 | PR17087]].

Can be useful for the depends system.

Test Plan:
  cd depends
  make print-build_arch

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5652
@str4d str4d mentioned this pull request Jan 15, 2021
Merged
zkbot added a commit to zcash/zcash that referenced this pull request Jan 15, 2021
@zkbot
Auto merge of #4950 - str4d:boost-build-backports, r=str4d
a0158ce 
Boost build backports

Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#17087
- bitcoin/bitcoin#17231
- bitcoin/bitcoin#17928
- bitcoin/bitcoin#18820
- bitcoin/bitcoin#19764

Kudos to @dongcarl for all the excellent upstream depends system hackery!
@bitcoin bitcoin locked and limited conversation to collaborators Jan 16, 2021
@bitcoin bitcoin deleted a comment from Psyruss77 Jan 16, 2021
@bitcoin bitcoin deleted a comment from Psyruss77 Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanquake fanquake fanquake approved these changes

Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dongcarl @hebasto @maflcko @promag @fanquake