Skip to content

Conversation

BlockMechanic
Copy link
Contributor

Includes necessary changes to the depends and patches to enable android Qt builds. based on previous work here :- #16916 rebased to master.

@fanquake
Copy link
Member

fanquake commented Oct 8, 2019

@BlockMechanic can you address my comments from the previous PR. Mainly basing this off the work that is already being done in #16110, rather than duplicating the changes.

@BlockMechanic
Copy link
Contributor Author

These depends deal specifically with building QT for android as is. For the necessary changes to build the QML version, i'll push those later

@BlockMechanic
Copy link
Contributor Author

BlockMechanic commented Oct 8, 2019

@fanquake sorry, i am still getting used to using git and performing advanced actions like fethcing someone else's branch , and pushing changes here...hence the mess up i mentioned. I managed to get @icota's branch for #16110 but could not get it to cooperate properly on my end so i could push here.

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 8, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #17165 (Remove BIP70 support by fanquake)
  • #17008 (build: bump libevent to 2.1.11 in depends by stefanwouldgo)
  • #16110 (depends: Add Android NDK support by icota)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@laanwj
Copy link
Member

laanwj commented Oct 9, 2019

Mainly basing this off the work that is already being done in #16110, rather than duplicating the changes.

Good point. I think it would be good if the people working on bitcoin core on Android (@greenaddress, @BlockMechanic, @icota), would start working together instead of besides each other. It's not clear to me how the different changes relate to each other. Maybe we need an Android maintainer at some point. This worked for Windows/MSVC pretty well.

@icota
Copy link
Contributor

icota commented Oct 9, 2019

@laanwj I think the difference is that @BlockMechanic is trying to support 32-bit ARM and x86 as well. Like I commented in #16916 I don't personally see much value and don't have the devices to test this. But changes on top of #16110 are very welcome.

I'm working on a "packaging" PR (to produce an APK) to complement this. It is all very conceptual at this stage but if everything goes to plan and the PRs come together nicely (UI + reproducible build/package) I'd like to volunteer as the Android maintainer. But let's give it some time.

@fanquake
Copy link
Member

fanquake commented Oct 9, 2019

Yes my point is mainly that, for example, both PRs are bringing in a arc4random_addrandom patch for libevent, so it'd make sense for this PR be based #16110 (opened first, I prefer the patch naming there as well), rather than them being worked on in parallel.

@DrahtBot
Copy link
Contributor

Needs rebase

@BlockMechanic
Copy link
Contributor Author

This is now completed in #16110

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants