-
Notifications
You must be signed in to change notification settings - Fork 37.7k
WIP QT Android Build #16916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP QT Android Build #16916
Conversation
Fixes missing destructor in abstract class CBlockHeader. Not an error but introduces annoying warnings if compiling with clang.
This reverts commit 7d8f0e8.
Known working android QT build depends modifications. It needs clean up though. Please note, i use QT 5.12.4
Thanks @BlockMechanic. I see some commits here that are not really related to Qt or Android so you should clean that up first. Also bumping the Qt version should probably be a separate PR and even then quite controversial. What I find useful from this PR is the 32-bit support which I don't personally care for (don't see the point going forward) but maybe best to work that in on top of #16110. |
Rebasing this on #16110 would be nice; that way I can test if that PR actually works on a device rather than just compiles. Eventually the QT upgrade should be its own PR, but just keep it in here for now; pending more conceptual discussion. We occasionally open an issue to bump the QT version in depends (relevant for this), as well as the minimum supported QT version (not really relevant). See also discussion about macOS and QT 5.12 in #16392. Once you figured out how to build an APK, the next important question, brought up in #16883 is whether this APK can built with Gitian, in particular: if there are any non-deterministic build steps. |
Fix to allow configure to detect at
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
~0 |
Fact is , when it comes to pure numbers, they actually encourage mobile centric development more than desktops.... I can see the points of resistance that may arise but i think it's fair to say that while originally desktop based, bitcoin core (at least the GUI) is long overdue mobile options as the world clearly favours the mobile experience. |
I think we should support any platform as long as there is at least one maintaining it for a (small) user base |
@MarcoFalke I agree but that was point of my criticism that it would need someone to maintain it and test it |
Well in theory everything needs a maintainer but it would be much easier to find someone for the current stuff I think |
I agree with the other commenters here; can you please rebase this on top of #16110. It looks like the majority of commits/changes here will actually disappear. For the changes that are left, can you split them into separate commits, with appropriate descriptions. As pointed out above, we're not going to bump Qt in this PR, as when we upgrade the version of Qt we use in depends we have to consider much more than just Android support. |
i seem to have messed up this branch on my local, so i am re-doing this PR rebased on current master. |
I messed up on my local and ended up creating a new rebased version that has the overall work broken up into smaller parts. see :- #17078 |
It's usually not necessary to make a new PR; you can just delete the broken branch on your local machine, create a new branch with the same name and then force push it. |
Ah... i'll try that. I had seen some PRs with force push but had no idea how to make it happen |
Build with :-
make HOST=i686-linux-android ANDROID_API_LEVEL=24 ANDROID_TARGET_ARCH=x86 ANDROID_TOOLCHAIN_BIN=/opt/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/bin ANDROID_SDK=/opt/android-sdk-linux ANDROID_NDK=/opt/android_ndk -j 4
This gets you up to a binary. I am working on the final steps to produce an APK