build: only pass --disable-dependency-tracking to packages that understand it #16949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this a problem? |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Would be nice if there was a way to make it stop instead of warn on unknown configure arguments, This would make it easy to detect when say, a dependency upgrade invalidates some of the configuration. |
|
I think we want to make sure that given the choice, we supply |
|
@dongcarl Would you rather a comment in |
Let's do that!
|
|
Concept ACK, looks good to me as-is.
Great idea, and there is! Edit: Heh, we'd obviously want to flip this to |
…stand it By blanket passing --disable-dependency-tracking to all depends packages we end up with some warnings like: configure: WARNING: unrecognized options: --disable-dependency-tracking So instead, only pass it to packages that understand it. Related to bitcoin#16354.
19eb427 to
1ba49bc
Compare
|
Thanks @theuni. I've left the changes as they are, and added an additional commit that adds |
|
Gitian builds for commit f4d9307 (master):
Gitian builds for commit babbe24 (master and this pull):
|
|
ACK 1ba49bc |
theuni
approved these changes
Oct 18, 2019
fanquake
added a commit
that referenced
this pull request
Oct 18, 2019
…ges that understand it 1ba49bc build: pass --enable-option-checking to applicable packages (fanquake) bcff8e2 build: only pass --disable-dependency-tracking to packages that understand it (fanquake) Pull request description: By blanket passing `--disable-dependency-tracking` to all depends packages we end up with warnings (i.e in `bdb` or `freetype`) like: ```bash configure: WARNING: unrecognized options: --disable-dependency-tracking ``` Instead, only pass it to packages that actually understand it. Related to #16354. More info on `--disable-dependency-tracking` available [here](https://www.gnu.org/software/automake/manual/html_node/Dependency-Tracking.html). This PR also adds `--enable-option-checking` as a configure option to all applicable packages. ACKs for top commit: laanwj: ACK 1ba49bc theuni: ACK 1ba49bc Tree-SHA512: 6d3143ad5f5d1abed5e0a0b2ffbb4323f21c7bf24b0b8df26fb1b3cd16cf5309bbb830aa5aaec99164d5bbe8e9c62b97aa3e97ee1ddc2c7612bf8ff88a63885e
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 21, 2019
…o packages that understand it 1ba49bc build: pass --enable-option-checking to applicable packages (fanquake) bcff8e2 build: only pass --disable-dependency-tracking to packages that understand it (fanquake) Pull request description: By blanket passing `--disable-dependency-tracking` to all depends packages we end up with warnings (i.e in `bdb` or `freetype`) like: ```bash configure: WARNING: unrecognized options: --disable-dependency-tracking ``` Instead, only pass it to packages that actually understand it. Related to bitcoin#16354. More info on `--disable-dependency-tracking` available [here](https://www.gnu.org/software/automake/manual/html_node/Dependency-Tracking.html). This PR also adds `--enable-option-checking` as a configure option to all applicable packages. ACKs for top commit: laanwj: ACK 1ba49bc theuni: ACK 1ba49bc Tree-SHA512: 6d3143ad5f5d1abed5e0a0b2ffbb4323f21c7bf24b0b8df26fb1b3cd16cf5309bbb830aa5aaec99164d5bbe8e9c62b97aa3e97ee1ddc2c7612bf8ff88a63885e
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 3, 2020
Summary: ``` By blanket passing --disable-dependency-tracking to all depends packages we end up with warnings (i.e in bdb or freetype) like: configure: WARNING: unrecognized options: --disable-dependency-tracking Instead, only pass it to packages that actually understand it. [...] This PR also adds --enable-option-checking as a configure option to all applicable packages. ``` Backport of core [[bitcoin/bitcoin#16949 | PR16949]]. Test Plan: Run the Gitian builds. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5660
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Oct 8, 2020
Update ZeroMQ Includes changes cherry-picked from the following upstream PRs: - bitcoin/bitcoin#9254 - bitcoin/bitcoin#13578 - bitcoin/bitcoin#15844 - bitcoin/bitcoin#16370 - Only the ZeroMQ changes. - bitcoin/bitcoin#16949
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 13, 2021
Summary: ``` By blanket passing --disable-dependency-tracking to all depends packages we end up with warnings (i.e in bdb or freetype) like: configure: WARNING: unrecognized options: --disable-dependency-tracking Instead, only pass it to packages that actually understand it. [...] This PR also adds --enable-option-checking as a configure option to all applicable packages. ``` Backport of core [[bitcoin/bitcoin#16949 | PR16949]]. Test Plan: Run the Gitian builds. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5660
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By blanket passing
--disable-dependency-trackingto all depends packages we end up with warnings (i.e inbdborfreetype) like:Instead, only pass it to packages that actually understand it. Related to #16354.
More info on
--disable-dependency-trackingavailable here.This PR also adds
--enable-option-checkingas a configure option to all applicable packages.