-
Notifications
You must be signed in to change notification settings - Fork 37.8k
doc: Add to Doxygen documentation guidelines #16948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
20a9971
to
b55a4a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions below.
6e85299
to
305182e
Compare
- [Coding Style (C++)](#coding-style-c) | ||
- [Coding Style (Python)](#coding-style-python) | ||
- [Coding Style (Doxygen-compatible comments)](#coding-style-doxygen-compatible-comments) | ||
- [Generating Documentation](#generating-documentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VSCode plugin "Markdown All in One" updated the ToC automatically, oops - shall we keep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TOC updates are welcome, but please keep the original spacing
Needs rebase |
Closing "Up for Grabs". There's a couple of improvements here that could be picked up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will finish this up.
- [Compiling for gprof profiling](#compiling-for-gprof-profiling) | ||
- [debug.log](#debuglog) | ||
- [Testnet and Regtest modes](#testnet-and-regtest-modes) | ||
- [DEBUG_LOCKORDER](#debuglockorder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The #debug_lockorder link should not have been changed; the changed version no longer works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple improvements in the table of contents, but any unneeded formatting changes can be dropped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Minimising.
c902c4c doc: Add to Doxygen documentation guidelines (Jon Layton) Pull request description: Completes the up-for-grabs PR #16948. Changes can be tested here: [doc/developer-notes.md](https://github.com/jonatack/bitcoin/blob/doxygen-developer-notes-improvements/doc/developer-notes.md) Co-authored-by: Jon Layton <me@jonl.io> ACKs for top commit: fanquake: ACK c902c4c - quick read, checked the new links work. laanwj: ACK c902c4c Tree-SHA512: 3b4cebba23061ad5243b2288c2006bf8527e74c689223825f96a44014875d15b2ab6ff54b8aa342ca657a14cf6ce3ab7d6e25bea5befd91162bc2645a74ddb7e
c902c4c doc: Add to Doxygen documentation guidelines (Jon Layton) Pull request description: Completes the up-for-grabs PR bitcoin#16948. Changes can be tested here: [doc/developer-notes.md](https://github.com/jonatack/bitcoin/blob/doxygen-developer-notes-improvements/doc/developer-notes.md) Co-authored-by: Jon Layton <me@jonl.io> ACKs for top commit: fanquake: ACK c902c4c - quick read, checked the new links work. laanwj: ACK c902c4c Tree-SHA512: 3b4cebba23061ad5243b2288c2006bf8527e74c689223825f96a44014875d15b2ab6ff54b8aa342ca657a14cf6ce3ab7d6e25bea5befd91162bc2645a74ddb7e
c902c4c doc: Add to Doxygen documentation guidelines (Jon Layton) Pull request description: Completes the up-for-grabs PR bitcoin#16948. Changes can be tested here: [doc/developer-notes.md](https://github.com/jonatack/bitcoin/blob/doxygen-developer-notes-improvements/doc/developer-notes.md) Co-authored-by: Jon Layton <me@jonl.io> ACKs for top commit: fanquake: ACK c902c4c - quick read, checked the new links work. laanwj: ACK c902c4c Tree-SHA512: 3b4cebba23061ad5243b2288c2006bf8527e74c689223825f96a44014875d15b2ab6ff54b8aa342ca657a14cf6ce3ab7d6e25bea5befd91162bc2645a74ddb7e
Add some tips to developer-notes.md, gathered while doing #16947. Also suggests the simpler
:
notation for Javadoc arguments and adds@return
and@param[out]
example.