Skip to content

Conversation

ch4ot1c
Copy link
Contributor

@ch4ot1c ch4ot1c commented Sep 23, 2019

Add some tips to developer-notes.md, gathered while doing #16947. Also suggests the simpler : notation for Javadoc arguments and adds @return and @param[out] example.

@fanquake fanquake added the Docs label Sep 23, 2019
@ch4ot1c ch4ot1c force-pushed the doc/devnotes-doxygen branch from 20a9971 to b55a4a3 Compare September 24, 2019 05:25
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions below.

@ch4ot1c ch4ot1c force-pushed the doc/devnotes-doxygen branch from 6e85299 to 305182e Compare October 2, 2019 06:30
- [Coding Style (C++)](#coding-style-c)
- [Coding Style (Python)](#coding-style-python)
- [Coding Style (Doxygen-compatible comments)](#coding-style-doxygen-compatible-comments)
- [Generating Documentation](#generating-documentation)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VSCode plugin "Markdown All in One" updated the ToC automatically, oops - shall we keep?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOC updates are welcome, but please keep the original spacing

@DrahtBot
Copy link
Contributor

Needs rebase

@fanquake
Copy link
Member

fanquake commented Jan 5, 2020

Closing "Up for Grabs". There's a couple of improvements here that could be picked up.

Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will finish this up.

- [Compiling for gprof profiling](#compiling-for-gprof-profiling)
- [debug.log](#debuglog)
- [Testnet and Regtest modes](#testnet-and-regtest-modes)
- [DEBUG_LOCKORDER](#debuglockorder)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The #debug_lockorder link should not have been changed; the changed version no longer works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple improvements in the table of contents, but any unneeded formatting changes can be dropped.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Minimising.

fanquake added a commit that referenced this pull request Jan 14, 2020
c902c4c doc: Add to Doxygen documentation guidelines (Jon Layton)

Pull request description:

  Completes the up-for-grabs PR #16948.

  Changes can be tested here: [doc/developer-notes.md](https://github.com/jonatack/bitcoin/blob/doxygen-developer-notes-improvements/doc/developer-notes.md)

  Co-authored-by: Jon Layton <me@jonl.io>

ACKs for top commit:
  fanquake:
    ACK c902c4c - quick read, checked the new links work.
  laanwj:
    ACK c902c4c

Tree-SHA512: 3b4cebba23061ad5243b2288c2006bf8527e74c689223825f96a44014875d15b2ab6ff54b8aa342ca657a14cf6ce3ab7d6e25bea5befd91162bc2645a74ddb7e
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 14, 2020
c902c4c doc: Add to Doxygen documentation guidelines (Jon Layton)

Pull request description:

  Completes the up-for-grabs PR bitcoin#16948.

  Changes can be tested here: [doc/developer-notes.md](https://github.com/jonatack/bitcoin/blob/doxygen-developer-notes-improvements/doc/developer-notes.md)

  Co-authored-by: Jon Layton <me@jonl.io>

ACKs for top commit:
  fanquake:
    ACK c902c4c - quick read, checked the new links work.
  laanwj:
    ACK c902c4c

Tree-SHA512: 3b4cebba23061ad5243b2288c2006bf8527e74c689223825f96a44014875d15b2ab6ff54b8aa342ca657a14cf6ce3ab7d6e25bea5befd91162bc2645a74ddb7e
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
c902c4c doc: Add to Doxygen documentation guidelines (Jon Layton)

Pull request description:

  Completes the up-for-grabs PR bitcoin#16948.

  Changes can be tested here: [doc/developer-notes.md](https://github.com/jonatack/bitcoin/blob/doxygen-developer-notes-improvements/doc/developer-notes.md)

  Co-authored-by: Jon Layton <me@jonl.io>

ACKs for top commit:
  fanquake:
    ACK c902c4c - quick read, checked the new links work.
  laanwj:
    ACK c902c4c

Tree-SHA512: 3b4cebba23061ad5243b2288c2006bf8527e74c689223825f96a44014875d15b2ab6ff54b8aa342ca657a14cf6ce3ab7d6e25bea5befd91162bc2645a74ddb7e
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants