Skip to content

doc: Update tx-size-small comment with relevant CVE disclosure #16885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2019
Merged

doc: Update tx-size-small comment with relevant CVE disclosure #16885

merged 1 commit into from
Sep 19, 2019

Conversation

instagibbs
Copy link
Member

Code first introduced under #11423 with essentially no description and no discussion.

@instagibbs instagibbs force-pushed the CVE-2017-12842_comment branch from 5f72a76 to 1646363 Compare September 16, 2019 16:13
@practicalswift
Copy link
Contributor

Concept ACK

@fanquake fanquake added the Docs label Sep 16, 2019
@laanwj
Copy link
Member

laanwj commented Sep 18, 2019

ACK 1646363

@maflcko maflcko changed the title Update tx-size-small comment with relevant CVE disclosure doc: Update tx-size-small comment with relevant CVE disclosure Sep 18, 2019
@maflcko
Copy link
Member

maflcko commented Sep 18, 2019

Could also update the SizeTooSmall with the CVE number similar to #14696?

@maflcko maflcko added this to the 0.19.0 milestone Sep 18, 2019
@instagibbs instagibbs force-pushed the CVE-2017-12842_comment branch from 1646363 to c4b0c08 Compare September 18, 2019 20:21
@instagibbs
Copy link
Member Author

@MarcoFalke done

@maflcko
Copy link
Member

maflcko commented Sep 18, 2019

ACK c4b0c08

fanquake
fanquake approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c4b0c08

fanquake added a commit that referenced this pull request Sep 19, 2019
@fanquake
Merge #16885: doc: Update tx-size-small comment with relevant CVE dis…
9bf5768 
…closure

c4b0c08 Update tx-size-small comment with relevant CVE disclosure (Gregory Sanders)

Pull request description:

  Code first introduced under #11423 with essentially no description and no discussion.

ACKs for top commit:
  MarcoFalke:
    ACK c4b0c08
  fanquake:
    ACK c4b0c08

Tree-SHA512: 95d5c92998b8b1e944c477dbaee265b62612b6e815099ab31d9ff580b4dff777abaf7f326a284644709f918aa1510412d62310689b1250ef6e64de7b19ca9f71
@fanquake fanquake merged commit c4b0c08 into bitcoin:master Sep 19, 2019
@maflcko maflcko mentioned this pull request Mar 9, 2020
Closed
@adamjonas adamjonas mentioned this pull request Feb 12, 2021
Merged
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 7, 2021
@fanquake @Munkybooty
Merge bitcoin#16885: doc: Update tx-size-small comment with relevant …
7c5a70c 
…CVE disclosure

c4b0c08 Update tx-size-small comment with relevant CVE disclosure (Gregory Sanders)

Pull request description:

  Code first introduced under bitcoin#11423 with essentially no description and no discussion.

ACKs for top commit:
  MarcoFalke:
    ACK c4b0c08
  fanquake:
    ACK c4b0c08

Tree-SHA512: 95d5c92998b8b1e944c477dbaee265b62612b6e815099ab31d9ff580b4dff777abaf7f326a284644709f918aa1510412d62310689b1250ef6e64de7b19ca9f71
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 7, 2021
@fanquake @Munkybooty
Merge bitcoin#16885: doc: Update tx-size-small comment with relevant …
cdc4636 
…CVE disclosure

c4b0c08 Update tx-size-small comment with relevant CVE disclosure (Gregory Sanders)

Pull request description:

  Code first introduced under bitcoin#11423 with essentially no description and no discussion.

ACKs for top commit:
  MarcoFalke:
    ACK c4b0c08
  fanquake:
    ACK c4b0c08

Tree-SHA512: 95d5c92998b8b1e944c477dbaee265b62612b6e815099ab31d9ff580b4dff777abaf7f326a284644709f918aa1510412d62310689b1250ef6e64de7b19ca9f71
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 7, 2021
@fanquake @Munkybooty
Merge bitcoin#16885: doc: Update tx-size-small comment with relevant …
6362ec7 
…CVE disclosure

c4b0c08 Update tx-size-small comment with relevant CVE disclosure (Gregory Sanders)

Pull request description:

  Code first introduced under bitcoin#11423 with essentially no description and no discussion.

ACKs for top commit:
  MarcoFalke:
    ACK c4b0c08
  fanquake:
    ACK c4b0c08

Tree-SHA512: 95d5c92998b8b1e944c477dbaee265b62612b6e815099ab31d9ff580b4dff777abaf7f326a284644709f918aa1510412d62310689b1250ef6e64de7b19ca9f71
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 7, 2021
@fanquake @Munkybooty
Merge bitcoin#16885: doc: Update tx-size-small comment with relevant …
4aaf727 
…CVE disclosure

c4b0c08 Update tx-size-small comment with relevant CVE disclosure (Gregory Sanders)

Pull request description:

  Code first introduced under bitcoin#11423 with essentially no description and no discussion.

ACKs for top commit:
  MarcoFalke:
    ACK c4b0c08
  fanquake:
    ACK c4b0c08

Tree-SHA512: 95d5c92998b8b1e944c477dbaee265b62612b6e815099ab31d9ff580b4dff777abaf7f326a284644709f918aa1510412d62310689b1250ef6e64de7b19ca9f71
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 15, 2021
@fanquake @Munkybooty
Merge bitcoin#16885: doc: Update tx-size-small comment with relevant …
5eeffca 
…CVE disclosure

c4b0c08 Update tx-size-small comment with relevant CVE disclosure (Gregory Sanders)

Pull request description:

  Code first introduced under bitcoin#11423 with essentially no description and no discussion.

ACKs for top commit:
  MarcoFalke:
    ACK c4b0c08
  fanquake:
    ACK c4b0c08

Tree-SHA512: 95d5c92998b8b1e944c477dbaee265b62612b6e815099ab31d9ff580b4dff777abaf7f326a284644709f918aa1510412d62310689b1250ef6e64de7b19ca9f71
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Dec 15, 2021
@fanquake @Munkybooty
Merge bitcoin#16885: doc: Update tx-size-small comment with relevant …
3b4c0e5 
…CVE disclosure

c4b0c08 Update tx-size-small comment with relevant CVE disclosure (Gregory Sanders)

Pull request description:

  Code first introduced under bitcoin#11423 with essentially no description and no discussion.

ACKs for top commit:
  MarcoFalke:
    ACK c4b0c08
  fanquake:
    ACK c4b0c08

Tree-SHA512: 95d5c92998b8b1e944c477dbaee265b62612b6e815099ab31d9ff580b4dff777abaf7f326a284644709f918aa1510412d62310689b1250ef6e64de7b19ca9f71
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanquake fanquake fanquake approved these changes

Assignees
No one assigned
Labels
Docs Validation
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
6 participants
@instagibbs @practicalswift @laanwj @maflcko @fanquake @DrahtBot