build: Treat -Wswitch as error when --enable-werror #16424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can be tested by adding a new type to one of our |
|
Concept 👏 |
|
utACK fabfcb5 Very nice! |
|
ACK fabfcb5 |
|
Concept ACK |
|
Gitian builds for commit febf3a8 (master):
Gitian builds for commit 58f130f (master and this pull):
|
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jul 29, 2019
fabfcb5 build: Treat -Wswitch as error when --enable-werror (MarcoFalke) Pull request description: By default we set `-Wall`, which enabled `-Wswitch`, so this already prints warnings. However, it can be additionally be turned into an error when `--enable-werror` to be extra safe. ACKs for top commit: practicalswift: utACK fabfcb5 Empact: ACK bitcoin@fabfcb5 Tree-SHA512: f6bd6dba93a4f3740811eb338b6db93b4f72d237afe848aefd212abecaf4f430c5a417ccb2f9fec0bdbc46001176f0cfa0bbf4d99a7fcf0e34dca4a9476e8456
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 30, 2019
fabfcb5 build: Treat -Wswitch as error when --enable-werror (MarcoFalke) Pull request description: By default we set `-Wall`, which enabled `-Wswitch`, so this already prints warnings. However, it can be additionally be turned into an error when `--enable-werror` to be extra safe. ACKs for top commit: practicalswift: utACK fabfcb5 Empact: ACK bitcoin@fabfcb5 Tree-SHA512: f6bd6dba93a4f3740811eb338b6db93b4f72d237afe848aefd212abecaf4f430c5a417ccb2f9fec0bdbc46001176f0cfa0bbf4d99a7fcf0e34dca4a9476e8456
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 17, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 17, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 17, 2021
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Jun 23, 2021
merge bitcoin#18914, bitcoin#13306, bitcoin#16424, bitcoin#13899, bitcoin#17486, bitcoin#17880, bitcoin#18145, bitcoin#18843, bitcoin#16710: split warnings out of CXXFLAGS, add more flags
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we set
-Wall, which enabled-Wswitch, so this already prints warnings. However, it can be additionally be turned into an error when--enable-werrorto be extra safe.