depends: Bump QT to LTS release 5.9.8 #16413
Conversation
I think having some references would help testing. |
|
I don't know if QTBUG-69955 is noticeable in the bitcoin-qt, but it is/was in other projects. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
Ref: fixed in 5.9.8 |
It looks like we should already have that fix, as it was included in the 5.9.7 release? Looking at the 5.9.8 fixes, I'm not sure if there's anything in there that affects the parts of Qt we use. Could you outline in the PR description which bug fixes we want? In any case, the 5.9.9 LTS release is slated for Q4 of this year (likely before our 0.19.0 release), so if we haven't updated to the 5.12 LTS before then, we could update Qt to 5.9.9 at that point if there was a pressing reason too. |
|
Gitian builds for commit febf3a8 (master):
Gitian builds for commit 0454597 (master and this pull):
|
|
Can anyone with MacOSX please test if this makes a difference? Will leave this open until short before 0.19 split-off—if there hasn't been a larger Qt bump by then, let's merge this. |
|
Hi I'd like to suggest a bump to Qt 5.12 LTS. Previous versions make multiple issue and require a lot of patches to work with aarch64. The major contributing factor for my advocating going this route is Google deprecating both 32-bit apps and GCC in favour of Clang as mentioned here :- #16110 (comment) Some patches have already been proposed/merged such as #16110 which enables bitcoind to build but not QT (android) and this :- #13696 which does enable Qt but is now obsolete due to the move to clang. |
@BlockMechanic I've suggested that here, however there are other things to consider when bumping, such as dropping compatibility with older operating systems. Qt dropped support for macOS < 10.12 in 5.12. |
Ok thanks , I had already begun checking it out :) |
|
ACK 0c6054f. Lightly tested on macOS 10.14.6. Not really sure what difference would matter on macOS. Where does QT announce which versions are LTS? I'm fine with holding off merging, and instead bumping to whichever 5.9 version is the most recent closer to the 0.19 branch-off. |
|
Okay, that's a good reason to not do that for 0.19. |
0c6054f depends: Bump QT to LTS release 5.9.8 (THETCR) Pull request description: This update is only a minor version but in contrary to 5.9.7 it's a LTS release. It doesn't add any new functionality to Qt but fixes multiple security issues and bugs. Including some race conditions and annoying bugs on macOS. ACKs for top commit: Sjors: ACK 0c6054f. Lightly tested on macOS 10.14.6. Not really sure what difference would matter on macOS. Tree-SHA512: f01d947cc0db6d761e32551071fa00fe8014fb7b2ce707271a159bb61c6d60e062ac8f4da5f36bd8fc4736e1e852368a1353ea3f994f61f1d0c76cc7d1664938
0c6054f depends: Bump QT to LTS release 5.9.8 (THETCR) Pull request description: This update is only a minor version but in contrary to 5.9.7 it's a LTS release. It doesn't add any new functionality to Qt but fixes multiple security issues and bugs. Including some race conditions and annoying bugs on macOS. ACKs for top commit: Sjors: ACK 0c6054f. Lightly tested on macOS 10.14.6. Not really sure what difference would matter on macOS. Tree-SHA512: f01d947cc0db6d761e32551071fa00fe8014fb7b2ce707271a159bb61c6d60e062ac8f4da5f36bd8fc4736e1e852368a1353ea3f994f61f1d0c76cc7d1664938
This update is only a minor version but in contrary to 5.9.7 it's a LTS release.
It doesn't add any new functionality to Qt but fixes multiple security issues and bugs.
Including some race conditions and annoying bugs on macOS.