Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Jul 7, 2019

BITCOIN_QT_TEST is no longer used since switching to autotools build system.

Some historical refs:

It is no longer used since switching to autotools build system.
@fanquake fanquake added the GUI label Jul 7, 2019
@practicalswift
Copy link
Contributor

utACK d003110

@promag
Copy link
Contributor

promag commented Jul 7, 2019

ACK d003110.

@jonasschnelli
Copy link
Contributor

Verified ACK d003110

pull bot pushed a commit to jaschadub/bitcoin that referenced this pull request Jul 8, 2019
d003110 Remove unused guard (Hennadii Stepanov)

Pull request description:

  `BITCOIN_QT_TEST` is no longer used since switching to autotools build system.

  Some historical refs:
  - #807
  - bitcoin#4241

ACKs for top commit:
  practicalswift:
    utACK d003110
  promag:
    ACK d003110.
  jonasschnelli:
    Verified ACK d003110

Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
@fanquake fanquake merged commit d003110 into bitcoin:master Jul 8, 2019
@hebasto hebasto deleted the 20190707-remove-unused-guard branch July 8, 2019 14:25
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 9, 2020
Summary:
PR description:
> BITCOIN_QT_TEST is no longer used since switching to autotools build system.
>
> Some historical refs:
>
>    bitcoin/bitcoin#807
>    bitcoin/bitcoin#4241

Backport of Core [[bitcoin/bitcoin#16350 | PR16350]]

Test Plan:
```
grep -r BITCOIN_QT_TEST[^_] .
cd build
ninja && ninja check
```

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7846
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 21, 2021
d003110 Remove unused guard (Hennadii Stepanov)

Pull request description:

  `BITCOIN_QT_TEST` is no longer used since switching to autotools build system.

  Some historical refs:
  - dashpay#807
  - dashpay#4241

ACKs for top commit:
  practicalswift:
    utACK d003110
  promag:
    ACK d003110.
  jonasschnelli:
    Verified ACK d003110

Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
kwvg pushed a commit to kwvg/dash that referenced this pull request Oct 12, 2021
d003110 Remove unused guard (Hennadii Stepanov)

Pull request description:

  `BITCOIN_QT_TEST` is no longer used since switching to autotools build system.

  Some historical refs:
  - dashpay#807
  - dashpay#4241

ACKs for top commit:
  practicalswift:
    utACK d003110
  promag:
    ACK d003110.
  jonasschnelli:
    Verified ACK d003110

Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants