test: Add test for unknown args #16234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requested by @hebasto as part of #16112 (comment) |
|
Approach ACK. |
|
I really thought this was already tested, actually it's was added only in bitcoin/test/functional/tool_wallet.py Line 45 in 0221420 ACK fa7dd88, tests looks good to me. |
|
ACK fa7dd88, I have tested the code. |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jun 20, 2019
fa7dd88 test: Add test for unknown args (MarcoFalke) Pull request description: Currently uncovered. Further reading: * https://marcofalke.github.io/btc_cov/total.coverage/src/util/system.cpp.gcov.html * Fail on unknown config file options bitcoin#15021 ACKs for commit fa7dd8: promag: ACK fa7dd88, tests looks good to me. hebasto: ACK fa7dd88, I have tested the code. Tree-SHA512: 86ab370ce8e85925f945a52e81457b5678d71bbabcef01205a97782b780003f363552e0bad1ff678bccc784f82c6b511c3b88de3f8f25f62b0b713c387950564
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 20, 2019
fa7dd88 test: Add test for unknown args (MarcoFalke) Pull request description: Currently uncovered. Further reading: * https://marcofalke.github.io/btc_cov/total.coverage/src/util/system.cpp.gcov.html * Fail on unknown config file options bitcoin#15021 ACKs for commit fa7dd8: promag: ACK fa7dd88, tests looks good to me. hebasto: ACK fa7dd88, I have tested the code. Tree-SHA512: 86ab370ce8e85925f945a52e81457b5678d71bbabcef01205a97782b780003f363552e0bad1ff678bccc784f82c6b511c3b88de3f8f25f62b0b713c387950564
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 26, 2020
Summary: `Currently uncovered.` Backport of core [[bitcoin/bitcoin#16234 | PR16234]]. Depends on D5554. Test Plan: ninja check-functional Reviewers: #bitcoin_abc, nakihito Reviewed By: nakihito Differential Revision: https://reviews.bitcoinabc.org/D5555
maflcko
pushed a commit
that referenced
this pull request
Oct 19, 2020
fa48405 Warn on unknown rw_settings (MarcoFalke) Pull request description: Log a warning to debug log if unknown settings are encountered. This should probably only ever happen when the software is upgraded. Something similar is already done for the command line and config file. See: * test: Add test for unknown args #16234 (commit fa7dd88) ACKs for top commit: ryanofsky: Code review ACK fa48405. Looks good and I could see this being helpful for debugging. Thanks for taking suggestions Tree-SHA512: cec7d88adf84fa0a842f56b26245157736eb50df433db951e622ea07fd145b899822b24cdab1d8b36c066415ce4f0ef09b493fa8a8d691532822a59c573aafa7
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 19, 2020
fa48405 Warn on unknown rw_settings (MarcoFalke) Pull request description: Log a warning to debug log if unknown settings are encountered. This should probably only ever happen when the software is upgraded. Something similar is already done for the command line and config file. See: * test: Add test for unknown args bitcoin#16234 (commit fa7dd88) ACKs for top commit: ryanofsky: Code review ACK fa48405. Looks good and I could see this being helpful for debugging. Thanks for taking suggestions Tree-SHA512: cec7d88adf84fa0a842f56b26245157736eb50df433db951e622ea07fd145b899822b24cdab1d8b36c066415ce4f0ef09b493fa8a8d691532822a59c573aafa7
linuxsh2
pushed a commit
to linuxsh2/dash
that referenced
this pull request
Aug 11, 2021
fa7dd88 test: Add test for unknown args (MarcoFalke) Pull request description: Currently uncovered. Further reading: * https://marcofalke.github.io/btc_cov/total.coverage/src/util/system.cpp.gcov.html * Fail on unknown config file options bitcoin#15021 ACKs for commit fa7dd8: promag: ACK fa7dd88, tests looks good to me. hebasto: ACK fa7dd88, I have tested the code. Tree-SHA512: 86ab370ce8e85925f945a52e81457b5678d71bbabcef01205a97782b780003f363552e0bad1ff678bccc784f82c6b511c3b88de3f8f25f62b0b713c387950564
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 25, 2021
Summary: Log a warning to debug log if unknown settings are encountered. This should probably only ever happen when the software is upgraded. Something similar is already done for the command line and config file. See [[bitcoin/bitcoin#16234 | core#16234]] This is a backport of [[bitcoin/bitcoin#19624 | core#19624]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10541
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently uncovered.
Further reading: