wallet: do not encrypt wallets with disabled private keys #16144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
168d612 to
7860c98
Compare
|
Is this for backport? |
|
utACK 7860c98
Could be. It's not a regression though and probably doesn't effect that many people. |
laanwj
added a commit
that referenced
this pull request
Jun 5, 2019
7860c98 wallet: do not encrypt wallets with disabled private keys (whythat) Pull request description: Fix for #15635. Throw an `RPC_WALLET_ENCRYPTION_FAILED` error when attempting to encrypt wallet with disabled private keys. Changed `test/function/wallet_createwallet.py` to test new behavior. ACKs for commit 7860c9: achow101: utACK 7860c98 meshcollider: utACK 7860c98 Tree-SHA512: d0cc40efd303a00d0b4d3cb2de59d8d2d7dd35647e7f3fe9d4a8986589499c1f567c5780c83a129e1ab8dbe601279c459c6ebce3b48b1d81d47a28616ef4a369
|
utACK 7860c98 |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Aug 23, 2019
Github-Pull: bitcoin#16144 Rebased-From: 7860c98
Merged
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 5, 2020
… keys Summary: wallet: do not encrypt wallets with disabled private keys (whythat) Pull request description: Fix for #15635. Throw an `RPC_WALLET_ENCRYPTION_FAILED` error when attempting to encrypt wallet with disabled private keys. Changed `test/function/wallet_createwallet.py` to test new behavior. --- Backport of Core [[bitcoin/bitcoin#16144 | PR16144]] Test Plan: ninja check test_runner.py wallet_createwallet Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7368
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Oct 17, 2021
…vate keys 7860c98 wallet: do not encrypt wallets with disabled private keys (whythat) Pull request description: Fix for bitcoin#15635. Throw an `RPC_WALLET_ENCRYPTION_FAILED` error when attempting to encrypt wallet with disabled private keys. Changed `test/function/wallet_createwallet.py` to test new behavior. ACKs for commit 7860c9: achow101: utACK 7860c98 meshcollider: utACK bitcoin@7860c98 Tree-SHA512: d0cc40efd303a00d0b4d3cb2de59d8d2d7dd35647e7f3fe9d4a8986589499c1f567c5780c83a129e1ab8dbe601279c459c6ebce3b48b1d81d47a28616ef4a369
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Oct 25, 2021
…vate keys 7860c98 wallet: do not encrypt wallets with disabled private keys (whythat) Pull request description: Fix for bitcoin#15635. Throw an `RPC_WALLET_ENCRYPTION_FAILED` error when attempting to encrypt wallet with disabled private keys. Changed `test/function/wallet_createwallet.py` to test new behavior. ACKs for commit 7860c9: achow101: utACK 7860c98 meshcollider: utACK bitcoin@7860c98 Tree-SHA512: d0cc40efd303a00d0b4d3cb2de59d8d2d7dd35647e7f3fe9d4a8986589499c1f567c5780c83a129e1ab8dbe601279c459c6ebce3b48b1d81d47a28616ef4a369
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Oct 26, 2021
…bled private keys 7860c98 wallet: do not encrypt wallets with disabled private keys (whythat) Pull request description: Fix for bitcoin#15635. Throw an `RPC_WALLET_ENCRYPTION_FAILED` error when attempting to encrypt wallet with disabled private keys. Changed `test/function/wallet_createwallet.py` to test new behavior. ACKs for commit 7860c9: achow101: utACK 7860c98 meshcollider: utACK bitcoin@7860c98 Tree-SHA512: d0cc40efd303a00d0b4d3cb2de59d8d2d7dd35647e7f3fe9d4a8986589499c1f567c5780c83a129e1ab8dbe601279c459c6ebce3b48b1d81d47a28616ef4a369
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Oct 26, 2021
…bled private keys 7860c98 wallet: do not encrypt wallets with disabled private keys (whythat) Pull request description: Fix for bitcoin#15635. Throw an `RPC_WALLET_ENCRYPTION_FAILED` error when attempting to encrypt wallet with disabled private keys. Changed `test/function/wallet_createwallet.py` to test new behavior. ACKs for commit 7860c9: achow101: utACK 7860c98 meshcollider: utACK bitcoin@7860c98 Tree-SHA512: d0cc40efd303a00d0b4d3cb2de59d8d2d7dd35647e7f3fe9d4a8986589499c1f567c5780c83a129e1ab8dbe601279c459c6ebce3b48b1d81d47a28616ef4a369
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Nov 9, 2021
…bled private keys 7860c98 wallet: do not encrypt wallets with disabled private keys (whythat) Pull request description: Fix for bitcoin#15635. Throw an `RPC_WALLET_ENCRYPTION_FAILED` error when attempting to encrypt wallet with disabled private keys. Changed `test/function/wallet_createwallet.py` to test new behavior. ACKs for commit 7860c9: achow101: utACK 7860c98 meshcollider: utACK bitcoin@7860c98 Tree-SHA512: d0cc40efd303a00d0b4d3cb2de59d8d2d7dd35647e7f3fe9d4a8986589499c1f567c5780c83a129e1ab8dbe601279c459c6ebce3b48b1d81d47a28616ef4a369
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
…bled private keys 7860c98 wallet: do not encrypt wallets with disabled private keys (whythat) Pull request description: Fix for bitcoin#15635. Throw an `RPC_WALLET_ENCRYPTION_FAILED` error when attempting to encrypt wallet with disabled private keys. Changed `test/function/wallet_createwallet.py` to test new behavior. ACKs for commit 7860c9: achow101: utACK 7860c98 meshcollider: utACK bitcoin@7860c98 Tree-SHA512: d0cc40efd303a00d0b4d3cb2de59d8d2d7dd35647e7f3fe9d4a8986589499c1f567c5780c83a129e1ab8dbe601279c459c6ebce3b48b1d81d47a28616ef4a369
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #15635.
Throw an
RPC_WALLET_ENCRYPTION_FAILEDerror when attempting to encrypt wallet with disabled private keys. Changedtest/function/wallet_createwallet.pyto test new behavior.