Qt: Add vertical spacer to peer detail widget #16090

JosuGZ · 2019-05-25T23:12:01Z

Before:

After:

practicalswift · 2019-05-26T08:23:39Z

Concept ACK: looks much better!

@JosuGZ, welcome as a contributor! Hope to see more contributions from you! :-)

JosuGZ · 2019-05-26T10:44:35Z

Concept ACK: looks much better!

@JosuGZ, welcome as a contributor! Hope to see more contributions from you! :-)

Thanks! I have no clue about why that rpc_psbt.py test fails though.

practicalswift · 2019-05-26T11:01:55Z

@joshrabinowitz That is just a random unrelated failure :-)

kristapsk

ACK 36b0a2f (tested with Qt 5.11.3 under Linux/Xfce4)

promag

Tested ACK 36b0a2f on macos 10.14.3. Resizing the window works as expected.

promag · 2019-05-27T13:40:24Z

src/qt/forms/debugwindow.ui

+                 <property name="orientation">
+                  <enum>Qt::Vertical</enum>
+                 </property>
+                 <property name="sizeHint" stdset="0">


Property could be removed.

It seems indeed unneeded, I think it is how Qt creator creates spacers though. Change pushed.

Hmm, I'm noticing other spacers have the property set, like the one in the information tab on the same file.

fanquake · 2019-05-28T14:31:37Z

utACK 36b0a2f

This change doesn't seem to make any difference on macOS (10.14.x), as the before behavior isn't present.

@JosuGZ What OS are you seeing this issue on?

promag · 2019-05-28T14:43:20Z

@fanquake I'm on a macos and it also stretches the details (macos 10.14.3, Qt 5.12.2).

kristapsk · 2019-05-28T15:23:45Z

@fanquake , I have the "before" behaviour also on Linux/Xfce4, Qt 5.11.3.

JosuGZ · 2019-05-28T17:15:58Z

@fanquake

@JosuGZ What OS are you seeing this issue on?

Linux Mint 19.1 Tessa

It usually also happens when I do this kind of layouts on Windows.

fanquake · 2019-05-28T17:23:40Z

@promag @kristapsk @JosuGZ Thanks for clarifying.

hebasto · 2019-05-28T17:42:18Z

tACK 36b0a2f on Linux Mint 19.1, Qt 5.9.5
Could you squash your commits?

The different behavior (some can see 'before', others not) can be caused by QGridLayout::setRowStretch:

If the stretch factor is 0 and no other row in this table can grow at all, the row may still grow.

JosuGZ · 2019-05-28T17:51:23Z

@hebasto I have left the property for coherency with the rest of the file and with Qt Creator.

fanquake · 2019-06-03T14:14:33Z

re-utACK 36b0a2f

Could have used a commit message like gui: add vertical spacer to peers window.

JosuGZ · 2019-06-03T14:51:25Z

True. Shouldn't appear in the the merge commit anyway?

36b0a2f Add vertical spacer (Josu Goñi) Pull request description: Before: ![image](https://user-images.githubusercontent.com/25986871/58375408-a8f22c80-7f52-11e9-96ca-14f2186e6fa7.png) After: ![image](https://user-images.githubusercontent.com/25986871/58375420-fa022080-7f52-11e9-8add-eafe98068e8d.png) ACKs for commit 36b0a2: fanquake: utACK 36b0a2f hebasto: tACK 36b0a2f on Linux Mint 19.1, Qt 5.9.5 fanquake: re-utACK 36b0a2f kristapsk: ACK 36b0a2f (tested with Qt 5.11.3 under Linux/Xfce4) promag: Tested ACK 36b0a2f on macos 10.14.3. Resizing the window works as expected. Tree-SHA512: 26ec9700aa9116ec2c604f8ec7b825b30c83c1d497c21f2191d3585868db4a2e3921de607dea9f7cd9a1ea49361215d738e2aba1936566d85757d87112d73088

36b0a2f Add vertical spacer (Josu Goñi) Pull request description: Before: ![image](https://user-images.githubusercontent.com/25986871/58375408-a8f22c80-7f52-11e9-96ca-14f2186e6fa7.png) After: ![image](https://user-images.githubusercontent.com/25986871/58375420-fa022080-7f52-11e9-8add-eafe98068e8d.png) ACKs for commit 36b0a2: fanquake: utACK bitcoin@36b0a2f hebasto: tACK 36b0a2f on Linux Mint 19.1, Qt 5.9.5 fanquake: re-utACK bitcoin@36b0a2f kristapsk: ACK 36b0a2f (tested with Qt 5.11.3 under Linux/Xfce4) promag: Tested ACK bitcoin@36b0a2f on macos 10.14.3. Resizing the window works as expected. Tree-SHA512: 26ec9700aa9116ec2c604f8ec7b825b30c83c1d497c21f2191d3585868db4a2e3921de607dea9f7cd9a1ea49361215d738e2aba1936566d85757d87112d73088

Github-Pull: bitcoin#16090 Rebased-From: 36b0a2f

0b18ea6 util: Filter control characters out of log messages (Wladimir J. van der Laan) ac30fc4 build: Factor out qt translations from build system (Wladimir J. van der Laan) 3b8af5f build: update boost macros to latest upstream (fanquake) b12defc Test that joinpsbts randomly shuffles the inputs (Andrew Chow) eb07d22 Shuffle inputs and outputs after joining psbts (Andrew Chow) 1175410 addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests. (practicalswift) c52dd12 Handle the result of posix_fallocate system call (Luca Venturini) f792b25 torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differently (Luke Dashjr) 9fe8d28 Bugfix: QA: Run tests with UPnP disabled (Luke Dashjr) 1d12e52 Add vertical spacer (Josu Goñi) d764141 depends: add patch to common dependencies (fanquake) 56815e9 Give QApplication dummy arguments (Andrew Chow) 9d389d0 util: No translation of `Bitcoin Core` in the copyright (MarcoFalke) 87908e9 scripted-diff: Avoid passing PACKAGE_NAME for translation (MarcoFalke) a44e18f build: Stop translating PACKAGE_NAME (MarcoFalke) 7bd8f4e rpc: Fix getblocktemplate CLI example (#16594) (Emil Engler) 1cc06a1 doc: Fix typos in COPYRIGHT (Chuf) Pull request description: Backports some commits to the `0.18` branch: * #16596 - rpc: Fix getblocktemplate CLI example * #16615 - doc: Fix typos in COPYRIGHT * #16291 - gui: Stop translating PACKAGE_NAME (without the `make translate` commit) * #16578 - Do not pass in command line arguments to QApplication * #16051 - depends: add patch to common dependencies * #16090 - Add vertical spacer * #15651 - torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differently * #15650 - Handle the result of posix_fallocate system call * #16646 - Bugfix: QA: Run tests with UPnP disabled * #16212 - addrdb: Remove temporary files created in SerializeFileDB. Fixes non-determinism in unit tests. * #16512 - rpc: Shuffle inputs and outputs after joining psbts * #16870 - build: update boost macros to latest upstream for improved error reporting * #16982 - build: Factor out qt translations from build system * #17095 - util: Filter control characters out of log messages ACKs for top commit: laanwj: ACK 0b18ea6 Tree-SHA512: 37f0e5afc20975f4d1506e8662eda2ae0125f2f424a852818b5af2c3b8db78fc1c365b83571aa80ca63c885ca314302190b891a50ff3851fda9b9238455a5627

Summary: 36b0a2f2a6b49008c4f37866a9e3ab702eb34eda Add vertical spacer (Josu Goñi) Pull request description: Before: ![image](https://user-images.githubusercontent.com/25986871/58375408-a8f22c80-7f52-11e9-96ca-14f2186e6fa7.png) After: ![image](https://user-images.githubusercontent.com/25986871/58375420-fa022080-7f52-11e9-8add-eafe98068e8d.png) --- Backport of Core [[bitcoin/bitcoin#16090 | PR16090]] Test Plan: ninja all bitcoin-qt -testnet Check out how nicer it looks Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8664

36b0a2f Add vertical spacer (Josu Goñi) Pull request description: Before: ![image](https://user-images.githubusercontent.com/25986871/58375408-a8f22c80-7f52-11e9-96ca-14f2186e6fa7.png) After: ![image](https://user-images.githubusercontent.com/25986871/58375420-fa022080-7f52-11e9-8add-eafe98068e8d.png) ACKs for commit 36b0a2: fanquake: utACK bitcoin@36b0a2f hebasto: tACK 36b0a2f on Linux Mint 19.1, Qt 5.9.5 fanquake: re-utACK bitcoin@36b0a2f kristapsk: ACK 36b0a2f (tested with Qt 5.11.3 under Linux/Xfce4) promag: Tested ACK bitcoin@36b0a2f on macos 10.14.3. Resizing the window works as expected. Tree-SHA512: 26ec9700aa9116ec2c604f8ec7b825b30c83c1d497c21f2191d3585868db4a2e3921de607dea9f7cd9a1ea49361215d738e2aba1936566d85757d87112d73088

Add vertical spacer

36b0a2f

DrahtBot added the GUI label May 25, 2019

kristapsk approved these changes May 26, 2019

View reviewed changes

promag reviewed May 27, 2019

View reviewed changes

JosuGZ force-pushed the gui-improvements branch from b292f5b to 36b0a2f Compare May 28, 2019 17:48

laanwj merged commit 36b0a2f into bitcoin:master Jun 3, 2019

luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Aug 23, 2019

Add vertical spacer

1f5ea6f

Github-Pull: bitcoin#16090 Rebased-From: 36b0a2f

luke-jr mentioned this pull request Aug 23, 2019

[0.18.2] Backports #16617

Merged

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Aug 24, 2019

Add vertical spacer

07cacf6

Github-Pull: bitcoin#16090 Rebased-From: 36b0a2f

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Sep 3, 2019

Add vertical spacer

b0747b3

Github-Pull: bitcoin#16090 Rebased-From: 36b0a2f

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Sep 23, 2019

Add vertical spacer

1d12e52

Github-Pull: bitcoin#16090 Rebased-From: 36b0a2f

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

Qt: Add vertical spacer to peer detail widget #16090

Qt: Add vertical spacer to peer detail widget #16090

Uh oh!

Conversation

JosuGZ commented May 25, 2019

Uh oh!

practicalswift commented May 26, 2019

Uh oh!

JosuGZ commented May 26, 2019

Uh oh!

practicalswift commented May 26, 2019

Uh oh!

kristapsk left a comment

Choose a reason for hiding this comment

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

promag May 27, 2019

Choose a reason for hiding this comment

Uh oh!

JosuGZ May 28, 2019

Choose a reason for hiding this comment

Uh oh!

JosuGZ May 28, 2019

Choose a reason for hiding this comment

Uh oh!

fanquake commented May 28, 2019

Uh oh!

promag commented May 28, 2019

Uh oh!

kristapsk commented May 28, 2019

Uh oh!

JosuGZ commented May 28, 2019

Uh oh!

fanquake commented May 28, 2019

Uh oh!

hebasto commented May 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JosuGZ commented May 28, 2019

Uh oh!

fanquake commented Jun 3, 2019

Uh oh!

JosuGZ commented Jun 3, 2019

Uh oh!

Uh oh!

hebasto commented May 28, 2019 •

edited

Loading