wallet_balance.py: Prevent edge cases #16079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
May 23, 2019
|
ACK, ran into the same issue yesterday. Thanks for fixing before I could |
d475566 to
bb41e63
Compare
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 23, 2019
bb41e63 wallet_balance.py: Prevent edge cases (Steven Roose) Pull request description: I ran into this edge case when running the test on Elements. I had a 0-value output as change. ACKs for commit bb41e6: Tree-SHA512: ef4c25289cafcdb4437f11ed537664dff5afedcefab75a46f985d3be70551de2d3bc8e9cfcb22c0f3d7d2eb95ff40df78b8d01dbacbf90c36bca00426937b0a2
|
utACK bb41e63. |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Aug 23, 2019
Github-Pull: bitcoin#16079 Rebased-From: bb41e63
Merged
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 22, 2020
Summary: bitcoin/bitcoin@bb41e63 --- Backport of Core [[bitcoin/bitcoin#16079 | PR16079]] Test Plan: ninja test_runner.py wallet_balance Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D6661
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this edge case when running the test on Elements. I had a 0-value output as change.