refactor: Avoid UniValue copy constructor #15974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UniValue constructor improvements welcomed... a version 2.0 that ditches old APIs (no impact on bitcoin) is scheduled, fwiw. |
|
Concept ACK |
|
Concept ACK - some NullUniValue changes could be scripted to be verifiably consistent and comprehensive |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
laanwj
added a commit
that referenced
this pull request
Jul 8, 2019
91509ff bench: Benchmark blockToJSON (Kirill Fomichev) Pull request description: Related: - "getblock performance issue on verbosity" #15925 - "refactor: Avoid UniValue copy constructor" #15974 ACKs for top commit: laanwj: ACK 91509ff Tree-SHA512: e70b12cb31921c7527bde334f52f39776da698b6bbdb196079a8b68478c67585a5bd7bed7403f65166bd604f7ed60778c53dc064d743bb8368318a1283d1073e
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 9, 2019
91509ff bench: Benchmark blockToJSON (Kirill Fomichev) Pull request description: Related: - "getblock performance issue on verbosity" bitcoin#15925 - "refactor: Avoid UniValue copy constructor" bitcoin#15974 ACKs for top commit: laanwj: ACK 91509ff Tree-SHA512: e70b12cb31921c7527bde334f52f39776da698b6bbdb196079a8b68478c67585a5bd7bed7403f65166bd604f7ed60778c53dc064d743bb8368318a1283d1073e
| Needs rebase |
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Nov 4, 2021
91509ff bench: Benchmark blockToJSON (Kirill Fomichev) Pull request description: Related: - "getblock performance issue on verbosity" bitcoin#15925 - "refactor: Avoid UniValue copy constructor" bitcoin#15974 ACKs for top commit: laanwj: ACK 91509ff Tree-SHA512: e70b12cb31921c7527bde334f52f39776da698b6bbdb196079a8b68478c67585a5bd7bed7403f65166bd604f7ed60778c53dc064d743bb8368318a1283d1073e
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Nov 4, 2021
91509ff bench: Benchmark blockToJSON (Kirill Fomichev) Pull request description: Related: - "getblock performance issue on verbosity" bitcoin#15925 - "refactor: Avoid UniValue copy constructor" bitcoin#15974 ACKs for top commit: laanwj: ACK 91509ff Tree-SHA512: e70b12cb31921c7527bde334f52f39776da698b6bbdb196079a8b68478c67585a5bd7bed7403f65166bd604f7ed60778c53dc064d743bb8368318a1283d1073e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary
UniValuecopies. Not sure if this change is exhaustive without changingUniValueor if there is a way to detect that.A followup is to add move semantics to
UniValueand remove some unnecessary members ofUniValue.This work is related to #15925.