Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 27, 2019

@hebasto hebasto force-pushed the 20190427-align-msvc-linux branch 2 times, most recently from da443ae to 1f3aae9 Compare April 27, 2019 09:05
@fanquake fanquake added the Docs label Apr 27, 2019
@hebasto hebasto force-pushed the 20190427-align-msvc-linux branch from 1f3aae9 to e47dc4f Compare April 27, 2019 13:25
@hebasto
Copy link
Member Author

hebasto commented Apr 27, 2019

@MarcoFalke Thank you for your review. Your comments have been addressed.

@maflcko
Copy link
Member

maflcko commented Apr 27, 2019

utACK e47dc4f

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15607 ([Docs] Release process updates by jonatack)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@Sjors
Copy link
Member

Sjors commented Apr 27, 2019

utACK e47dc4f

@fanquake fanquake changed the title scripts and tools, docs: Align MSVC build options with Linux build ones docs: Align MSVC build options with Linux build ones Apr 29, 2019
@fanquake
Copy link
Member

utACK e47dc4f

@practicalswift
Copy link
Contributor

utACK e47dc4f

@maflcko maflcko merged commit e47dc4f into bitcoin:master Apr 29, 2019
maflcko pushed a commit that referenced this pull request Apr 29, 2019
e47dc4f Include bitcoin_config.h in release process (Hennadii Stepanov)
48ed65b Align MSVC build options with Linux build ones (Hennadii Stepanov)

Pull request description:

  Ref:
  - #11526
  - #15903 (comment)
  - #15903 (comment) by MarcoFalke

ACKs for commit e47dc4:
  MarcoFalke:
    utACK e47dc4f
  Sjors:
    utACK e47dc4f
  fanquake:
    utACK e47dc4f
  practicalswift:
    utACK e47dc4f

Tree-SHA512: 32ac3e9fd0b41a4916dd520bdf8bb6c71cea7218434b67a173b51b3cdb0da3f10a68b9e5205c27a52f456ac9ed14f8f8363a50d108a80a5dd55b085a6bd435b9
@hebasto hebasto deleted the 20190427-align-msvc-linux branch April 29, 2019 16:15
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 1, 2019
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Oct 7, 2021
…ones

e47dc4f Include bitcoin_config.h in release process (Hennadii Stepanov)
48ed65b Align MSVC build options with Linux build ones (Hennadii Stepanov)

Pull request description:

  Ref:
  - bitcoin#11526
  - bitcoin#15903 (comment)
  - bitcoin#15903 (comment) by MarcoFalke

ACKs for commit e47dc4:
  MarcoFalke:
    utACK e47dc4f
  Sjors:
    utACK e47dc4f
  fanquake:
    utACK e47dc4f
  practicalswift:
    utACK e47dc4f

Tree-SHA512: 32ac3e9fd0b41a4916dd520bdf8bb6c71cea7218434b67a173b51b3cdb0da3f10a68b9e5205c27a52f456ac9ed14f8f8363a50d108a80a5dd55b085a6bd435b9

# Conflicts:
#	build_msvc/bitcoin_config.h
#	doc/release-process.md
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Oct 14, 2021
…ones

e47dc4f Include bitcoin_config.h in release process (Hennadii Stepanov)
48ed65b Align MSVC build options with Linux build ones (Hennadii Stepanov)

Pull request description:

  Ref:
  - bitcoin#11526
  - bitcoin#15903 (comment)
  - bitcoin#15903 (comment) by MarcoFalke

ACKs for commit e47dc4:
  MarcoFalke:
    utACK e47dc4f
  Sjors:
    utACK e47dc4f
  fanquake:
    utACK e47dc4f
  practicalswift:
    utACK e47dc4f

Tree-SHA512: 32ac3e9fd0b41a4916dd520bdf8bb6c71cea7218434b67a173b51b3cdb0da3f10a68b9e5205c27a52f456ac9ed14f8f8363a50d108a80a5dd55b085a6bd435b9

# Conflicts:
#	build_msvc/bitcoin_config.h
#	doc/release-process.md
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants