rpc: Remove dependency on interfaces::Chain in SignTransaction #15784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. Thanks @ariard! |
a6d7634 to
442a65b
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
jnewbery
reviewed
Apr 11, 2019
src/rpc/rawtransaction_util.h
Outdated
| @@ -5,6 +5,11 @@ | |||
| #ifndef BITCOIN_RPC_RAWTRANSACTION_UTIL_H | |||
| #define BITCOIN_RPC_RAWTRANSACTION_UTIL_H | |||
|
|
|||
| #include <coins.h> | |||
There was a problem hiding this comment.
You should just be able to forward declare the Coin object and leave this include in the .cpp file if you change the coins argument into a reference.
(thanks to @ryanofsky for answering my question about this)
There was a problem hiding this comment.
Just forward declaration seems to do the job without gcc complaints
There was a problem hiding this comment.
Thanks. You should pass by reference anyway, otherwise this will make a copy of the entire map.
442a65b to
b772cce
Compare
promag
reviewed
Apr 12, 2019
b772cce to
0f4b200
Compare
|
Thanks, utACK 0f4b200 |
0f4b200 to
70da741
Compare
|
Got this on travis failure : "Please manually re-run this job by using the travis restart button or asking a bitcoin maintainer to restart. The next run should not time out because the build cache has been saved." |
70da741 to
c98aeb0
Compare
|
utACK c98aeb0 one you've removed that unnecessary |
Comment SignTransaction utility
c98aeb0 to
99e88a3
Compare
|
99e88a3 removed unnecessary interfaces::Chain forward declaration |
|
utACK 99e88a3 |
|
utACK 99e88a3. |
ryanofsky
approved these changes
Apr 17, 2019
| class CBasicKeyStore; | ||
| class UniValue; | ||
| struct CMutableTransaction; | ||
| class Coin; |
There was a problem hiding this comment.
Could sort these between CBasicKeyStore and UniValue above (I normally just pipe these lines to !sort in vim)
meshcollider
added a commit
that referenced
this pull request
Apr 27, 2019
…saction 99e88a3 rpc: Remove dependency on interfaces::Chain in SignTransaction (Antoine Riard) Pull request description: Assuming wallet RPCs and node RPCs will go into different processes, signrawtransactionwithkey doesn't need to access Coins via interfaces::Chain, it may use directly utility in node/coins.cpp Obviously will need rebase after #15638 Tree-SHA512: 42ee8fcbcd38643bbd82210db6f68249bed5ee036a4c930a1db534d0469a133e287b8869c977bf0cc79a7296dde04f72adb74d24e1cd20f4a280f4c2b7fceb74
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 27, 2019
…ignTransaction 99e88a3 rpc: Remove dependency on interfaces::Chain in SignTransaction (Antoine Riard) Pull request description: Assuming wallet RPCs and node RPCs will go into different processes, signrawtransactionwithkey doesn't need to access Coins via interfaces::Chain, it may use directly utility in node/coins.cpp Obviously will need rebase after bitcoin#15638 Tree-SHA512: 42ee8fcbcd38643bbd82210db6f68249bed5ee036a4c930a1db534d0469a133e287b8869c977bf0cc79a7296dde04f72adb74d24e1cd20f4a280f4c2b7fceb74
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 27, 2020
…ransaction Summary: Comment SignTransaction utility bitcoin/bitcoin@99e88a3 --- Depends on D6257 Backport of Core [[bitcoin/bitcoin#15784 | PR15784]] Test Plan: ninja check check-functional Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6258
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Dec 7, 2021
…ignTransaction 99e88a3 rpc: Remove dependency on interfaces::Chain in SignTransaction (Antoine Riard) Pull request description: Assuming wallet RPCs and node RPCs will go into different processes, signrawtransactionwithkey doesn't need to access Coins via interfaces::Chain, it may use directly utility in node/coins.cpp Obviously will need rebase after bitcoin#15638 Tree-SHA512: 42ee8fcbcd38643bbd82210db6f68249bed5ee036a4c930a1db534d0469a133e287b8869c977bf0cc79a7296dde04f72adb74d24e1cd20f4a280f4c2b7fceb74
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Dec 11, 2021
…ignTransaction 99e88a3 rpc: Remove dependency on interfaces::Chain in SignTransaction (Antoine Riard) Pull request description: Assuming wallet RPCs and node RPCs will go into different processes, signrawtransactionwithkey doesn't need to access Coins via interfaces::Chain, it may use directly utility in node/coins.cpp Obviously will need rebase after bitcoin#15638 Tree-SHA512: 42ee8fcbcd38643bbd82210db6f68249bed5ee036a4c930a1db534d0469a133e287b8869c977bf0cc79a7296dde04f72adb74d24e1cd20f4a280f4c2b7fceb74
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Dec 13, 2021
…ignTransaction 99e88a3 rpc: Remove dependency on interfaces::Chain in SignTransaction (Antoine Riard) Pull request description: Assuming wallet RPCs and node RPCs will go into different processes, signrawtransactionwithkey doesn't need to access Coins via interfaces::Chain, it may use directly utility in node/coins.cpp Obviously will need rebase after bitcoin#15638 Tree-SHA512: 42ee8fcbcd38643bbd82210db6f68249bed5ee036a4c930a1db534d0469a133e287b8869c977bf0cc79a7296dde04f72adb74d24e1cd20f4a280f4c2b7fceb74
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Dec 14, 2021
…ignTransaction 99e88a3 rpc: Remove dependency on interfaces::Chain in SignTransaction (Antoine Riard) Pull request description: Assuming wallet RPCs and node RPCs will go into different processes, signrawtransactionwithkey doesn't need to access Coins via interfaces::Chain, it may use directly utility in node/coins.cpp Obviously will need rebase after bitcoin#15638 Tree-SHA512: 42ee8fcbcd38643bbd82210db6f68249bed5ee036a4c930a1db534d0469a133e287b8869c977bf0cc79a7296dde04f72adb74d24e1cd20f4a280f4c2b7fceb74
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming wallet RPCs and node RPCs will go into different processes, signrawtransactionwithkey doesn't need to access Coins via interfaces::Chain, it may use directly utility in node/coins.cpp
Obviously will need rebase after #15638