qa: Add further tests to wallet_balance #15758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa61f27 to
fabc1c6
Compare
promag
reviewed
Apr 7, 2019
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Unless there are objections, this will be merged tomorrow |
jnewbery
reviewed
Apr 30, 2019
fa8d8eb to
fa79a78
Compare
|
utACK fa79a78 |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 1, 2019
fa79a78 test: Add reorg test to wallet_balance (MarcoFalke) fad03cd test: Check that wallet txs not in the mempool are untrusted (MarcoFalke) fa19531 test: Add getunconfirmedbalance test with conflicts (MarcoFalke) fa464e8 test: Add wallet_balance test for watchonly (MarcoFalke) Pull request description: Second commit can be reviewed with `--ignore-all-space` ACKs for commit fa79a7: jnewbery: utACK fa79a78 Tree-SHA512: ec4919a3c93b6dcb35d58e7c65bdffe7f4c8cb87b9287f3679631c1823ef5bd72789f233def94e60c1ab332711601751645566f5997ce250af55b328ed60e917
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Aug 23, 2019
Github-Pull: bitcoin#15758 Rebased-From: fad03cd
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Aug 23, 2019
Github-Pull: bitcoin#15758 Rebased-From: fa79a78
Merged
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 9, 2020
Summary: bitcoin/bitcoin@fa464e8 --- Partial backport of Core [[bitcoin/bitcoin#15758 | PR15758]] Test Plan: ./test/functional/test_runner.py wallet_balance Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6440
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 9, 2020
Summary: bitcoin/bitcoin@fa19531 --- Depends on D6440 Partial backport of Core [[bitcoin/bitcoin#15758 | PR15758]] Test Plan: test_runner.py wallet_balance Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6441
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 9, 2020
…ntrusted Summary: bitcoin/bitcoin@fad03cd --- Depends on D6441 Partial backport of Core [[bitcoin/bitcoin#15758 | PR15758]] Test Plan: test_runner.py wallet_balance Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6442
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 9, 2020
Summary: bitcoin/bitcoin@fa79a78 --- Depends on D6442 Concludes backport of Core [[bitcoin/bitcoin#15758 | PR15758]] Test Plan: test_runner.py wallet_balance Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6443
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second commit can be reviewed with
--ignore-all-space