build: Drop macports support #15175

Empact · 2019-01-16T09:09:59Z

It's unmaintained, according to @theuni.
https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938

Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration.

laanwj · 2019-01-16T10:20:19Z

Concept ACK.
If it's unmaintained it should be removed, simple as that.
Unless someone cares enough and promises to pick this up.

DrahtBot · 2019-01-16T11:10:33Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#15112 (build: Optionally enable -Wzero-as-null-pointer-constant by Empact)
#14920 (Build: enable -Wdocumentation via isystem by Empact)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

fanquake · 2019-01-16T11:34:38Z

Concept ACK. Doing this has been mentioned many times. Macports instructions were dropped from the macOS build readme in #4939 (>4 years ago, discussion in #4917), and I don't think anyone has complained/asked to have them re-added.

practicalswift · 2019-01-16T15:52:33Z

Concept ACK

Unsupported stuff should go.

promag · 2019-01-16T16:06:22Z

Concept ACK and change LGTM.

laanwj · 2019-01-16T17:08:12Z

"AppVeyor was unable to build non-mergeable pull request " huh

It's untested / unmaintained, according to theuni. https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938

Empact · 2019-01-16T23:21:36Z

"AppVeyor was unable to build non-mergeable pull request " huh

Rebasing cleared this up.

jonasschnelli · 2019-01-17T03:09:27Z

Tested ACK 4e81438

Empact · 2019-01-17T03:18:37Z

This also removes the last remaining references to qt4 :P

DrahtBot · 2019-01-17T11:15:45Z

Gitian builds for commit fcb6694 (master):

909d779c082ec7060dc990147ebcb37c... bitcoin-0.17.99-aarch64-linux-gnu-debug.tar.gz
f376495125fd64250668df4472b9964b... bitcoin-0.17.99-aarch64-linux-gnu.tar.gz
3ab6ca37ac8b6142622d42f03c0d2a2f... bitcoin-0.17.99-arm-linux-gnueabihf-debug.tar.gz
cb61bc7b230ca04dc1bf951e1f1081ac... bitcoin-0.17.99-arm-linux-gnueabihf.tar.gz
a8257a51a147152fe368a1725c19b552... bitcoin-0.17.99-i686-pc-linux-gnu-debug.tar.gz
8b0cd34337eab5b76988babbe9715c50... bitcoin-0.17.99-i686-pc-linux-gnu.tar.gz
e092d72016c42a7879d59bd3bc3bc727... bitcoin-0.17.99-osx-unsigned.dmg
25b58579ff4e4e276ba00ce0d6e7c0fc... bitcoin-0.17.99-osx64.tar.gz
c5f1bd5ad50c865a3860df389390bac4... bitcoin-0.17.99-riscv64-linux-gnu-debug.tar.gz
f8fd95318c449f901427c39f2243e81b... bitcoin-0.17.99-riscv64-linux-gnu.tar.gz
7f352a40d833f68cce7ba3e993d5aba6... bitcoin-0.17.99-win32-debug.zip
e7382047aa925ed655adbbb07c82de08... bitcoin-0.17.99-win32-setup-unsigned.exe
9b3f8796792744afc699fc9f5224964b... bitcoin-0.17.99-win32.zip
70f1699aa486b2afd8120f699967cad2... bitcoin-0.17.99-win64-debug.zip
77213bf7c7533a17979697ec37d23e2c... bitcoin-0.17.99-win64-setup-unsigned.exe
b51427cc782509917e05fe410a86a6ce... bitcoin-0.17.99-win64.zip
b9e91996d739d40392e5bb9b7301a026... bitcoin-0.17.99-x86_64-linux-gnu-debug.tar.gz
e104fc4d0ba3168877b6745bae4f6d5e... bitcoin-0.17.99-x86_64-linux-gnu.tar.gz
35cd5fc10f2d1ff1adcc6626ff3f1be2... bitcoin-0.17.99.tar.gz
88de4ebe50fc7c105f5b4d7147f13ce1... bitcoin-linux-0.18-res.yml
4b57d6b0edbe862d6500850318dfcb85... bitcoin-linux-build.log
c62af5f0a856df0709a166c02d4c9450... bitcoin-osx-0.18-res.yml
c83e68255d66ca429289c47a72ef9c69... bitcoin-osx-build.log
bcde4c961b6a6eb49e72f5d2285508fb... bitcoin-win-0.18-res.yml
9f0f6b7ec0a2b02b6ee1e42a530a2a52... bitcoin-win-build.log

Gitian builds for commit 823929563fbd52b8c9aca6af2d479c8ca183f51a (master and this pull):

39ed634eb3e8fbeb5119ea36ae58d7a4... bitcoin-0.17.99-aarch64-linux-gnu-debug.tar.gz
3dd0511d0ca8c264251be73ad9177311... bitcoin-0.17.99-aarch64-linux-gnu.tar.gz
08cf8ac955fee3e0d83b22739cb73d31... bitcoin-0.17.99-arm-linux-gnueabihf-debug.tar.gz
e9ac7901618b2ee8545b2c630bf260f1... bitcoin-0.17.99-arm-linux-gnueabihf.tar.gz
6aafc4ce7d06a10f9ad7a5bf86bb486d... bitcoin-0.17.99-i686-pc-linux-gnu-debug.tar.gz
8cbac3b74cb226db138f55a58e11248a... bitcoin-0.17.99-i686-pc-linux-gnu.tar.gz
7d773f5837f6735b827bbca24693ccdf... bitcoin-0.17.99-osx-unsigned.dmg
9cb7384c3728b403e4cbc659d9e9e91f... bitcoin-0.17.99-osx64.tar.gz
4a187ecadaf385430a4449e1322a18da... bitcoin-0.17.99-riscv64-linux-gnu-debug.tar.gz
02dd64e4d5ed59291270b683f8fd645b... bitcoin-0.17.99-riscv64-linux-gnu.tar.gz
40ca79d12c92ea1d2c3bacf45a31983e... bitcoin-0.17.99-win32-debug.zip
aa633cea94e763e60cde5722430aa5b5... bitcoin-0.17.99-win32-setup-unsigned.exe
d85d3b0af483d1d8175d5b745cad7e38... bitcoin-0.17.99-win32.zip
c464daac54d65cd8124b15e67f0eab30... bitcoin-0.17.99-win64-debug.zip
7fe20dfa95b9f54fdcacf13efbf52e51... bitcoin-0.17.99-win64-setup-unsigned.exe
95692e3aa30536eb9569d9cfd3b19cd8... bitcoin-0.17.99-win64.zip
741d3d6b656aad952bb78614cd6b742b... bitcoin-0.17.99-x86_64-linux-gnu-debug.tar.gz
f80587e5f7422b9d71367fb583ac93d4... bitcoin-0.17.99-x86_64-linux-gnu.tar.gz
e5d7dcc57583cbb41d346a41e321a4df... bitcoin-0.17.99.tar.gz
c46ef23c045b05c9037d63319121b465... bitcoin-linux-0.18-res.yml
72c5ae5e70bf42c2f6d69ecb88415af1... bitcoin-linux-build.log
115cfd5f668abf4e075347cb57ad3d3d... bitcoin-osx-0.18-res.yml
5cb4535a415e91dca94d110825d1b598... bitcoin-osx-build.log
f9260761089dd8197e7985ce45c8a5ae... bitcoin-win-0.18-res.yml
2ac6875c6c360798a1cd29ee1f57634c... bitcoin-win-build.log

IlyasRidhuan · 2019-01-18T05:42:51Z

utAck

fanquake · 2019-01-18T05:43:33Z

utACK 4e81438

theuni · 2019-01-18T22:37:26Z

utACK 4e81438. Thanks!

@theuni

4e81438 build: Drop macports support (Ben Woosley) Pull request description: It's unmaintained, according to @theuni. https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938 Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration. Tree-SHA512: 65f8bf2bd5351f0907c25fad781a692b4cdcfc9a8b7d8e32329f53e3be64b06f9eb1b74339cfc4be6b80584f4d2bda340d70168013fcf048236267e8e2ccbf27

rex4539 · 2019-01-19T08:08:46Z

For the poor soul that may come here in the future, trying to compile using MacPorts.

Add the following to your Bash .profile:

export BDB_CFLAGS=/opt/local/include/db48/
export CPPFLAGS="$CPPFLAGS -isystem /opt/local/include"
export LIBS="$LIBS -L/opt/local/lib"
export CPPFLAGS="$CPPFLAGS -I/opt/local/include/db48"
export LIBS="$LIBS -L/opt/local/lib/db48"

Restart your shell.

Bitcoin Core will now compile.

Summary: ``` It's untested / unmaintained, according to theuni. https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938 ``` Clearly unused by ABC. Backport of core [[bitcoin/bitcoin#15175 | PR15175]]. Test Plan: ninja osx-dmg Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7968

a68c7d5 depends: mac_alias 2.2.0 (fanquake) d8e2baf doc: Add explicit macdeployqtplus dependencies install step (Hennadii Stepanov) 013305d macdeploy: use Python 3.6 (fanquake) faf77c3 macdeploy: remove runHDIUtil in favor of directly calling subprocess.run (fanquake) 8bcfd58 macdeploy: remove existing PIVX-Core.dmg if present (fanquake) 023d3ca macdeploy: move qt_conf to where it's used (fanquake) 7cdb5bb macdeploy: consolidate .DS_Store generation (fanquake) 4da04d7 macdeploy: assume plistlib is available (fanquake) 56ab77a macdeploy: have a single level of logging output (fanquake) d111cdf macdeploy: remove add-resources argument (fanquake) 4312410 macdeploy: remove codesigning argument (fanquake) c2ee635 build: automatically determine macOS translations (fanquake) 1c44ecf scripts: filter more qt plugins we don't use in macdeployqtplus (fanquake) c854f78 scripts: misc cleanups in macdeployqtplus (fanquake) a3873ea scripts: use format() in macdeployqtplus (fanquake) a65bea5 scripts: add type annotations to macdeployqtplus (fanquake) ba179e5 build: Drop macports support (Ben Woosley) Pull request description: This is a companion to PIVX-Project#2272 that focuses on on the `.dmg` creation aspect of macOS builds (ie, `make deploy`). The following upstream PRs are backported here: - bitcoin#15175 - bitcoin#16477 - bitcoin#20422 - bitcoin#20890 - bitcoin#21658 Also worth mentioning: This drops support for MacPorts entirely, which has been antiquated and un-maintained for quite some time, and never actually used by any PIVX macOS build doc. ACKs for top commit: furszy: Tested using depends, ACK a68c7d5. random-zebra: utACK a68c7d5 and merging... Tree-SHA512: 3e9fa81a905ca3e90f07ff1213ec69dd1220a19a6a215f256ab67f2594476dc95e8fe88f15a1c9f3314b1757a7a2e5d8e6d7a790d85c117bf4236a3833757430

@theuni

4e81438 build: Drop macports support (Ben Woosley) Pull request description: It's unmaintained, according to @theuni. https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938 Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration. Tree-SHA512: 65f8bf2bd5351f0907c25fad781a692b4cdcfc9a8b7d8e32329f53e3be64b06f9eb1b74339cfc4be6b80584f4d2bda340d70168013fcf048236267e8e2ccbf27

@theuni

4e81438 build: Drop macports support (Ben Woosley) Pull request description: It's unmaintained, according to @theuni. https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938 Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration. Tree-SHA512: 65f8bf2bd5351f0907c25fad781a692b4cdcfc9a8b7d8e32329f53e3be64b06f9eb1b74339cfc4be6b80584f4d2bda340d70168013fcf048236267e8e2ccbf27

@theuni

4e81438 build: Drop macports support (Ben Woosley) Pull request description: It's unmaintained, according to @theuni. https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938 Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration. Tree-SHA512: 65f8bf2bd5351f0907c25fad781a692b4cdcfc9a8b7d8e32329f53e3be64b06f9eb1b74339cfc4be6b80584f4d2bda340d70168013fcf048236267e8e2ccbf27

@theuni

4e81438 build: Drop macports support (Ben Woosley) Pull request description: It's unmaintained, according to @theuni. https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938 Alternative is to put it under CI. I don't have a strong opinion on this, opened for separate consideration. Tree-SHA512: 65f8bf2bd5351f0907c25fad781a692b4cdcfc9a8b7d8e32329f53e3be64b06f9eb1b74339cfc4be6b80584f4d2bda340d70168013fcf048236267e8e2ccbf27

This should have been a part of dropping macports support in bitcoin#15175.

05cdceb build: don't set PORT=no in config.site (fanquake) Pull request description: This should have been a part of dropping macports support in #15175. ACKs for top commit: hebasto: ACK 05cdceb, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 278b2f308e55aad5524530e654ac08462714676b71e01d31e5f152f69e02f916afc553510ac8352ed0bb0184f7fdb2ee7038ab5ac2de6923f366829859e0b6ee

05cdceb build: don't set PORT=no in config.site (fanquake) Pull request description: This should have been a part of dropping macports support in bitcoin#15175. ACKs for top commit: hebasto: ACK 05cdceb, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 278b2f308e55aad5524530e654ac08462714676b71e01d31e5f152f69e02f916afc553510ac8352ed0bb0184f7fdb2ee7038ab5ac2de6923f366829859e0b6ee

Empact mentioned this pull request Jan 16, 2019

Build: enable -Wdocumentation via isystem #14920

Closed

fanquake added the Build system label Jan 16, 2019

maflcko added the Needs gitian build label Jan 16, 2019

maflcko added this to the 0.18.0 milestone Jan 16, 2019

build: Drop macports support

4e81438

It's untested / unmaintained, according to theuni. https://github.com/bitcoin/bitcoin/pull/14920/files#r246964938

Empact force-pushed the drop-macports branch from 8e0e9af to 4e81438 Compare January 16, 2019 20:14

DrahtBot removed the Needs gitian build label Jan 17, 2019

jonasschnelli merged commit 4e81438 into bitcoin:master Jan 19, 2019

Empact deleted the drop-macports branch January 19, 2019 13:23

Empact mentioned this pull request Jan 20, 2019

build: Optionally enable -Wzero-as-null-pointer-constant #15112

Closed

Fuzzbawls mentioned this pull request May 25, 2021

[Build] [Depends] Unify macOS deploy target PIVX-Project/PIVX#2400

Merged

lyricidal mentioned this pull request Nov 1, 2021

[Upstream] [Build] [Depends] Unify macOS deploy target PRCYCoin/PRCYCoin#138

Merged

fanquake added a commit to fanquake/bitcoin that referenced this pull request Nov 25, 2021

build: don't set PORT=no in config.site

05cdceb

This should have been a part of dropping macports support in bitcoin#15175.

fanquake mentioned this pull request Nov 25, 2021

build: don't set PORT=no in config.site #23594

Closed

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build: Drop macports support #15175

build: Drop macports support #15175

Uh oh!

Empact commented Jan 16, 2019 •

edited

Loading

Uh oh!

laanwj commented Jan 16, 2019

Uh oh!

DrahtBot commented Jan 16, 2019

Uh oh!

fanquake commented Jan 16, 2019

Uh oh!

practicalswift commented Jan 16, 2019 •

edited

Loading

Uh oh!

promag commented Jan 16, 2019

Uh oh!

laanwj commented Jan 16, 2019

Uh oh!

Empact commented Jan 16, 2019

Uh oh!

jonasschnelli commented Jan 17, 2019

Uh oh!

Empact commented Jan 17, 2019

Uh oh!

DrahtBot commented Jan 17, 2019

Uh oh!

IlyasRidhuan commented Jan 18, 2019

Uh oh!

fanquake commented Jan 18, 2019

Uh oh!

theuni commented Jan 18, 2019

Uh oh!

rex4539 commented Jan 19, 2019 •

edited

Loading

Uh oh!

Uh oh!

build: Drop macports support #15175

build: Drop macports support #15175

Uh oh!

Conversation

Empact commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Jan 16, 2019

Uh oh!

DrahtBot commented Jan 16, 2019

Conflicts

Uh oh!

fanquake commented Jan 16, 2019

Uh oh!

practicalswift commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

promag commented Jan 16, 2019

Uh oh!

laanwj commented Jan 16, 2019

Uh oh!

Empact commented Jan 16, 2019

Uh oh!

jonasschnelli commented Jan 17, 2019

Uh oh!

Empact commented Jan 17, 2019

Uh oh!

DrahtBot commented Jan 17, 2019

Uh oh!

IlyasRidhuan commented Jan 18, 2019

Uh oh!

fanquake commented Jan 18, 2019

Uh oh!

theuni commented Jan 18, 2019

Uh oh!

rex4539 commented Jan 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Empact commented Jan 16, 2019 •

edited

Loading

practicalswift commented Jan 16, 2019 •

edited

Loading

rex4539 commented Jan 19, 2019 •

edited

Loading