tests: Fix cuckoocache_tests TSAN failure introduced in 14935. #14969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipa
reviewed
Dec 15, 2018
|
Could use assert instead |
|
@sipa @ken2812221 Updated. Please re-review :-) |
|
utACK (but squash please) |
93592c1 to
d98a29e
Compare
|
@laanwj Squashed! :-) |
|
utACK d98a29e |
|
utACK d98a29e |
laanwj
added a commit
that referenced
this pull request
Dec 16, 2018
… 14935. d98a29e Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967. (practicalswift) Pull request description: Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967. Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 22, 2020
…functions returning a success code Summary: c84c2b8c92 tests: Test for expected return values when calling functions returning a success code (practicalswift) Pull request description: Test for expected return values when calling functions returning a success code (instead of discarding the return values). **Note to reviewers:** The following commands can be used to verify that the only text fragments added in this PR are `BOOST_CHECK(`, `!` and `)` : ``` $ git diff HEAD~1 | grep -E '^[\-][^\-]' | cut -b2- > before.txt $ git diff HEAD~1 | grep -E '^[\+][^\+]' | cut -b2- > after.txt $ cat after.txt | sed 's/BOOST_CHECK(//g' | sed 's/));/);/g' | tr -d '!' > after-sed.txt $ diff -u before.txt after-sed.txt $ ``` --- Backport of Core [[bitcoin/bitcoin#14935 | PR14935]] and [[bitcoin/bitcoin#14969 | PR14969]] Test Plan: ninja check Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D6663
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Sep 24, 2021
…uced in 14935. d98a29e Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. (practicalswift) Pull request description: Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Sep 24, 2021
…uced in 14935. d98a29e Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. (practicalswift) Pull request description: Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Sep 24, 2021
…uced in 14935. d98a29e Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. (practicalswift) Pull request description: Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Sep 27, 2021
…uced in 14935. d98a29e Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. (practicalswift) Pull request description: Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
dzutto
pushed a commit
to dzutto/dash
that referenced
this pull request
Sep 30, 2021
…uced in 14935. d98a29e Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. (practicalswift) Pull request description: Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Oct 1, 2021
…94_14969 Merge 0.18 PRs: bitcoin#14268, bitcoin#15408, bitcoin#14094, bitcoin#14935 and bitcoin#14969
kwvg
pushed a commit
to kwvg/dash
that referenced
this pull request
Oct 12, 2021
…uced in 14935. d98a29e Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. (practicalswift) Pull request description: Fix cuckoocache_tests TSAN failure introduced in bitcoin#14935. Fixes bitcoin#14967. Tree-SHA512: aabbfa3ab41d9f498151a9b50a2a875fd51ed609bb54d89292114f59392aae57c85fdd5b7a04b589fbf598aaf736b425a6f62b12c806a1fa23bdd45d2d2accfb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cuckoocache_tests TSAN failure introduced in #14935. Fixes #14967.