Skip to content

qt: Bump the minimum Qt version to 5.2 #14725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2018
Merged

qt: Bump the minimum Qt version to 5.2 #14725

merged 1 commit into from
Nov 14, 2018

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Nov 13, 2018

@maflcko maflcko added this to the 0.18.0 milestone Nov 13, 2018
@promag
Copy link
Contributor

promag commented Nov 14, 2018

utACK 2bc3f11.

@laanwj
Copy link
Member

laanwj commented Nov 14, 2018

utACK 2bc3f11

@fanquake
Copy link
Member

utACK 2bc3f11
master already requires > qt 5.2, this'll need some release notes once we settle on a minimum qt for 0.18.0.

@laanwj laanwj merged commit 2bc3f11 into bitcoin:master Nov 14, 2018
laanwj added a commit that referenced this pull request Nov 14, 2018
@laanwj
Merge #14725: qt: Bump the minimum Qt version to 5.2
74213fa 
2bc3f11 Bump the minimum Qt version to 5.2 (Hennadii Stepanov)

Pull request description:

  Refs:
  - #13478
  - #13478 (comment) by @MarcoFalke

Tree-SHA512: b598a80f25df9c440e0776b373b88a305250582049ab60caee48375f6599c2f6d40ed94b488ff3604ec9fc12c71f440f6881a3fc656c81f99e89dc5bf9ea2f6d
@hebasto hebasto deleted the 20181113-bump-qt52 branch November 15, 2018 10:56
@fanquake fanquake mentioned this pull request Dec 10, 2018
Merged
laanwj added a commit that referenced this pull request Dec 12, 2018
@laanwj
Merge #14909: doc: Update minimum required Qt
96bde4f 
b7bee6a doc: Update minimum required qt (fanquake)

Pull request description:

  After #14725 the minimum required version of Qt is 5.2.

Tree-SHA512: 130c69ed6810723ac86eb7a341e5a985af73186d47cb2bce3e5f239991157cfd44bb28903f59e33dc2ebe3d628d21b6864ad6c8223218aae287d0cde7506dc7f
@fanquake fanquake mentioned this pull request Dec 12, 2018
Closed
@hebasto hebasto mentioned this pull request Dec 16, 2018
Merged
jonasschnelli added a commit that referenced this pull request Dec 18, 2018
@jonasschnelli
Merge #14975: qt: Refactoring with QString::toNSString()
e7b88ec 
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
@fanquake fanquake mentioned this pull request Feb 11, 2019
Closed
10xcryptodev pushed a commit to 10xcryptodev/dash that referenced this pull request May 14, 2020
@laanwj @10xcryptodev
Merge bitcoin#14725: qt: Bump the minimum Qt version to 5.2
4c82a08 
2bc3f11 Bump the minimum Qt version to 5.2 (Hennadii Stepanov)

Pull request description:

  Refs:
  - bitcoin#13478
  - bitcoin#13478 (comment) by @MarcoFalke

Tree-SHA512: b598a80f25df9c440e0776b373b88a305250582049ab60caee48375f6599c2f6d40ed94b488ff3604ec9fc12c71f440f6881a3fc656c81f99e89dc5bf9ea2f6d
(cherry picked from commit 74213fa)

# Conflicts:
#	build-aux/m4/bitcoin_qt.m4
#	src/qt/dash.cpp
#	src/qt/guiutil.cpp
#	src/qt/splashscreen.cpp
10xcryptodev pushed a commit to 10xcryptodev/dash that referenced this pull request May 15, 2020
@laanwj @10xcryptodev
Merge bitcoin#14725: qt: Bump the minimum Qt version to 5.2
6ed2e97 
2bc3f11 Bump the minimum Qt version to 5.2 (Hennadii Stepanov)

Pull request description:

  Refs:
  - bitcoin#13478
  - bitcoin#13478 (comment) by @MarcoFalke

Tree-SHA512: b598a80f25df9c440e0776b373b88a305250582049ab60caee48375f6599c2f6d40ed94b488ff3604ec9fc12c71f440f6881a3fc656c81f99e89dc5bf9ea2f6d
(cherry picked from commit 74213fa)

# Conflicts:
#	build-aux/m4/bitcoin_qt.m4
#	src/qt/dash.cpp
#	src/qt/guiutil.cpp
#	src/qt/splashscreen.cpp
10xcryptodev pushed a commit to 10xcryptodev/dash that referenced this pull request May 17, 2020
@laanwj @10xcryptodev
Merge bitcoin#14725: qt: Bump the minimum Qt version to 5.2
6104992 
2bc3f11 Bump the minimum Qt version to 5.2 (Hennadii Stepanov)

Pull request description:

  Refs:
  - bitcoin#13478
  - bitcoin#13478 (comment) by @MarcoFalke

Tree-SHA512: b598a80f25df9c440e0776b373b88a305250582049ab60caee48375f6599c2f6d40ed94b488ff3604ec9fc12c71f440f6881a3fc656c81f99e89dc5bf9ea2f6d
(cherry picked from commit 74213fa)

# Conflicts:
#	build-aux/m4/bitcoin_qt.m4
#	src/qt/dash.cpp
#	src/qt/guiutil.cpp
#	src/qt/splashscreen.cpp
10xcryptodev pushed a commit to 10xcryptodev/dash that referenced this pull request May 20, 2020
@laanwj @10xcryptodev
Merge bitcoin#14725: qt: Bump the minimum Qt version to 5.2
51d3507 
2bc3f11 Bump the minimum Qt version to 5.2 (Hennadii Stepanov)

Pull request description:

  Refs:
  - bitcoin#13478
  - bitcoin#13478 (comment) by @MarcoFalke

Tree-SHA512: b598a80f25df9c440e0776b373b88a305250582049ab60caee48375f6599c2f6d40ed94b488ff3604ec9fc12c71f440f6881a3fc656c81f99e89dc5bf9ea2f6d
(cherry picked from commit 74213fa)

# Conflicts:
#	build-aux/m4/bitcoin_qt.m4
#	src/qt/dash.cpp
#	src/qt/guiutil.cpp
#	src/qt/splashscreen.cpp
10xcryptodev pushed a commit to 10xcryptodev/dash that referenced this pull request Jun 12, 2020
@laanwj @10xcryptodev
Merge bitcoin#14725: qt: Bump the minimum Qt version to 5.2
5debbf3 
2bc3f11 Bump the minimum Qt version to 5.2 (Hennadii Stepanov)

Pull request description:

  Refs:
  - bitcoin#13478
  - bitcoin#13478 (comment) by @MarcoFalke

Tree-SHA512: b598a80f25df9c440e0776b373b88a305250582049ab60caee48375f6599c2f6d40ed94b488ff3604ec9fc12c71f440f6881a3fc656c81f99e89dc5bf9ea2f6d
(cherry picked from commit 74213fa)

# Conflicts:
#	build-aux/m4/bitcoin_qt.m4
#	src/qt/dash.cpp
#	src/qt/guiutil.cpp
#	src/qt/splashscreen.cpp
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jun 15, 2020
@hebasto @Fabcien
Cleanup Qt branches on old unsupported version
5e39715 
Summary:
This cleans the remaining `#ifdef` on older Qt versions. We are
currently requiring 5.5.1 as a minimum.

Backport of core [[bitcoin/bitcoin#14725 | PR14725]].

Test Plan:
  ninja all check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6569
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jun 27, 2021
@laanwj @gades
Merge bitcoin#14725: qt: Bump the minimum Qt version to 5.2
2667681 
2bc3f11 Bump the minimum Qt version to 5.2 (Hennadii Stepanov)

Pull request description:

  Refs:
  - bitcoin#13478
  - bitcoin#13478 (comment) by @MarcoFalke

Tree-SHA512: b598a80f25df9c440e0776b373b88a305250582049ab60caee48375f6599c2f6d40ed94b488ff3604ec9fc12c71f440f6881a3fc656c81f99e89dc5bf9ea2f6d
(cherry picked from commit 74213fa)
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@jonasschnelli @PastaPastaPasta
Merge bitcoin#14975: qt: Refactoring with QString::toNSString()
ec5fb2d 
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@jonasschnelli @PastaPastaPasta
Merge bitcoin#14975: qt: Refactoring with QString::toNSString()
c79f2a2 
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@jonasschnelli @PastaPastaPasta
Merge bitcoin#14975: qt: Refactoring with QString::toNSString()
7df0673 
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@jonasschnelli @PastaPastaPasta
Merge bitcoin#14975: qt: Refactoring with QString::toNSString()
9f292ab 
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@jonasschnelli @PastaPastaPasta
Merge bitcoin#14975: qt: Refactoring with QString::toNSString()
4b78ad8 
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@jonasschnelli @PastaPastaPasta
Merge bitcoin#14975: qt: Refactoring with QString::toNSString()
7986942 
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Jul 5, 2021
@jonasschnelli @UdjinM6
Merge bitcoin#14975: qt: Refactoring with QString::toNSString()
7fff85f 
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 8, 2021
@jonasschnelli @PastaPastaPasta
Merge bitcoin#14975: qt: Refactoring with QString::toNSString()
fba2ab5 
4d454dc Refactoring with QString::toNSString (Hennadii Stepanov)

Pull request description:

  This PR makes `MacNotificationHandler::showNotification()` cleaner and more readable.
  The used `QString::toNSString()` function was introduced in Qt 5.2 which is minimum version now (bitcoin#14725).

  The behavior of `MacNotificationHandler::showNotification()` has not been changed.

  cc: @jonasschnelli

Tree-SHA512: 940327a77746ee016415efd3b696ad8ec85dcf12bf3f62e55c9bdc1700415d81a8d03fbc79310982d37a4098786dcaef7cd9702db5498d59d8065447babc27f5
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Build system GUI
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hebasto @promag @laanwj @fanquake @maflcko