qa: Add test to ensure node can generate all rpc help texts at runtime #14658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. Coverage
Updated at: 2018-11-05T19:01:46.454312. |
faae854 to
bbbbb3f
Compare
promag
reviewed
Nov 5, 2018
| for call in calls: | ||
| with open(os.path.join(dump_dir, call), 'w', encoding='utf-8') as f: | ||
| # Make sure the node can generate the help at runtime without crashing | ||
| f.write(self.nodes[0].help(call)) |
There was a problem hiding this comment.
There is no downside in logging the results to the temp dir. It'd make it easier to debug in case the node crashed while in the loop. Also, you could pass --nocleanup for manual inspection, etc...
There was a problem hiding this comment.
@MarcoFalke thanks, all good points.
|
utACK bbbbb3f. |
|
Good to have. A bug where generating the help crashes would not be critical but would be very embarrassing, good to check for that (especially as some help refactors are on the horizon). |
laanwj
added a commit
that referenced
this pull request
Nov 6, 2018
…exts at runtime bbbbb3f qa: Add test to ensure node can generate all help texts at runtime (MarcoFalke) Pull request description: This might increase coverage, but more importantly this checks that the node doesn't crash when generating the help. (Right now the help is a static string, but in the future it might be generated at runtime) Tree-SHA512: 0226e7c65f8a1a6fdc96c07dcf491d90559bc2355c92e9da9b1f174b09733fc349269e71da6d792f954de563a1e57c848471813eabae1a40b849a0d989520a0d
|
nice |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Nov 28, 2018
Github-Pull: bitcoin#14658 Rebased-From: bbbbb3f
dartdart26
added a commit
to projectpai/paicoin
that referenced
this pull request
Nov 30, 2018
qa: Add test to ensure node can generate all rpc help texts at runtime
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 24, 2020
…exts at runtime Summary: bbbbb3f8850907d413db4715c10ef6df055234f6 qa: Add test to ensure node can generate all help texts at runtime (MarcoFalke) Pull request description: This might increase coverage, but more importantly this checks that the node doesn't crash when generating the help. (Right now the help is a static string, but in the future it might be generated at runtime) Tree-SHA512: 0226e7c65f8a1a6fdc96c07dcf491d90559bc2355c92e9da9b1f174b09733fc349269e71da6d792f954de563a1e57c848471813eabae1a40b849a0d989520a0d Backport of Core [[bitcoin/bitcoin#14658 | PR14658]] Test Plan: `test_runner.py rpc_help` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D6709
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 17, 2020
…exts at runtime Summary: bbbbb3f8850907d413db4715c10ef6df055234f6 qa: Add test to ensure node can generate all help texts at runtime (MarcoFalke) Pull request description: This might increase coverage, but more importantly this checks that the node doesn't crash when generating the help. (Right now the help is a static string, but in the future it might be generated at runtime) Tree-SHA512: 0226e7c65f8a1a6fdc96c07dcf491d90559bc2355c92e9da9b1f174b09733fc349269e71da6d792f954de563a1e57c848471813eabae1a40b849a0d989520a0d Backport of Core [[bitcoin/bitcoin#14658 | PR14658]] Test Plan: `test_runner.py rpc_help` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D6709
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might increase coverage, but more importantly this checks that the node doesn't crash when generating the help. (Right now the help is a static string, but in the future it might be generated at runtime)