Remove ENABLE_WALLET from libbitcoin_server.a #14168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the ifdef ENABLE_WALLET from init.cpp.
14 tasks
|
Strong Concept ACK |
0e7395d to
9a2b3d2
Compare
ghost
approved these changes
Sep 7, 2018
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Yayyyy, good to see this finally happen |
|
utACK 9a2b3d2 - looks much cleaner 👍 |
|
utACK 9a2b3d2 |
maflcko
reviewed
Sep 9, 2018
src/wallet/init.cpp
Outdated
| @@ -19,6 +19,9 @@ | |||
| class WalletInit : public WalletInitInterface { | |||
| public: | |||
|
|
|||
| //! Is the wallet component enabled | |||
| bool IsWalletEnabled() const override {return true;} | |||
There was a problem hiding this comment.
Should say IsWalletCompiled() or similar?
There was a problem hiding this comment.
My suggestion HasWalletSupport().
There was a problem hiding this comment.
Changed to HasWalletSupport()
9a2b3d2 to
7d038dc
Compare
|
Renamed function as suggested here: #14168 (comment) |
|
utACK 7d038dc |
|
utACK 7d038dc |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Sep 11, 2018
7d038dc [build] remove ENABLE_WALLET ifdef from httprpc.cpp (John Newbery) 3076556 [build] Move dummy wallet into its own .cpp file. (John Newbery) Pull request description: This removes the final instances of ENABLE_WALLET in libbitcoin_server and so completes bitcoin#7965. Tree-SHA512: a49128b7c17f4f69940d5843e6b785f08687efb377b5157d5b267d1205e596eb5c1966f1afb8ab36bcc2491c46252099e3e844c91f5623da8ded2e358d46338d
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 27, 2020
Summary: Backport of core [[bitcoin/bitcoin#14168 | PR14168]]. Depends on D5054. Test Plan: ninja all check make check cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF ninja all check ../configure --disable-wallet make check Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5058
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 7, 2021
7d038dc [build] remove ENABLE_WALLET ifdef from httprpc.cpp (John Newbery) 3076556 [build] Move dummy wallet into its own .cpp file. (John Newbery) Pull request description: This removes the final instances of ENABLE_WALLET in libbitcoin_server and so completes bitcoin#7965. Tree-SHA512: a49128b7c17f4f69940d5843e6b785f08687efb377b5157d5b267d1205e596eb5c1966f1afb8ab36bcc2491c46252099e3e844c91f5623da8ded2e358d46338d # Conflicts: # src/init.cpp
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 3, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 3, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 5, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 5, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 5, 2021
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 6, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 8, 2021
5tefan
added a commit
to 5tefan/dash
that referenced
this pull request
Aug 10, 2021
7d038dc [build] remove ENABLE_WALLET ifdef from httprpc.cpp (John Newbery) 3076556 [build] Move dummy wallet into its own .cpp file. (John Newbery) Pull request description: This removes the final instances of ENABLE_WALLET in libbitcoin_server and so completes bitcoin#7965. Tree-SHA512: a49128b7c17f4f69940d5843e6b785f08687efb377b5157d5b267d1205e596eb5c1966f1afb8ab36bcc2491c46252099e3e844c91f5623da8ded2e358d46338d
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 11, 2021
5tefan
pushed a commit
to 5tefan/dash
that referenced
this pull request
Aug 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the final instances of ENABLE_WALLET in libbitcoin_server and so completes #7965.