Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Sep 5, 2018

Github-Pull: #14100
Rebased-From: e9a78e9

Includes the bumped manpages.

PR bitcoin#12713 changed the interpretation for negation of non-boolean options
(e.g. -noconnect) to no longer set the option to 0, but to remove it
from the options.

I think this is better because it gets rid of the special meaning of
'0'.

However it needs to be documented. I attempt to do so in this PR.
Addreses bitcoin#14064.

Github-Pull: bitcoin#14100
Rebased-From: e9a78e9
@maflcko maflcko added the Docs label Sep 5, 2018
@maflcko maflcko force-pushed the Mf1809-017Backports branch from 5df9660 to 6bfee8a Compare September 5, 2018 18:51
@fanquake fanquake added this to the 0.17.0 milestone Sep 5, 2018
@fanquake fanquake changed the title [0.17 Backport] doc: Change documentation for =0 for non-boolean options [0.17] doc: Change documentation for =0 for non-boolean options Sep 6, 2018
@fanquake
Copy link
Member

fanquake commented Sep 6, 2018

utACK 6bfee8a

@laanwj laanwj merged commit 6bfee8a into bitcoin:0.17 Sep 6, 2018
laanwj added a commit that referenced this pull request Sep 6, 2018
… options

6bfee8a doc: Update v0.17.0.0 manpages (MarcoFalke)
2936dbc doc: Change documentation for =0 for non-boolean options (Wladimir J. van der Laan)

Pull request description:

  Github-Pull: #14100
  Rebased-From: e9a78e9

  Includes the bumped manpages.

Tree-SHA512: 73d2dadb45418882122313975c0ab0e9f58310697d996dd2edeb400ebe73b3a45f1157c8a7fe65ae1f53d9ce68a88aae7c701f3e82e0b4db4c9417b36ddfecc0
@laanwj
Copy link
Member

laanwj commented Sep 6, 2018

utACK 6bfee8a

@maflcko maflcko deleted the Mf1809-017Backports branch September 6, 2018 14:27
@bitcoin bitcoin deleted a comment Sep 6, 2018
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants