-
Notifications
You must be signed in to change notification settings - Fork 37.7k
gitian-linux: Build binaries for 64-bit POWER #14066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Concept ACK Not convinced, though, that we need a set of both big and little-endian binaries. What is the default on this platform? If you can only test little-endian, I think it's better to leave it at that. Also (not for this PR): what would be really interesting is running the gitian build (for all platforms) on the secure workstation. This would remove the single point of failure of dependency Intel/AMD platforms for the build. |
There is no default. Some older systems can only boot to big endian. Newer systems come in either BE and LE variant. Unfortunately, one cannot run even static BE binaries on LE or vice-versa (on Linux, anyway). |
At least RHEL, SuSE, and Adélie ship big-endian images. Big endian is simple to run in KVM paravirt on the little-endian systems with a performance hit of less than 1%. This should be very easy to test, especially with Gentoo, since Gentoo can make a cross-root somewhere and then you can just point KVM at that disk. Any POWER7 or older system, including most workstations before the Talos (including IBM's post-RS and Apple's 970), are exclusively big endian. Any system (of any generation) running openSuSE Tumbleweed or Adélie is exclusively big endian. |
Those are outside the scope of this PR, though, OP mentions this is POWER8+. |
05cd16b
to
c921a19
Compare
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK, a few questions though.
f81ba95
to
02ba489
Compare
Github-Pull: bitcoin#14066 Rebased-From: 1228df0
Github-Pull: bitcoin#14066 Rebased-From: 408a238
Github-Pull: bitcoin#14066 Rebased-From: 2a50974
Github-Pull: bitcoin#14066 Rebased-From: 069b7fa
Gitian builds
|
622de1c
to
06b6d53
Compare
Changes from bitcoin#14066.
Changes from bitcoin#14066.
Changes from bitcoin#14066.
Changes from bitcoin#14066.
06b6d53
to
31dbf0b
Compare
Now that #20434 is merged the symbol/security tooling-related changes should be able to be dropped here. |
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Changes from bitcoin#14066.
Would be good to get this in early in the 0.22 cycle. But it needs rebase; ping @luke-jr . |
Closing in favor of #20963. |
543bf74 gitian-linux: Extend noexec-stack workaround to powerpc (Wladimir J. van der Laan) 00f67c8 gitian-linux: Build binaries for 64-bit POWER (Luke Dashjr) 63fc2b1 gitian: Properly quote arguments in wrappers (Luke Dashjr) 798bc0b Support glibc-back-compat on 64-bit POWER (Luke Dashjr) Pull request description: Rebase of #14066 by luke-jr. Let's try to get PowerPC support in in the beginning of the 22.0 cycle so that it gets some testing, and is not a last-minute decision this time, like for last … 2 or 3 major versions. The symbol/security tooling-related changes have been dropped since they were part of #20434. Top commit has no ACKs. Tree-SHA512: df0f8cd320c90f359f8b512c5cb8b59bb277516b57a05482cc8923c656106513b7428e315aaa8ab53e0bd6f80556b07d3639c47f6d9913bcfbfe388b39ef47c4
A set of both big and little endian binaries, should be compatible with PowerPC 970 (Apple G5) and newer.
Also splits libpng out of Qt (since Qt's bundled copy is broken on POWER) and disables JPEG (since we don't use it).Tested only the little endian variant, on Gentoo.
(Based on #14065)