Skip to content

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Aug 26, 2018

A set of both big and little endian binaries, should be compatible with PowerPC 970 (Apple G5) and newer.

Also splits libpng out of Qt (since Qt's bundled copy is broken on POWER) and disables JPEG (since we don't use it).

Tested only the little endian variant, on Gentoo.

(Based on #14065)

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 26, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@laanwj
Copy link
Member

laanwj commented Aug 27, 2018

Concept ACK

Not convinced, though, that we need a set of both big and little-endian binaries. What is the default on this platform? If you can only test little-endian, I think it's better to leave it at that.
(looks like both Debian and Fedora support LE, or are moving to it)

Also (not for this PR): what would be really interesting is running the gitian build (for all platforms) on the secure workstation. This would remove the single point of failure of dependency Intel/AMD platforms for the build.

@luke-jr
Copy link
Member Author

luke-jr commented Aug 30, 2018

There is no default. Some older systems can only boot to big endian. Newer systems come in either BE and LE variant. Unfortunately, one cannot run even static BE binaries on LE or vice-versa (on Linux, anyway).

@awilfox
Copy link

awilfox commented Aug 30, 2018

At least RHEL, SuSE, and Adélie ship big-endian images.

Big endian is simple to run in KVM paravirt on the little-endian systems with a performance hit of less than 1%. This should be very easy to test, especially with Gentoo, since Gentoo can make a cross-root somewhere and then you can just point KVM at that disk.

Any POWER7 or older system, including most workstations before the Talos (including IBM's post-RS and Apple's 970), are exclusively big endian.

Any system (of any generation) running openSuSE Tumbleweed or Adélie is exclusively big endian.

@laanwj
Copy link
Member

laanwj commented Sep 8, 2018

Any POWER7 or older system, including most workstations before the Talos (including IBM's post-RS and Apple's 970), are exclusively big endian.

Those are outside the scope of this PR, though, OP mentions this is POWER8+.

@luke-jr
Copy link
Member Author

luke-jr commented Sep 18, 2018

Rebased

Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, a few questions though.

@bitcoin bitcoin deleted a comment from DrahtBot Oct 21, 2018
@luke-jr luke-jr force-pushed the gitian_power64 branch 2 times, most recently from f81ba95 to 02ba489 Compare October 22, 2018 12:04
@bitcoin bitcoin deleted a comment from DrahtBot Oct 24, 2018
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Dec 24, 2018
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Dec 24, 2018
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Dec 24, 2018
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Dec 24, 2018
@DrahtBot
Copy link
Contributor

Guix builds

File commit d67883d
(master)
commit f8cb731
(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz 4e64895ca673f44e... 1c81820b04d543dd...
*-aarch64-linux-gnu.tar.gz 59412baa429f4803... 5dc2a94eaa2d701b...
*-arm-linux-gnueabihf-debug.tar.gz 463e2260deb8b17f... 5670537d76a83b2c...
*-arm-linux-gnueabihf.tar.gz b5b819ebe904c8d3... d7bb7e2d75f2b466...
*-riscv64-linux-gnu-debug.tar.gz 07942c124d73619a... a79ac723d8df3b89...
*-riscv64-linux-gnu.tar.gz d8db9b1641e07df6... 48bbc2666ce652a0...
*-win-unsigned.tar.gz 4061f534e46b79ac... 0edd48d828d0ba55...
*-win64-debug.zip 5f9c0b65b643cab3... 3e68aba4980c4394...
*-win64-setup-unsigned.exe 2df62ea3d8d62971... aa0bb79cebe4b9f9...
*-win64.zip a3b3594fbcc248a8... 02c28d554ded69a3...
*-x86_64-linux-gnu-debug.tar.gz 9a98775dcd5ac4ec... 3171288b07d28835...
*-x86_64-linux-gnu.tar.gz 9461e33851c966c7... 16e6a1e5649a2b45...
*.tar.gz 70f224763adead92... b0942820765c35a9...
guix_build.log 5e2deeb86785b090... 6cd0579e43b4f588...
guix_build.log.diff f5ec2913e23b04b6...

@DrahtBot
Copy link
Contributor

Gitian builds

File commit d67883d
(master)
commit f8cb731
(master and this pull)
bitcoin-core-linux-0.21-res.yml fb2670f2f8ab0d0a... 57d59a44bffa740a...
bitcoin-core-osx-0.21-res.yml d24523299fb03e93... 15dbc11fa63ccda4...
bitcoin-core-win-0.21-res.yml 56c065d51ffa9fb6... 250e9b116781e91c...
*-aarch64-linux-gnu-debug.tar.gz b4d05463fda0adac... 05b2ee6295f2e033...
*-aarch64-linux-gnu.tar.gz 3a43937219f4fbef... c00e5233a0c93442...
*-arm-linux-gnueabihf-debug.tar.gz 54e6c6f85955de26... e24bf2d02a8198de...
*-arm-linux-gnueabihf.tar.gz 76dee1ea73dd31b7... feb4e7976ee0ee1d...
*-osx-unsigned.dmg 6d0b6c8274d37dbb... 1c58228bce6b6118...
*-osx64.tar.gz 902a69555d82322d... b13444feb8a9c24a...
*-riscv64-linux-gnu-debug.tar.gz e87c71666376fe9a... d1bf41dc3cabb2b9...
*-riscv64-linux-gnu.tar.gz 38c0ca912040a8b4... 0e4832f29b4f2219...
*-win64-debug.zip f815299d5d2100f2... 2e88232c4e5ea247...
*-win64-setup-unsigned.exe 854105d5cef6ab9c... cb5d93c039b3c21e...
*-win64.zip e01a2d84b4fb5653... 78516aed31be5d0a...
*-x86_64-linux-gnu-debug.tar.gz f75d8220b59ed46e... 52936ad4725853d2...
*-x86_64-linux-gnu.tar.gz a6d8292cf44c959e... 8bdba6613953e49f...
*.tar.gz 70f224763adead92... b0942820765c35a9...
linux-build.log ceaaa58ad271c807... c067489d8a64916f...
osx-build.log e48082cd327972e1... 21a106676aff913c...
win-build.log 4c0c68075af70f26... 98e8b6f1fac30696...
bitcoin-core-linux-0.21-res.yml.diff 52bd17632c91381e...
bitcoin-core-osx-0.21-res.yml.diff 10814c03d2f02a18...
bitcoin-core-win-0.21-res.yml.diff 05c123318fddccb1...
*-powerpc64-linux-gnu-debug.tar.gz 49050c85b7776ebc...
*-powerpc64-linux-gnu.tar.gz 76908c390ae80531...
*-powerpc64le-linux-gnu-debug.tar.gz c84351a042c4aa31...
*-powerpc64le-linux-gnu.tar.gz 766246b8a94227f4...
linux-build.log.diff 6b78b10de4a501ce...
osx-build.log.diff 89499c0a4d99986e...
win-build.log.diff e68c80d64b8709db...

@laanwj laanwj modified the milestones: 0.21.0, 22.0 Nov 2, 2020
laanwj pushed a commit to laanwj/bitcoin that referenced this pull request Nov 20, 2020
laanwj pushed a commit to laanwj/bitcoin that referenced this pull request Nov 21, 2020
laanwj pushed a commit to laanwj/bitcoin that referenced this pull request Nov 22, 2020
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Nov 23, 2020
@laanwj
Copy link
Member

laanwj commented Dec 18, 2020

Now that #20434 is merged the symbol/security tooling-related changes should be able to be dropped here.

@DrahtBot
Copy link
Contributor

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

mjdietzx pushed a commit to mjdietzx/bitcoin that referenced this pull request Dec 26, 2020
@laanwj
Copy link
Member

laanwj commented Jan 11, 2021

Would be good to get this in early in the 0.22 cycle. But it needs rebase; ping @luke-jr .

@laanwj
Copy link
Member

laanwj commented Jan 19, 2021

Closing in favor of #20963.

@laanwj laanwj closed this Jan 19, 2021
laanwj added a commit that referenced this pull request Jan 28, 2021
543bf74 gitian-linux: Extend noexec-stack workaround to powerpc (Wladimir J. van der Laan)
00f67c8 gitian-linux: Build binaries for 64-bit POWER (Luke Dashjr)
63fc2b1 gitian: Properly quote arguments in wrappers (Luke Dashjr)
798bc0b Support glibc-back-compat on 64-bit POWER (Luke Dashjr)

Pull request description:

  Rebase of #14066 by luke-jr.

  Let's try to get PowerPC support in in the beginning of the 22.0 cycle so that it gets some testing, and is not a last-minute decision this time, like for last … 2 or 3 major versions.

  The symbol/security tooling-related changes have been dropped since they were part of #20434.

Top commit has no ACKs.

Tree-SHA512: df0f8cd320c90f359f8b512c5cb8b59bb277516b57a05482cc8923c656106513b7428e315aaa8ab53e0bd6f80556b07d3639c47f6d9913bcfbfe388b39ef47c4
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.