Skip to content

Add const modifier to HTTPRequest methods #14006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2018
Merged

Add const modifier to HTTPRequest methods #14006

merged 1 commit into from
Aug 21, 2018

Conversation

promag
Copy link
Contributor

@promag promag commented Aug 20, 2018

No description provided.

@promag promag mentioned this pull request Aug 20, 2018
Closed
@practicalswift
Copy link
Contributor

utACK 18c49eb

@domob1812
Copy link
Contributor

utACK 18c49eb - thanks for the cleanup!

@l2a5b1
Copy link
Contributor

l2a5b1 commented Aug 20, 2018

thanks @promag - utACK 18c49eb

@DrahtBot
Copy link
Contributor

Note to reviewers: This pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@Empact
Copy link
Contributor

Empact commented Aug 20, 2018

utACK 18c49eb

@laanwj
Copy link
Member

laanwj commented Aug 21, 2018

utACK 18c49eb

@laanwj laanwj merged commit 18c49eb into bitcoin:master Aug 21, 2018
laanwj added a commit that referenced this pull request Aug 21, 2018
@laanwj
Merge #14006: Add const modifier to HTTPRequest methods
df29abf 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
@promag promag deleted the 2018-08-http-request branch August 23, 2018 18:46
@Bushstar Bushstar mentioned this pull request Sep 4, 2018
Merged
codablock pushed a commit to codablock/dash that referenced this pull request Oct 14, 2019
@laanwj @codablock
Merge bitcoin#14006: Add const modifier to HTTPRequest methods
2460894 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Dec 6, 2019
@laanwj @majcosta
Add const modifier to HTTPRequest methods
1fd19cd 
Summary:
This is a backport of Core PR14006

bitcoin/bitcoin#14006

Test Plan:
  ninja check

Reviewers: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4590
jonspock pushed a commit to jonspock/devault that referenced this pull request Sep 29, 2020
@laanwj @jonspock
Add const modifier to HTTPRequest methods
11bf49d 
Summary:
This is a backport of Core PR14006

bitcoin/bitcoin#14006

Test Plan:
  ninja check

Reviewers: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4590
jonspock pushed a commit to jonspock/devault that referenced this pull request Sep 29, 2020
@laanwj @jonspock
Add const modifier to HTTPRequest methods
65998f8 
Summary:
This is a backport of Core PR14006

bitcoin/bitcoin#14006

Test Plan:
  ninja check

Reviewers: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4590
jonspock pushed a commit to jonspock/devault that referenced this pull request Sep 29, 2020
@laanwj @jonspock
Add const modifier to HTTPRequest methods
3a6430f 
Summary:
This is a backport of Core PR14006

bitcoin/bitcoin#14006

Test Plan:
  ninja check

Reviewers: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4590
jonspock pushed a commit to devaultcrypto/devault that referenced this pull request Oct 10, 2020
@laanwj @jonspock
Add const modifier to HTTPRequest methods
9a35935 
Summary:
This is a backport of Core PR14006

bitcoin/bitcoin#14006

Test Plan:
  ninja check

Reviewers: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D4590
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14006: Add const modifier to HTTPRequest methods
da64917 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14006: Add const modifier to HTTPRequest methods
f0b5340 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14006: Add const modifier to HTTPRequest methods
0f733ad 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14006: Add const modifier to HTTPRequest methods
523bd66 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14006: Add const modifier to HTTPRequest methods
5cefd19 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14006: Add const modifier to HTTPRequest methods
a1ad16f 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14006: Add const modifier to HTTPRequest methods
4364af2 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jun 30, 2021
@laanwj @Munkybooty
Merge bitcoin#14006: Add const modifier to HTTPRequest methods
4029e51 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jun 30, 2021
@laanwj @Munkybooty
Merge bitcoin#14006: Add const modifier to HTTPRequest methods
359006c 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jul 1, 2021
@laanwj @Munkybooty
Merge bitcoin#14006: Add const modifier to HTTPRequest methods
2d65062 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#14006: Add const modifier to HTTPRequest methods
a4bf001 
18c49eb http: Add const modifier to HTTPRequest methods (João Barbosa)

Pull request description:

Tree-SHA512: 233617425ff3abc7419817a95337056c190640197c6c4d8b1a0810967d960c0968d02967e16ffbc1af1a2b3117fdc98722bf05e270504d59548e6838fa7f5ffb
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@promag @practicalswift @domob1812 @l2a5b1 @DrahtBot @Empact @laanwj @fanquake