Skip to content

test: Convert non-wallet tests to use our python MiniWallet #20078

@maflcko

Description

@maflcko

It is possible to compile Bitcoin Core without the wallet. Though, many tests require the Bitcoin Core wallet to create and sign transactions. Ideally, every non-wallet test (for example consensus tests) are run even with the Bitcoin Core wallet disabled. This ensures that users running without the wallet can test their Bitcoin Core with the functional test suite.

Thus, tests that use the Bitcoin Core wallet should be rewritten to use the python MiniWallet.

This is an open-ended issue. You can find candidate tests via git grep 'self.skip_if_no_wallet()'. Exclude the tests that start with wallet_, as those are tests that are meant to test the Bitcoin Core wallet.

Refer to #19922 and #19800 as examples on how to approach this issue.

Edit: See also #20078 (comment)

Useful skills:

  • Familiarity with the RPC interface
  • Familiarity with our functional test suite
  • Good python3 skills

Want to work on this issue?

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions