tests: update Wycheproof #1711
Merged
tests: update Wycheproof #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also adjust the references in https://github.com/bitcoin-core/secp256k1/blob/master/src/wycheproof/WYCHEPROOF_COPYING? |
Pulls in relevant changes from C2SP/wycheproof#150.
5796372 to
5433648
Compare
Fixed up. |
josibake
reviewed
Jul 25, 2025
There was a problem hiding this comment.
ACK 5433648
Left a note regarding one of the comments that was touched, but as I understand it this change would need to be made upstream anyways, so not a blocking comment.
(happy to upsteam the change, if I'm understanding the intent of the comment correctly)
| @@ -95,8 +95,8 @@ | |||
| }, | |||
| "SignatureMalleabilityBitcoin" : { | |||
| "bugType" : "SIGNATURE_MALLEABILITY", | |||
| "description" : "\"BitCoins\"-curves are curves where signature malleability can be a serious issue. An implementation should only accept a signature s where s < n/2. If an implementation is not meant for uses cases that require signature malleability then this implementation should be tested with another set of test vectors.", | |||
| "effect" : "In bitcoin exchanges, it may be used to make a double deposits or double withdrawals", | |||
| "description" : "Signature malleability can be a serious issue in Bitcoin. An implementation should only accept a signature s where s < n/2. If an implementation is not meant for use cases that require signature malleability then this implementation should be tested with another set of test vectors.", | |||
There was a problem hiding this comment.
I think this comment should read something like:
Suggested change
| "description" : "Signature malleability can be a serious issue in Bitcoin. An implementation should only accept a signature s where s < n/2. If an implementation is not meant for use cases that require signature malleability then this implementation should be tested with another set of test vectors.", | |
| "description" : "Signature malleability can be a serious issue in Bitcoin. An implementation should only accept a signature s where s < n/2. If an implementation is meant for use cases that require signature malleability then this implementation should be tested with another set of test vectors.", |
There was a problem hiding this comment.
Only one test vector has the SignatureMalleabilityBitcoin flag and it tests a failing signature. So I cannot make sense of the original descriptioin either. Maybe it should say something like:
If an implementation is meant for use cases that tolarete signature malleability then this implementation should not be tested with this set of test vectors.
There was a problem hiding this comment.
Opened C2SP/wycheproof#153 upstream, will pipe through the changes to here if/when the upstream PR is merged.
josibake
added a commit
to josibake/secp256k1
that referenced
this pull request
Jul 31, 2025
Pull in updated test vectors. This update is done as a follow-up to bitcoin-core#1711.
josibake
added a commit
to josibake/secp256k1
that referenced
this pull request
Jul 31, 2025
Pull in updated test vectors. This update is done as a follow-up to bitcoin-core#1711.
real-or-random
added a commit
that referenced
this pull request
Aug 1, 2025
c25c3c8 test: update wycheproof test vectors (josibake) Pull request description: Pull in updated test vectors. This update is done as a follow-up to #1711. ACKs for top commit: real-or-random: ACK c25c3c8 Tree-SHA512: 6f3b41460155a9f78d23711e471e73f732d3f6cdc2442f2f024540c04c3d4ab2ca376d4db020e99b093cd6a95c11f7dd3220f18727d62c4995a9a069d362406d
josibake
added a commit
to josibake/bitcoin
that referenced
this pull request
Sep 5, 2025
aa85bfb530 docs: update README 9f42a30b82 ci: enable silentpayments module d504e48145 tests: add sha256 tag test 124750d580 tests: add constant time tests b35ffa2e30 tests: add BIP-352 test vectors 038c5b9c9d silentpayments: add benchmarks for scanning 88eb3d4545 silentpayments: add examples/silentpayments.c 22b20fd617 silentpayments: receiving df1de93765 silentpayments: recipient label support 76a0451c76 silentpayments: sending 3cd3a93bff build: add skeleton for new silentpayments (BIP352) module f36afb8b3d Merge bitcoin-core/secp256k1#1725: tests: refactor tagged hash verification 5153cf1c91 tests: refactor tagged hash tests d2dcf52091 Merge bitcoin-core/secp256k1#1726: docs: fix broken link to Tromer's cache.pdf paper 489a43d1bf docs: fix broken link to eprint cache.pdf paper d599714147 Merge bitcoin-core/secp256k1#1722: docs: Exclude modules' `bench_impl.h` headers from coverage report 0458def51e doc: Add `--gcov-ignore-parse-errors=all` option to `gcovr` invocations 1aecce5936 doc: Add `--merge-mode-functions=separate` option to `gcovr` invocations 106a7cbf41 doc: Exclude modules' `bench_impl.h` headers from coverage report a9e955d3ea autotools, docs: Adjust help string for `--enable-coverage` option e523e4f90e Merge bitcoin-core/secp256k1#1720: chore(ci): Fix typo in Dockerfile comment 24ba8ff168 chore(ci): Fix typo in Dockerfile comment 74b8068c5d Merge bitcoin-core/secp256k1#1717: test: update wycheproof test vectors c25c3c8a88 test: update wycheproof test vectors 20e3b44746 Merge bitcoin-core/secp256k1#1688: cmake: Avoid contaminating parent project's cache with `BUILD_SHARED_LIBS` 2c076d907a Merge bitcoin-core/secp256k1#1711: tests: update Wycheproof 7b07b22957 cmake: Avoid contaminating parent project's cache with BUILD_SHARED_LIBS 5433648ca0 Fix typos and spellings 9ea54c69b7 tests: update Wycheproof files git-subtree-dir: src/secp256k1 git-subtree-split: aa85bfb530b9ffc3dde6eaa7a976e129b8bd2f58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Wycheproof after C2SP/wycheproof#150.
Cherry-picks the commit from #1686 (let me know if you want this commit message changed).