fix: biome diagnostic about schema #7384
Conversation
🦋 Changeset detectedLatest commit: 1273573 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis change adds a patch-level changeset for @biomejs/biome and adjusts a diagnostic in crates/biome_configuration/src/lib.rs. The diagnostic for a configuration schema version mismatch during Biome configuration deserialisation now uses Severity::Information instead of Severity::Warning. Message, range, notes, and migration hint are unchanged, as are the reporting conditions and control flow. Information-level diagnostics do not interfere with commands run with --error-on-warnings. No public API signatures are modified. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.changeset/gentle-doors-grow.md (1)
5-6: Tighten wording, add link, and end sentences with a full stop.Clarifies which diagnostic changed and satisfies the “end every sentence with a period” guideline.
-Reduced the severity of certain diagnostics emitted when Biome deserializes the configuration files. -Now these diagnostics are emitted as `Information` severity, which means that they won't interfere when running commands with `--error-on-warnings` +Reduced the severity of the configuration schema version mismatch diagnostic emitted when Biome deserializes configuration files. See https://github.com/biomejs/biome/discussions/7376. +These diagnostics are now emitted with `Information` severity, so they no longer interfere when running commands with `--error-on-warnings`.crates/biome_configuration/src/lib.rs (1)
455-466: Use<Info>markup to matchSeverity::InformationWrap the message in
<Info>rather than<Warn>for visual consistency.- markup!(<Warn>"The configuration schema version does not match the CLI version " {VERSION}</Warn>) + markup!(<Info>"The configuration schema version does not match the CLI version " {VERSION}</Info>)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
crates/biome_cli/tests/snapshots/main_commands_lint/should_report_when_schema_version_mismatch.snapis excluded by!**/*.snapand included by**
📒 Files selected for processing (2)
.changeset/gentle-doors-grow.md(1 hunks)crates/biome_configuration/src/lib.rs(1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{rs,toml}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Format Rust and TOML files before committing (use
just f/just format).
Files:
crates/biome_configuration/src/lib.rs
crates/biome_*/**
📄 CodeRabbit inference engine (CLAUDE.md)
Place core crates under /crates/biome_*/
Files:
crates/biome_configuration/src/lib.rs
crates/biome_configuration/src/**
📄 CodeRabbit inference engine (CLAUDE.md)
Keep configuration sources under biome_configuration/src/
Files:
crates/biome_configuration/src/lib.rs
.changeset/*.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
.changeset/*.md: Create changesets withjust new-changeset; store them in.changeset/with correct frontmatter (package keys and change type).
In changeset descriptions, follow content conventions: user-facing changes only; past tense for what you did; present tense for current behavior; link issues for fixes; link rules/assists; include representative code blocks; end every sentence with a period.
When adding headers in a changeset, only use #### or ##### levels.
Files:
.changeset/gentle-doors-grow.md
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_diagnostics/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:46:05.836Z
Learning: Applies to crates/biome_diagnostics/**/*.rs : Specify category and severity using #[diagnostic(...)] on the type or derive them from fields
Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_diagnostics/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:46:05.836Z
Learning: Applies to crates/biome_diagnostics/**/*.rs : Use helper advice types from biome_diagnostics::v2 (CodeFrameAdvice, CommandAdvice, DiffAdvice, LogAdvice) when suitable
Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_diagnostics/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:46:05.836Z
Learning: Applies to crates/biome_diagnostics/**/*.rs : Types implementing Diagnostic must also implement Debug (e.g., use #[derive(Debug, Diagnostic)])
📚 Learning: 2025-08-11T11:46:05.836Z
Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_diagnostics/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:46:05.836Z
Learning: Applies to crates/biome_diagnostics/**/*.rs : Specify category and severity using #[diagnostic(...)] on the type or derive them from fields
Applied to files:
crates/biome_configuration/src/lib.rs.changeset/gentle-doors-grow.md
📚 Learning: 2025-08-11T11:46:05.836Z
Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_diagnostics/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:46:05.836Z
Learning: Applies to crates/biome_diagnostics/**/*.rs : Use helper advice types from biome_diagnostics::v2 (CodeFrameAdvice, CommandAdvice, DiffAdvice, LogAdvice) when suitable
Applied to files:
crates/biome_configuration/src/lib.rs
🧬 Code graph analysis (1)
crates/biome_configuration/src/lib.rs (1)
packages/@biomejs/plugin-api/index.d.ts (1)
Severity(1-1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (24)
- GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
- GitHub Check: Test (depot-windows-2022-16)
- GitHub Check: Test (depot-ubuntu-24.04-arm-16)
- GitHub Check: Documentation
- GitHub Check: Lint project (depot-windows-2022)
- GitHub Check: Check Dependencies
- GitHub Check: Bench (biome_js_parser)
- GitHub Check: Bench (biome_package)
- GitHub Check: Bench (biome_graphql_formatter)
- GitHub Check: Bench (biome_json_analyze)
- GitHub Check: Bench (biome_html_parser)
- GitHub Check: Bench (biome_json_formatter)
- GitHub Check: Bench (biome_configuration)
- GitHub Check: Bench (biome_js_formatter)
- GitHub Check: Bench (biome_css_formatter)
- GitHub Check: Bench (biome_html_formatter)
- GitHub Check: Bench (biome_module_graph)
- GitHub Check: Bench (biome_json_parser)
- GitHub Check: Bench (biome_graphql_parser)
- GitHub Check: Bench (biome_css_analyze)
- GitHub Check: Bench (biome_js_analyze)
- GitHub Check: Bench (biome_css_parser)
- GitHub Check: Test Node.js API
- GitHub Check: autofix
🔇 Additional comments (2)
.changeset/gentle-doors-grow.md (1)
2-2: Changeset front‑matter looks correct.Package key and patch bump are fine.
crates/biome_configuration/src/lib.rs (1)
460-460: Severity downgrade to Information — LGTM.Matches the intent to avoid tripping
--error-on-warnings.
CodSpeed Performance ReportMerging #7384 will not alter performanceComparing Summary
Footnotes |
Summary
Closes #7376
Test Plan
Snapshot updated
Docs