fix(core): ignore nested configs #6662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2c8d765 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Thank you for looking into this! We should update our docs and provide an example for this use case, and while doing so, we should highlight the fact that this "feature" works only when the nested configurations are specified in files.includes. Meaning that VCS ignore files aren't taken into consideration
CodSpeed Performance ReportMerging #6662 will not alter performanceComparing Summary
|
b903dc0 to
1876202
Compare
|
I've pushed a docs update to biomejs/website#2604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6509.
If a nested configuration file is ignored by the root configuration, it will now actually be ignored.
Biome has an exception in place for configuration files so they cannot be ignored, because the configuration files are vital to Biome itself. But this exception was incorrectly applied to nested configurations as well. Now only the root configuration is exempt from being ignored.
Additionally, I ran into quite a bit of a refactoring. I moved most of the implementation of
WorkspaceServer::file_features()intoprojects.rs, so that we can again save ourselves some cloning and unnecessary Papaya lookups. But it turned outWorkspaceSettingsHandlewas getting in the way of me doing that, so I had a hard look atWorkspaceSettingsHandleitself. Turned out thatWorkspaceSettingsHandlewas entirely unnecessary, and the fact it wrapped settings in anOptionwas unnecessary too. So I removedWorkspaceSettingsHandleand a lot of places that used to passOption<&Settings>now pass a plain&Settings.Test Plan
Test added and snapshots updated.
You may notice that for some snapshots, the amount of files checked has decreased by one. These are nested configuration files that were checked before, where this behaviour is unexpected with the new logic.