Skip to content

docs: update contribution guide and pull request template #6664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2025
Merged

docs: update contribution guide and pull request template #6664

merged 3 commits into from
Jul 8, 2025

Conversation

ematipico
Copy link
Member

Summary

@arendjr, you were the main promoter of this change, so please have a look at this PR and change it according to what you had in mind

Test Plan

@ematipico ematipico requested a review from arendjr July 2, 2025 11:07
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4190482

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ematipico ematipico requested a review from a team July 2, 2025 11:07
dyc3
dyc3 reviewed Jul 2, 2025
View reviewed changes
@dyc3 dyc3 mentioned this pull request Jul 3, 2025
Merged
arendjr
arendjr approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually a bit different from what I had in mind, but I think it achieves the same thing :) Pushed a bunch of clarifications still, but I'm happy with this!

@ematipico
Copy link
Member Author

Thank you @arendjr !

@ematipico ematipico requested a review from dyc3 July 8, 2025 12:59
@ematipico
Copy link
Member Author

@dyc3 does the new version address your comment?

@dyc3
Copy link
Contributor

dyc3 commented Jul 8, 2025

Yeah I think so.

arendjr
arendjr reviewed Jul 8, 2025
View reviewed changes
@arendjr arendjr merged commit cb63f8c into main Jul 8, 2025
2 checks passed
@arendjr arendjr deleted the docs/main-vs-next branch July 8, 2025 13:54
josh- pushed a commit to josh-/biome that referenced this pull request Jul 9, 2025
@ematipico @arendjr @josh-
docs: update contribution guide and pull request template (biomejs#6664)
87d19e6 
Co-authored-by: Arend van Beelen jr. <arend@arendjr.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arendjr arendjr arendjr approved these changes

@dyc3 dyc3 dyc3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ematipico @dyc3 @arendjr