Skip to content

Conversation

Renerick
Copy link
Collaborator

@Renerick Renerick commented Mar 10, 2024

Description

Seems like Safari on iOS 17.4 doesn't correctly set event.target from custom events dispatched from JS. Earlier same issue occurred in my htmx-signalr extension: Renerick/htmx-signalr#11

Corresponding issue: https://discord.com/channels/725789699527933952/1216185723229704222

Testing

I've ran the test suite and verified that test server still works. However, I don't have iOS 17.4 device at hand, so will have to ask the user to verify if it works.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

Implemented after Safari on iOS 17.4 broke event.target for custom events.
Reported in https://discord.com/channels/725789699527933952/1216185723229704222
@Renerick Renerick added the bug Something isn't working label Mar 10, 2024
@andryyy
Copy link

andryyy commented Mar 10, 2024

Why are they doing this again and again and again…

Nice catch!

@nickchomey
Copy link
Contributor

By chance are you based in the EU? Because the biggest changes in 17.4 are likely to affect EU users in particular - despite the biggest changes being rescinded due to our advocacy work.

https://open-web-advocacy.org/blog/apple-backs-off-killing-web-apps/

@soyangel
Copy link

By chance are you based in the EU? Because the biggest changes in 17.4 are likely to affect EU users in particular - despite the biggest changes being rescinded due to our advocacy work.

https://open-web-advocacy.org/blog/apple-backs-off-killing-web-apps/

Not OP but had the same bug but when using SSE. I'm in the EU and I'm wondering if this also happens for users outside the EU.

@kxzk
Copy link

kxzk commented Mar 11, 2024

By chance are you based in the EU? Because the biggest changes in 17.4 are likely to affect EU users in particular - despite the biggest changes being rescinded due to our advocacy work.
https://open-web-advocacy.org/blog/apple-backs-off-killing-web-apps/

Not OP but had the same bug but when using SSE. I'm in the EU and I'm wondering if this also happens for users outside the EU.

In the US, happening for me as well.

Renerick added a commit to bigskysoftware/htmx-extensions that referenced this pull request Mar 13, 2024
1cg added a commit to bigskysoftware/htmx-extensions that referenced this pull request Mar 13, 2024
@1cg 1cg merged commit 263c37e into dev Mar 14, 2024
@Renerick Renerick deleted the ws-fix-for-safari-ios-17.4 branch March 14, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants