-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
WS.js fix for Safari on iOS 17.4 #2391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Implemented after Safari on iOS 17.4 broke event.target for custom events. Reported in https://discord.com/channels/725789699527933952/1216185723229704222
Why are they doing this again and again and again… Nice catch! |
By chance are you based in the EU? Because the biggest changes in 17.4 are likely to affect EU users in particular - despite the biggest changes being rescinded due to our advocacy work. https://open-web-advocacy.org/blog/apple-backs-off-killing-web-apps/ |
Not OP but had the same bug but when using SSE. I'm in the EU and I'm wondering if this also happens for users outside the EU. |
In the US, happening for me as well. |
Description
Seems like Safari on iOS 17.4 doesn't correctly set
event.target
from custom events dispatched from JS. Earlier same issue occurred in my htmx-signalr extension: Renerick/htmx-signalr#11Corresponding issue: https://discord.com/channels/725789699527933952/1216185723229704222
Testing
I've ran the test suite and verified that test server still works. However, I don't have iOS 17.4 device at hand, so will have to ask the user to verify if it works.
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded