Updated mocha, tests now work with node 20 #2122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run tests for v2.0v2.0 branch too
Telroshan
added a commit
to Telroshan/htmx
that referenced
this pull request
Dec 26, 2023
* Updated mocha, tests now work with node 20 * Update package-lock.json * Enable Node CI for v2.0v2.0 branch (bigskysoftware#2123) Run tests for v2.0v2.0 branch too * Bump CI's node version to 20.x
bb010g
added a commit
to bb010g/_hyperscript
that referenced
this pull request
Dec 31, 2023
Mocha v10 is required by <https://github.com/Telroshan/mocha-chrome>, which fixes mocha-chrome on newer Node releases, including Node v18. See <bigskysoftware/htmx#2122> for more details.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get tests running with latest node (v20.10.0)
mocha-chrome is obsolete and doesn't seem to be maintained anymore
There was a PR on the repo that had been closed and never opened again
Those changes actually make mocha-chrome work perfectly with the htmx test suite, so for now I cloned it and put it on a fork