bzlmod: Remove build_file_proto_mode attribute
#3506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By updating gazelle to a version that maintains a central registry of gazelle overrides, specifying `build_file_proto_mode` on `github.com/gogo/protobuf` is no longer necessary. This will allow us to get rid of the rules_go exception after the next rules_go release.
tyler-french
approved these changes
Mar 31, 2023
linzhp
pushed a commit
that referenced
this pull request
Apr 20, 2023
By updating gazelle to a version that maintains a central registry of gazelle overrides, specifying `build_file_proto_mode` on `github.com/gogo/protobuf` is no longer necessary. This will allow us to get rid of the rules_go exception after the next rules_go release.
tingilee
pushed a commit
to tingilee/rules_go
that referenced
this pull request
Jul 19, 2023
By updating gazelle to a version that maintains a central registry of gazelle overrides, specifying `build_file_proto_mode` on `github.com/gogo/protobuf` is no longer necessary. This will allow us to get rid of the rules_go exception after the next rules_go release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
By updating gazelle to a version that maintains a central registry of gazelle overrides, specifying
build_file_proto_modeongithub.com/gogo/protobufis no longer necessary.This will allow us to get rid of the rules_go exception after the next rules_go release.
Which issues(s) does this PR fix?
Fixes #
Other notes for review