Skip to content

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Apr 19, 2025

What type of PR is this?
Bug fix

What does this PR do? Why is it needed?
A test case/suite's duration can be nil in the test JSON. We should check it before dereference it.

Which issues(s) does this PR fix?

Fixes #4318

Other notes for review

@linzhp linzhp requested a review from fmeum April 19, 2025 17:41
@fmeum fmeum merged commit a67f6c1 into bazel-contrib:master Apr 19, 2025
1 check passed
@linzhp linzhp deleted the duration branch May 12, 2025 19:39
linzhp added a commit that referenced this pull request May 20, 2025
**What type of PR is this?**
Bug fix

**What does this PR do? Why is it needed?**
A test case/suite's duration can be nil in the test JSON. We should
check it before dereference it.

**Which issues(s) does this PR fix?**

Fixes #4318

**Other notes for review**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault in xml.go
2 participants