-
-
Notifications
You must be signed in to change notification settings - Fork 702
Fix incompatibility with --incompatible_auto_exec_groups
#4141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--incompatible_auto_exec_groups
--incompatible_auto_exec_groups
and update protobuf
d95c676
to
2ab62b6
Compare
fmeum
added a commit
that referenced
this pull request
Nov 14, 2024
Many other rulesets (such as rules_java and protobuf) have dropped support for Bazel 5. We also drop support for Bzlmod with Bazel 6 due to rules_jvm_external doing so. This should unblock #4141. Also remove unnecessary CI exclusions.
0a1946e
to
6239ea9
Compare
501d3d5
to
b13845f
Compare
# Conflicts: # MODULE.bazel
# Conflicts: # .bazelci/presubmit.yml # go/private/actions/compilepkg.bzl
--incompatible_auto_exec_groups
and update protobuf--incompatible_auto_exec_groups
jayconrod
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Incompatible change
What does this PR do? Why is it needed?
This requires setting the
toolchain
on actions and updating protobuf.Which issues(s) does this PR fix?
Fix #4139
Other notes for review