feat(presets): always fetch all coverage files on coverage runs #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abc0da8 to
8d90fcb
Compare
gregmagolan
reviewed
Oct 4, 2023
gregmagolan
reviewed
Oct 4, 2023
gregmagolan
reviewed
Oct 4, 2023
gregmagolan
approved these changes
Oct 4, 2023
8d90fcb to
d324dcd
Compare
d324dcd to
e0a8f16
Compare
alexeagle
pushed a commit
that referenced
this pull request
Oct 5, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that combined coverage reports make sense when build without the bytes is enabled.
Type of change
For changes visible to end-users
--experimental_fetch_all_coverage_outputsis now enabled in the correctness bazelrc presetsTest plan