Skip to content

implementing missing parts of multi-track support for charts & panels #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 26, 2020
Merged

implementing missing parts of multi-track support for charts & panels #668

merged 7 commits into from
Oct 26, 2020

Conversation

ElderOrb
Copy link
Collaborator

No description provided.

@dericed
Copy link
Member

dericed commented Oct 26, 2020

Hmm, getting a

../../../../Source/Core/FileInformation.cpp:195:77: error: 'auto' not allowed in lambda parameter
            CommonStats::statsFromExternalData(Xml, Xml_SizeForParsing, [&](auto type, auto index) -> CommonStats* {
                                                                            ^~~~
../../../../Source/Core/FileInformation.cpp:195:88: error: 'auto' not allowed in lambda parameter
            CommonStats::statsFromExternalData(Xml, Xml_SizeForParsing, [&](auto type, auto index) -> CommonStats* {
                                                                                       ^~~~

@dericed
Copy link
Member

dericed commented Oct 26, 2020

This works great :) and makes a huge difference. Thanks @ElderOrb.
I did get a crash which I logged at https://gist.github.com/dericed/1e7b6d6cf4e6b4b1bed263be277632a9, but uncertain if it's related to this PR.

@dericed dericed merged commit 211fa06 into bavc:master Oct 26, 2020
@dericed dericed mentioned this pull request Oct 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElderOrb @dericed